Patch Detail
Show a patch.
GET /api/patches/11365/?format=api
{ "id": 11365, "url": "https://patchwork.libcamera.org/api/patches/11365/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11365/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210223135331.2711706-1-jacopo@jmondi.org>", "date": "2021-02-23T13:53:31", "name": "[libcamera-devel] libcamera: ipu3: Initialize V|H flip support", "commit_ref": "f8a70a8a745d83c956b32ec28dc2488e099e2486", "pull_url": null, "state": "accepted", "archived": false, "hash": "f9547d989e1731637672d933810a275fdc36e6bc", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11365/mbox/", "series": [ { "id": 1721, "url": "https://patchwork.libcamera.org/api/series/1721/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1721", "date": "2021-02-23T13:53:31", "name": "[libcamera-devel] libcamera: ipu3: Initialize V|H flip support", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1721/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11365/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11365/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E5FF9BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Feb 2021 13:53:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 886EA68A2B;\n\tTue, 23 Feb 2021 14:53:10 +0100 (CET)", "from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 76508689DD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Feb 2021 14:53:09 +0100 (CET)", "from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id C42184000A;\n\tTue, 23 Feb 2021 13:53:08 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 23 Feb 2021 14:53:31 +0100", "Message-Id": "<20210223135331.2711706-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.30.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: ipu3: Initialize V|H flip\n\tsupport", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The flag that is used to record if the sensor driver supports the H/V flip\ncontrols is initialized at camera creation time, but it was not\ninitialized by the IPU3Camera constructor, resulting in erroneous\nvalues that might break capture for sensor that do not support flipping.\n\nFix this by initializing the flag in the class constructor.\n\nFixes: 6c4ce7de30c8 (\"libcamera: ipu3: Add rotation to ipu3 pipeline\")\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n--\n2.30.0", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex daace29f71ea..2838196a4b21 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -56,7 +56,7 @@ class IPU3CameraData : public CameraData\n {\n public:\n \tIPU3CameraData(PipelineHandler *pipe)\n-\t\t: CameraData(pipe), exposureTime_(0)\n+\t\t: CameraData(pipe), exposureTime_(0), supportsFlips_(false)\n \t{\n \t}\n\n", "prefixes": [ "libcamera-devel" ] }