Patch Detail
Show a patch.
GET /api/patches/11354/?format=api
{ "id": 11354, "url": "https://patchwork.libcamera.org/api/patches/11354/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11354/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210222094608.1541623-1-kieran.bingham@ideasonboard.com>", "date": "2021-02-22T09:46:08", "name": "[libcamera-devel] clang-format: Enable sorted includes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "46ad2ea9b48382c0dad5776fa28a8e2885b1c547", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11354/mbox/", "series": [ { "id": 1715, "url": "https://patchwork.libcamera.org/api/series/1715/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1715", "date": "2021-02-22T09:46:08", "name": "[libcamera-devel] clang-format: Enable sorted includes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1715/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11354/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11354/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65E7EBD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 22 Feb 2021 09:46:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB2AC689FE;\n\tMon, 22 Feb 2021 10:46:13 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9372B602F3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 22 Feb 2021 10:46:12 +0100 (CET)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0F072344;\n\tMon, 22 Feb 2021 10:46:12 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M6jU/8Zc\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613987172;\n\tbh=ZkHTB2yjqs7YbXsHLLH+RMjJSPWbfJy9vI0FizPDUAE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=M6jU/8ZcaS2hoQ+ZHfw4R6x96hTJ001ehnkrrXcIGT4kNsqnMqtyTDAHW36vXJHmg\n\t/etg6g7g0NseoZJJeGsAioCWFfAbAgF/xzk+PMNamU3x+6yHbsvwq8PJbOmL9zrle2\n\tREMu+Qzxsydv5co7BLnI1F6ppCDY6hpn7c83JvdA=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 22 Feb 2021 09:46:08 +0000", "Message-Id": "<20210222094608.1541623-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210222032915.31452-1-laurent.pinchart@ideasonboard.com>", "References": "<20210222032915.31452-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] clang-format: Enable sorted includes", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We aim to ensure that our includes are alphabetically sorted. Whilst\ncheckstyle.py also handles this, enable the clang-format explicitly to\ndefine the code-style requirement, and allow clang-format to also\ncorrect un-sorted header includes.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nI can't see why this isn't enabled, unless clang-format is sorting in a\nmanner which is incompatible with the implementation in our\ncheckstyle.py ?\n\nSome initial testing shows that clang-format only sorts per block,\nseparated by newlines, which seems to match our implementation.\n\n\n .clang-format | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/.clang-format b/.clang-format\nindex bef07cd84338..f5d9ba940eeb 100644\n--- a/.clang-format\n+++ b/.clang-format\n@@ -97,7 +97,7 @@ PenaltyReturnTypeOnItsOwnLine: 60\n \n PointerAlignment: Right\n ReflowComments: false\n-SortIncludes: false\n+SortIncludes: true\n #SortUsingDeclarations: false # Unknown to clang-format-4.0\n SpaceAfterCStyleCast: false\n SpaceAfterTemplateKeyword: false\n", "prefixes": [ "libcamera-devel" ] }