Patch Detail
Show a patch.
GET /api/patches/11353/?format=api
{ "id": 11353, "url": "https://patchwork.libcamera.org/api/patches/11353/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11353/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210222080112.72521-3-paul.elder@ideasonboard.com>", "date": "2021-02-22T08:01:12", "name": "[libcamera-devel,v2,2/2] android: camera_device: Set the camera location to Front if External", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3c9721b9aac416f17b71c0a1160ba8f0722a5fa7", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11353/mbox/", "series": [ { "id": 1714, "url": "https://patchwork.libcamera.org/api/series/1714/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1714", "date": "2021-02-22T08:01:10", "name": "Fix camera location", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1714/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11353/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11353/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50DC4BD1F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 22 Feb 2021 08:01:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 161AA68A01;\n\tMon, 22 Feb 2021 09:01:37 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB93E689EA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 22 Feb 2021 09:01:35 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 19D84344;\n\tMon, 22 Feb 2021 09:01:32 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"a9SFSctg\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613980895;\n\tbh=hjzuJ8bvR9XmD/RkKVlB0p8PlG0TMS8+qNatkv9wm50=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=a9SFSctgRgmYeby/gLdorDSe9DaVBeogIDD05ToklcokLP5xqOizNsDPIvwJEt+yt\n\thijEvL0MdcNp/M4TAqt9BAsF1cjBdwb22Dai4lXhkH2cPT+00CMGrt0TnunGGvhUxa\n\tqbGnhxdeWBc9PdyqyvOj7UCxnaCKrO6nYO+xV8hs=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 22 Feb 2021 17:01:12 +0900", "Message-Id": "<20210222080112.72521-3-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210222080112.72521-1-paul.elder@ideasonboard.com>", "References": "<20210222080112.72521-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 2/2] android: camera_device: Set the\n\tcamera location to Front if External", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Our android HAL implementation currently does not support external\ncameras, so if the camera location property is external, set it to\nfront.\n\nThis allows the following CTS test to pass:\n- android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nNo change in v2\n---\n src/android/camera_device.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 1e2a5b5f..16cb8c6d 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -405,7 +405,11 @@ int CameraDevice::initialize()\n \t\t\tfacing_ = CAMERA_FACING_BACK;\n \t\t\tbreak;\n \t\tcase properties::CameraLocationExternal:\n-\t\t\tfacing_ = CAMERA_FACING_EXTERNAL;\n+\t\t\t/*\n+\t\t\t * \\todo Set this to EXTERNAL once we support\n+\t\t\t * HARDWARE_LEVEL_EXTERNAL\n+\t\t\t */\n+\t\t\tfacing_ = CAMERA_FACING_FRONT;\n \t\t\tbreak;\n \t\t}\n \t}\n", "prefixes": [ "libcamera-devel", "v2", "2/2" ] }