Patch Detail
Show a patch.
GET /api/patches/11349/?format=api
{ "id": 11349, "url": "https://patchwork.libcamera.org/api/patches/11349/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11349/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210222032915.31452-1-laurent.pinchart@ideasonboard.com>", "date": "2021-02-22T03:29:14", "name": "[libcamera-devel,1/2] clang-format: Update to clang-format-7", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3ac2d8866e2dd5d8bb4a7101849d8f012c1bb904", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11349/mbox/", "series": [ { "id": 1713, "url": "https://patchwork.libcamera.org/api/series/1713/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1713", "date": "2021-02-22T03:29:14", "name": "[libcamera-devel,1/2] clang-format: Update to clang-format-7", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1713/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11349/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11349/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F37A1BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 22 Feb 2021 03:29:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 44B26689F6;\n\tMon, 22 Feb 2021 04:29:48 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1ABDC602F1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 22 Feb 2021 04:29:47 +0100 (CET)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AF387344\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 22 Feb 2021 04:29:46 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Bx5vbgwQ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613964586;\n\tbh=4dHVUGNr4IMJ4EASIYVVJgWaNrlNjSKID7wY6BFv4Xs=;\n\th=From:To:Subject:Date:From;\n\tb=Bx5vbgwQqkWBMcR9B3YTO0RUujxazxbc99cqPoeaz6cluha/vDc7TZMkB0igJuaRD\n\t+MjcPSVAyjL5kIp2KNGcjiSxYfShdIzjG+YqsIKbLRvh1k3KnE4QCZR+Mkuj7CsEq9\n\t2wu5zFr4cTj96yZnAnZZl1yRWsmGuxEtmucOtmZI=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 22 Feb 2021 05:29:14 +0200", "Message-Id": "<20210222032915.31452-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.28.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/2] clang-format: Update to clang-format-7", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add all options available in the new version that were previously\ncommented out (or just not listed). The commented out value is replaced\nby the clang-format-7 default where they differ, to avoid changing the\ncurrent behaviour.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n .clang-format | 43 +++++++++++++++++++++++--------------------\n 1 file changed, 23 insertions(+), 20 deletions(-)", "diff": "diff --git a/.clang-format b/.clang-format\nindex bef07cd84338..c561a8d9245b 100644\n--- a/.clang-format\n+++ b/.clang-format\n@@ -1,6 +1,6 @@\n # SPDX-License-Identifier: GPL-2.0-only\n #\n-# clang-format configuration file. Intended for clang-format >= 4.\n+# clang-format configuration file. Intended for clang-format >= 7.\n #\n # For more information, see:\n #\n@@ -9,11 +9,12 @@\n # https://clang.llvm.org/docs/ClangFormatStyleOptions.html\n #\n ---\n+Language: Cpp\n AccessModifierOffset: -8\n AlignAfterOpenBracket: Align\n AlignConsecutiveAssignments: false\n AlignConsecutiveDeclarations: false\n-#AlignEscapedNewlines: Left # Unknown to clang-format-4.0\n+AlignEscapedNewlines: Right\n AlignOperands: true\n AlignTrailingComments: false\n AllowAllParametersOfDeclarationOnNextLine: false\n@@ -25,7 +26,7 @@ AllowShortLoopsOnASingleLine: false\n AlwaysBreakAfterDefinitionReturnType: None\n AlwaysBreakAfterReturnType: None\n AlwaysBreakBeforeMultilineStrings: false\n-AlwaysBreakTemplateDeclarations: false\n+AlwaysBreakTemplateDeclarations: MultiLine\n BinPackArguments: true\n BinPackParameters: true\n BraceWrapping:\n@@ -37,24 +38,24 @@ BraceWrapping:\n AfterObjCDeclaration: false\n AfterStruct: false\n AfterUnion: false\n- #AfterExternBlock: false # Unknown to clang-format-5.0\n+ AfterExternBlock: false\n BeforeCatch: false\n BeforeElse: false\n IndentBraces: false\n- #SplitEmptyFunction: true # Unknown to clang-format-4.0\n- #SplitEmptyRecord: true # Unknown to clang-format-4.0\n- #SplitEmptyNamespace: true # Unknown to clang-format-4.0\n+ SplitEmptyFunction: true\n+ SplitEmptyRecord: true\n+ SplitEmptyNamespace: true\n BreakBeforeBinaryOperators: None\n BreakBeforeBraces: Custom\n-#BreakBeforeInheritanceComma: false # Unknown to clang-format-4.0\n+BreakBeforeInheritanceComma: false\n+BreakInheritanceList: BeforeColon\n BreakBeforeTernaryOperators: true\n-BreakConstructorInitializersBeforeComma: false\n-#BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0\n+BreakConstructorInitializers: BeforeColon\n BreakAfterJavaFieldAnnotations: false\n BreakStringLiterals: false\n ColumnLimit: 0\n CommentPragmas: '^ IWYU pragma:'\n-#CompactNamespaces: false # Unknown to clang-format-4.0\n+CompactNamespaces: false\n ConstructorInitializerAllOnOneLineOrOnePerLine: false\n ConstructorInitializerIndentWidth: 8\n ContinuationIndentWidth: 8\n@@ -62,16 +63,16 @@ Cpp11BracedListStyle: false\n DerivePointerAlignment: false\n DisableFormat: false\n ExperimentalAutoDetectBinPacking: false\n-#FixNamespaceComments: false # Unknown to clang-format-4.0\n+FixNamespaceComments: true\n ForEachMacros:\n - 'udev_list_entry_foreach'\n-#IncludeBlocks: Preserve # Unknown to clang-format-5.0\n+IncludeBlocks: Preserve\n IncludeCategories:\n - Regex: '.*'\n Priority: 1\n IncludeIsMainRegex: '(_test)?$'\n IndentCaseLabels: false\n-#IndentPPDirectives: None # Unknown to clang-format-5.0\n+IndentPPDirectives: None\n IndentWidth: 8\n IndentWrappedFunctionNames: false\n JavaScriptQuotes: Leave\n@@ -81,31 +82,33 @@ MacroBlockBegin: ''\n MacroBlockEnd: ''\n MaxEmptyLinesToKeep: 1\n NamespaceIndentation: None\n-#ObjCBinPackProtocolList: Auto # Unknown to clang-format-5.0\n+ObjCBinPackProtocolList: Auto\n ObjCBlockIndentWidth: 8\n ObjCSpaceAfterProperty: true\n ObjCSpaceBeforeProtocolList: true\n \n # Taken from git's rules\n-#PenaltyBreakAssignment: 10 # Unknown to clang-format-4.0\n+PenaltyBreakAssignment: 10\n PenaltyBreakBeforeFirstCallParameter: 30\n PenaltyBreakComment: 10\n PenaltyBreakFirstLessLess: 0\n PenaltyBreakString: 10\n+PenaltyBreakTemplateDeclaration: 10\n PenaltyExcessCharacter: 100\n PenaltyReturnTypeOnItsOwnLine: 60\n \n PointerAlignment: Right\n ReflowComments: false\n SortIncludes: false\n-#SortUsingDeclarations: false # Unknown to clang-format-4.0\n+SortUsingDeclarations: true\n SpaceAfterCStyleCast: false\n SpaceAfterTemplateKeyword: false\n SpaceBeforeAssignmentOperators: true\n-#SpaceBeforeCtorInitializerColon: true # Unknown to clang-format-5.0\n-#SpaceBeforeInheritanceColon: true # Unknown to clang-format-5.0\n+SpaceBeforeCpp11BracedList: false\n+SpaceBeforeCtorInitializerColon: true\n+SpaceBeforeInheritanceColon: true\n SpaceBeforeParens: ControlStatements\n-#SpaceBeforeRangeBasedForLoopColon: true # Unknown to clang-format-5.0\n+SpaceBeforeRangeBasedForLoopColon: true\n SpaceInEmptyParentheses: false\n SpacesBeforeTrailingComments: 1\n SpacesInAngles: false\n", "prefixes": [ "libcamera-devel", "1/2" ] }