Patch Detail
Show a patch.
GET /api/patches/11344/?format=api
{ "id": 11344, "url": "https://patchwork.libcamera.org/api/patches/11344/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11344/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210219112257.53307-1-jacopo@jmondi.org>", "date": "2021-02-19T11:22:57", "name": "[libcamera-devel] libcamera: ipu3: Do not over-write metadata", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2cd89a092a7f6f0b523e5e63368f15fb47e25b64", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11344/mbox/", "series": [ { "id": 1710, "url": "https://patchwork.libcamera.org/api/series/1710/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1710", "date": "2021-02-19T11:22:57", "name": "[libcamera-devel] libcamera: ipu3: Do not over-write metadata", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1710/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11344/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11344/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1361ABD1F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 19 Feb 2021 11:22:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A9F54689C8;\n\tFri, 19 Feb 2021 12:22:42 +0100 (CET)", "from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 47E3F602F5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Feb 2021 12:22:41 +0100 (CET)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 008F460008\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Feb 2021 11:22:40 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 19 Feb 2021 12:22:57 +0100", "Message-Id": "<20210219112257.53307-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.30.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: ipu3: Do not over-write\n\tmetadata", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When a Request is completed upon receiving the IPA produced metadata,\nthe metadata associated with the Request are over-written, deleting\nthe information set, in example, at ImgU output buffer completion time.\n\nIf any additional Request metadata should be registered by inspecting\nthe IPA produced metadata it has to be done without deleting the already\nregistered entries.\n\nFix this by replacing the metadata over-write with a todo entry.\n\nThis change fixes CTS which was broken due to missing metadata in\nthe completed requests.\n\nFixes: 9708f49fecf2 (\"libcamera: ipu3: Share parameter and statistic buffers with IPA\")\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)\n\n--\n2.30.0", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 2aed826a892a..9e867ab2e98a 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -1101,8 +1101,11 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n \t\tif (!info)\n \t\t\tbreak;\n\n+\t\t/*\n+\t\t * \\todo Parse the value of the controls returned by the IPA\n+\t\t * in action.controls to register additional request metadata.\n+\t\t */\n \t\tRequest *request = info->request;\n-\t\trequest->metadata() = action.controls;\n \t\tinfo->metadataProcessed = true;\n \t\tif (frameInfos_.tryComplete(info))\n \t\t\tpipe_->completeRequest(request);\n", "prefixes": [ "libcamera-devel" ] }