Patch Detail
Show a patch.
GET /api/patches/11342/?format=api
{ "id": 11342, "url": "https://patchwork.libcamera.org/api/patches/11342/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11342/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210219104544.53217-2-paul.elder@ideasonboard.com>", "date": "2021-02-19T10:45:43", "name": "[libcamera-devel,1/2] libcamera: camera_sensor: Print warning when orientation is unknown", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0a531549f21494da5d3289c1e35c63582ce6c707", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11342/mbox/", "series": [ { "id": 1709, "url": "https://patchwork.libcamera.org/api/series/1709/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1709", "date": "2021-02-19T10:45:42", "name": "Fix camera location", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1709/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11342/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11342/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 423B5BD1F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 19 Feb 2021 10:46:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12BA3689C6;\n\tFri, 19 Feb 2021 11:46:11 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24C91637DC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Feb 2021 11:46:09 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A06FD344;\n\tFri, 19 Feb 2021 11:46:06 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"R9fS+c2X\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613731568;\n\tbh=7CiGv1dE4O6EYqM9CVO1bBOkUwWhKoV9/JODarpYMJU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=R9fS+c2XSkeCwBptaMPt0dr65lGDarBZJEfU99YAGBeYsIYNxbGR6kR5FlfP+FfXn\n\tHNJYiKsks0gJa2qbCwPYoV2sJTiIPK4afY9MO/UNqzMX+WBET4PxnL49IpjCI6x+CD\n\tULB8g19ooMZHTjCBcwdUwBCl43g/Q+4e0jrS63yw=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 19 Feb 2021 19:45:43 +0900", "Message-Id": "<20210219104544.53217-2-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210219104544.53217-1-paul.elder@ideasonboard.com>", "References": "<20210219104544.53217-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Print\n\twarning when orientation is unknown", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Print a warining when the orientation of a sensor is unknown. The\nlocation property is still defaulted to external.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/libcamera/camera_sensor.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex c9e8d49b..397df266 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -446,6 +446,8 @@ int CameraSensor::initProperties()\n \t\t\tbreak;\n \t\t}\n \t} else {\n+\t\tLOG(CameraSensor, Warning)\n+\t\t\t<< \"No camera location, setting to External\";\n \t\tpropertyValue = properties::CameraLocationExternal;\n \t}\n \tproperties_.set(properties::Location, propertyValue);\n", "prefixes": [ "libcamera-devel", "1/2" ] }