Patch Detail
Show a patch.
GET /api/patches/11298/?format=api
{ "id": 11298, "url": "https://patchwork.libcamera.org/api/patches/11298/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11298/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210215101200.149457-5-paul.elder@ideasonboard.com>", "date": "2021-02-15T10:12:00", "name": "[libcamera-devel,v3,4/4] cam: Print unknown location", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "5a081f295e796fc3a5a1fda8802eb87c69370651", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11298/mbox/", "series": [ { "id": 1693, "url": "https://patchwork.libcamera.org/api/series/1693/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1693", "date": "2021-02-15T10:11:56", "name": "Add Unknown camera location", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1693/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11298/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11298/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 46B17BD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 15 Feb 2021 10:12:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 16C2D637C9;\n\tMon, 15 Feb 2021 11:12:24 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D9B86375F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 15 Feb 2021 11:12:22 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 052A1743;\n\tMon, 15 Feb 2021 11:12:20 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HDazMhqr\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613383942;\n\tbh=Lepowur9CMGnSW/wO1rxCZCbniYZrEQq0T2N5GikfEE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=HDazMhqr/ttvuIUSuAE4aq1YiSNmJ1Ct2izi5mvoh7B0SjY5zBiPc/xjvVvzSFG4d\n\tWDcbBzZRw29tAQTwvhpJOjbPaz1RqI7Q/px4KIRddxbqjr677zVmTlDorqCDhNf+QU\n\t8ss1+6IDy1dc5S/owoasiRKZIawrp3J7y4DJOvTQ=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 15 Feb 2021 19:12:00 +0900", "Message-Id": "<20210215101200.149457-5-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210215101200.149457-1-paul.elder@ideasonboard.com>", "References": "<20210215101200.149457-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 4/4] cam: Print unknown location", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that we default the camera sensor location to Unknown, print that\nthe location is unknown in cam. We report the location as unknown\ninstead of defaulting to something else since cam is a test tool.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nChanges in v3:\n- report the location as unknown\n\nNew in v2\n---\n src/cam/main.cpp | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex e01be63a..14f12e9d 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -379,7 +379,8 @@ std::string const CamApp::cameraName(const Camera *camera)\n \tconst ControlList &props = camera->properties();\n \tstd::string name;\n \n-\tswitch (props.get(properties::Location)) {\n+\tint location = props.get(properties::Location);\n+\tswitch (location) {\n \tcase properties::CameraLocationFront:\n \t\tname = \"Internal front camera\";\n \t\tbreak;\n@@ -387,7 +388,10 @@ std::string const CamApp::cameraName(const Camera *camera)\n \t\tname = \"Internal back camera\";\n \t\tbreak;\n \tcase properties::CameraLocationExternal:\n-\t\tname = \"External camera\";\n+\tcase properties::CameraLocationUnknown:\n+\t\tname = location == properties::CameraLocationExternal ?\n+\t\t\t\t \"External camera\" :\n+\t\t\t\t \"Unknown Location\";\n \t\tif (props.contains(properties::Model))\n \t\t\tname += \" '\" + props.get(properties::Model) + \"'\";\n \t\tbreak;\n", "prefixes": [ "libcamera-devel", "v3", "4/4" ] }