Patch Detail
Show a patch.
GET /api/patches/11297/?format=api
{ "id": 11297, "url": "https://patchwork.libcamera.org/api/patches/11297/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11297/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210215101200.149457-4-paul.elder@ideasonboard.com>", "date": "2021-02-15T10:11:59", "name": "[libcamera-devel,v3,3/4] android: camera_device: Default the camera location to Front", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "23f932035083ac2132a951be038285a0233fda06", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11297/mbox/", "series": [ { "id": 1693, "url": "https://patchwork.libcamera.org/api/series/1693/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1693", "date": "2021-02-15T10:11:56", "name": "Add Unknown camera location", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1693/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11297/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11297/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC569BD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 15 Feb 2021 10:12:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AB216637BF;\n\tMon, 15 Feb 2021 11:12:21 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B6166375F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 15 Feb 2021 11:12:20 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E7A0A743;\n\tMon, 15 Feb 2021 11:12:17 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XwnxwPep\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613383940;\n\tbh=Sop2kqB8sDHrMsH4tqyNKwgLSxVC8Yg/QD8dAbMVcJA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=XwnxwPepY2PwpoJv0qoW/sdCE+mwVcPK5Lqnl5t0qSmPGaxsvaIMtIVOXMPr7Uba2\n\tuayQqxPE8jRMJmO60viTkjakARBpY3BUvWPSVH0G87Tbxg0vX3TMEDbvuIIlfv/wNx\n\to2xo6coekbiZOz2jFQEpG5w/MmUkEZ4G90ixiK6U=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 15 Feb 2021 19:11:59 +0900", "Message-Id": "<20210215101200.149457-4-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210215101200.149457-1-paul.elder@ideasonboard.com>", "References": "<20210215101200.149457-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 3/4] android: camera_device: Default\n\tthe camera location to Front", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since the libcamera camera now has an Unknown location, we can know if\nthe camera's location is actually unknown. In this case, set the android\ncamera location to front, as some systems may not support external\ncameras.\n\nThis allows the following CTS test to pass:\n- android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\n---\nChanges in v3:\n- print warning when defaulting to front from unknown location\n\nNo change in v2\n---\n src/android/camera_device.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 1e2a5b5f..a4447c16 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -407,6 +407,11 @@ int CameraDevice::initialize()\n \t\tcase properties::CameraLocationExternal:\n \t\t\tfacing_ = CAMERA_FACING_EXTERNAL;\n \t\t\tbreak;\n+\t\tcase properties::CameraLocationUnknown:\n+\t\t\tLOG(HAL, Warning)\n+\t\t\t\t<< \"Unknown camera location, defaulting to front\";\n+\t\t\tfacing_ = CAMERA_FACING_FRONT;\n+\t\t\tbreak;\n \t\t}\n \t}\n \n", "prefixes": [ "libcamera-devel", "v3", "3/4" ] }