Patch Detail
Show a patch.
GET /api/patches/11259/?format=api
{ "id": 11259, "url": "https://patchwork.libcamera.org/api/patches/11259/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11259/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210212131851.22059-1-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-02-12T13:18:51", "name": "[libcamera-devel,v2] libcamera: ipu3: set V4L2_CID_INTEL_IPU3_MODE", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "704eb2d0705d7b6869bf0c6df894c9157df0be85", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11259/mbox/", "series": [ { "id": 1684, "url": "https://patchwork.libcamera.org/api/series/1684/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1684", "date": "2021-02-12T13:18:51", "name": "[libcamera-devel,v2] libcamera: ipu3: set V4L2_CID_INTEL_IPU3_MODE", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1684/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11259/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11259/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4EB05BD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Feb 2021 13:18:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D7D786377C;\n\tFri, 12 Feb 2021 14:18:57 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C624563772\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Feb 2021 14:18:55 +0100 (CET)", "from localhost.localdomain (unknown\n\t[IPv6:2a01:e0a:169:7140:4c8b:e37:8e78:b4b6])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 479BD8B5;\n\tFri, 12 Feb 2021 14:18:55 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"N+yB6RqM\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613135935;\n\tbh=KuKx2Gj42rvP9V2/2ogu5Xo2K8yZucBa4w3T6sP+qwE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=N+yB6RqMPb38OEh6/+49qW3jH3ZIyP0PmkYIP0581bCCBN0PcbV2+V2bWs9eKWRuN\n\tRFRisjHKnfI94SHA/EYs0HPbZc/LDdXRhhPIRzwBrzvfmgVWdaQk5NbqrBJhzlHnuq\n\tz1hELhAouXUDztRP/U7P4usfR3G1yCbux4RkcErc=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 12 Feb 2021 14:18:51 +0100", "Message-Id": "<20210212131851.22059-1-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In order to get the stats back, the imgu subdev needs to have the\nV4L2_CID_INTEL_IPU3_MODE control set.\nSet it to video mode by default to get the stats at each frame.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 61f7bf43..6957e3a9 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -551,9 +551,13 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \n \t/* Apply the \"pipe_mode\" control to the ImgU subdevice. */\n \tControlList ctrls(imgu->imgu_->controls());\n+\t/*\n+\t * \\todo Set the ImgU pipe mode to 'Video' unconditionally to have statistics\n+\t * generated and re-consider if 'Still Capture' should be used for\n+\t * high quality RAW capture operations that do not involve the IPA.\n+\t */\n \tctrls.set(V4L2_CID_IPU3_PIPE_MODE,\n-\t\t static_cast<int32_t>(vfCfg ? IPU3PipeModeVideo :\n-\t\t\t\t IPU3PipeModeStillCapture));\n+\t\t static_cast<int32_t>(IPU3PipeModeVideo));\n \tret = imgu->imgu_->setControls(&ctrls);\n \tif (ret) {\n \t\tLOG(IPU3, Error) << \"Unable to set pipe_mode control\";\n", "prefixes": [ "libcamera-devel", "v2" ] }