Patch Detail
Show a patch.
GET /api/patches/11247/?format=api
{ "id": 11247, "url": "https://patchwork.libcamera.org/api/patches/11247/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11247/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210212054816.53561-3-paul.elder@ideasonboard.com>", "date": "2021-02-12T05:48:14", "name": "[libcamera-devel,v2,2/4] libcamera: camera_sensor: Set default sensor location to Unknown", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "d53bf4b343f897dc22f330b76513703ce99a8b42", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11247/mbox/", "series": [ { "id": 1680, "url": "https://patchwork.libcamera.org/api/series/1680/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1680", "date": "2021-02-12T05:48:12", "name": "Add Unknown camera location", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1680/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11247/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11247/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D8F0BD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Feb 2021 05:48:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F037E63765;\n\tFri, 12 Feb 2021 06:48:33 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 65D7F63758\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Feb 2021 06:48:33 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 67F44124E;\n\tFri, 12 Feb 2021 06:48:30 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Mkbmowz+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613108912;\n\tbh=2ufzNI+bsxDLi0ANeeTgoB/+RCBgT9je6ZEEGngyLFg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Mkbmowz+7ixtZi0sqAk5lDVi1lrPPD7thXehDEG1FVlF7SAe20nRJ/AoBJVvbu+B0\n\tngYcAV9zr+m4pOQAZmCZf9cx8bZeOYTTzDv/jvw6D1Bacd+oCC8YxDNB/IE/iPmueH\n\txDQ1idgMTVtAUBDKKSd5emhFZm3MER0H5FPWi2kU=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 12 Feb 2021 14:48:14 +0900", "Message-Id": "<20210212054816.53561-3-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210212054816.53561-1-paul.elder@ideasonboard.com>", "References": "<20210212054816.53561-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 2/4] libcamera: camera_sensor: Set\n\tdefault sensor location to Unknown", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Instead of choosing some arbitrary location for the sensor when its\nlocation is unknown, set it explicitly to unknown.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nNo change in v2\n---\n src/libcamera/camera_sensor.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex c9e8d49b..474055ba 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -446,7 +446,7 @@ int CameraSensor::initProperties()\n \t\t\tbreak;\n \t\t}\n \t} else {\n-\t\tpropertyValue = properties::CameraLocationExternal;\n+\t\tpropertyValue = properties::CameraLocationUnknown;\n \t}\n \tproperties_.set(properties::Location, propertyValue);\n \n", "prefixes": [ "libcamera-devel", "v2", "2/4" ] }