Patch Detail
Show a patch.
GET /api/patches/11237/?format=api
{ "id": 11237, "url": "https://patchwork.libcamera.org/api/patches/11237/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11237/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210211085527.44667-4-paul.elder@ideasonboard.com>", "date": "2021-02-11T08:55:27", "name": "[libcamera-devel,3/3] android: camera_device: Default the camera location to Front", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "70cce0a12e892c491ef3a44fd397d85860ab9934", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11237/mbox/", "series": [ { "id": 1678, "url": "https://patchwork.libcamera.org/api/series/1678/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1678", "date": "2021-02-11T08:55:24", "name": "Add Unknown camera location", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1678/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11237/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11237/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D2F8BD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 11 Feb 2021 08:55:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 294716373E;\n\tThu, 11 Feb 2021 09:55:47 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5EA6F61630\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Feb 2021 09:55:46 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CA05B41;\n\tThu, 11 Feb 2021 09:55:44 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SE0HvJc/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613033746;\n\tbh=SGlJpVIsswTvQ06AQ4tmYhpdpzuBnQdKH6Jhr4QGotE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=SE0HvJc/H6RBwhQrUk91+jjOEZf/RiF7JGQCGvjKQaCQMEgBt58/uJItxtiucoMpQ\n\tFI5zBpen1qhnzqjyjj35Z47ls1IUtVNv9HwCKUuzGaGpTw9Fw0uFujTlEub8g5Xu6L\n\tNObRXrmSIlG5Ybp6YGvIMOUQ2azqHNVfpUp4AcO4=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 11 Feb 2021 17:55:27 +0900", "Message-Id": "<20210211085527.44667-4-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210211085527.44667-1-paul.elder@ideasonboard.com>", "References": "<20210211085527.44667-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 3/3] android: camera_device: Default the\n\tcamera location to Front", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since the libcamera camera now has an Unknown location, we can know if\nthe camera's location is actually unknown. In this case, set the android\ncamera location to front, as some systems may not support external\ncameras.\n\nThis allows the following CTS test to pass:\n- android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/android/camera_device.cpp | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 1e2a5b5f..3d815d21 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -407,6 +407,9 @@ int CameraDevice::initialize()\n \t\tcase properties::CameraLocationExternal:\n \t\t\tfacing_ = CAMERA_FACING_EXTERNAL;\n \t\t\tbreak;\n+\t\tcase properties::CameraLocationUnknown:\n+\t\t\tfacing_ = CAMERA_FACING_FRONT;\n+\t\t\tbreak;\n \t\t}\n \t}\n \n", "prefixes": [ "libcamera-devel", "3/3" ] }