Patch Detail
Show a patch.
GET /api/patches/11235/?format=api
{ "id": 11235, "url": "https://patchwork.libcamera.org/api/patches/11235/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11235/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210211085527.44667-2-paul.elder@ideasonboard.com>", "date": "2021-02-11T08:55:25", "name": "[libcamera-devel,1/3] libcamera: properties: Add Unknown value to camera Location", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4525c757fadb279c42445c0c76b09050de465b8d", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11235/mbox/", "series": [ { "id": 1678, "url": "https://patchwork.libcamera.org/api/series/1678/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1678", "date": "2021-02-11T08:55:24", "name": "Add Unknown camera location", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1678/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11235/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11235/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A1ABBD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 11 Feb 2021 08:55:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 692F36346C;\n\tThu, 11 Feb 2021 09:55:45 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6897261630\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Feb 2021 09:55:42 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E495841;\n\tThu, 11 Feb 2021 09:55:40 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GN6BdRoX\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613033742;\n\tbh=R2CGovBWzgwEKSGlaFhBGGrk0+ein2BLpXEATT1Xe+g=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GN6BdRoXuuoqGMvdxkb1i+3NhwcAwh+d27nePbMIfLjOAqKLu1k7EVRm1fIGa/8Zb\n\teQLut4dV4jSbM8oqGcKV58OX4zmmhLyC0VbAMT1HZTnWhEbk+ZsE8DzqrasBaj0j6C\n\tpHMyXC/dgKRNKftDHKIrPylzW16yFy1iizA8yEvg=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 11 Feb 2021 17:55:25 +0900", "Message-Id": "<20210211085527.44667-2-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210211085527.44667-1-paul.elder@ideasonboard.com>", "References": "<20210211085527.44667-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/3] libcamera: properties: Add Unknown\n\tvalue to camera Location", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If a camera's location is unknown, it should be set so, and not\ndefaulted to another location. Add such a value to the Location property\nenum.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/libcamera/property_ids.yaml | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex 104e9aaf..66deaa84 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -25,6 +25,10 @@ controls:\n description: |\n The camera is attached to the device in a way that allows it to\n be moved freely\n+ - name: CameraLocationUnknown\n+ value: 3\n+ description: |\n+ The camera location is unknown\n \n - Rotation:\n type: int32_t\n", "prefixes": [ "libcamera-devel", "1/3" ] }