Patch Detail
Show a patch.
GET /api/patches/11182/?format=api
{ "id": 11182, "url": "https://patchwork.libcamera.org/api/patches/11182/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11182/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210208013903.30915-1-laurent.pinchart@ideasonboard.com>", "date": "2021-02-08T01:39:03", "name": "[libcamera-devel,PATCH/RFC] libcamera: camera_sensor: Accept entities exposing the ISP function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8f9613247024b81ecd43fa9b57ce5c95a230f94a", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": { "id": 14, "url": "https://patchwork.libcamera.org/api/users/14/?format=api", "username": "pinchartl", "first_name": "Laurent", "last_name": "Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/11182/mbox/", "series": [ { "id": 1662, "url": "https://patchwork.libcamera.org/api/series/1662/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1662", "date": "2021-02-08T01:39:03", "name": "[libcamera-devel,PATCH/RFC] libcamera: camera_sensor: Accept entities exposing the ISP function", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1662/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11182/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11182/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 059A5BD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 8 Feb 2021 01:39:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6F5360300;\n\tMon, 8 Feb 2021 02:39:31 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E23EE60106\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 8 Feb 2021 02:39:30 +0100 (CET)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F6683D7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 8 Feb 2021 02:39:30 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UHvHTQa6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612748370;\n\tbh=2D8K6fHSmazw1XqYdcg51KXaE4nCsli32T8qtrz+Ycs=;\n\th=From:To:Subject:Date:From;\n\tb=UHvHTQa6lpjNOqDpfjIfZmbbFfiM666Dq5w/DLQvyLYBTXWHbBcKbTxRNMewxDYOh\n\tJFw90SWcfm4BY6NlTXZK2REHbFh/qs4GOlLm9Xu3+BAXFbEWhEJyet5BD/iTRS5Pvd\n\tFdPan+gkKZMBf/CBWqHKJrzZBwx3nr8lmcrT5BfQ=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 8 Feb 2021 03:39:03 +0200", "Message-Id": "<20210208013903.30915-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.28.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH/RFC] libcamera: camera_sensor: Accept\n\tentities exposing the ISP function", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Camera sensors can include an ISP, which may be reported as a separate\nentity from the pixel array in the media graph.\n\nSupport such sensors by accepting MEDIA_ENT_F_PROC_VIDEO_ISP as a valid\nentity type. This allows using sensors that can be fully (or at least\nmeaningfully) configured through the ISP's source pad only. Sensors that\nrequire further configuration, on the ISP sink pad and/or on the pixel\narray's source pad, will require further extension to the CameraSensor\nclass.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/camera_sensor.cpp | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)\n\nThis patch depends on the new MEDIA_ENT_F_PROC_VIDEO_ISP entity\nfunction, which will be available in v5.12-rc1. I'll update the kernel\nheaders when that kernel will be released, in a few weeks from now.", "diff": "diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 59834ffcdd94..8158a84b63db 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -198,7 +198,12 @@ int CameraSensor::init()\n \t\treturn -EINVAL;\n \t}\n \n-\tif (entity_->function() != MEDIA_ENT_F_CAM_SENSOR) {\n+\tswitch (entity_->function()) {\n+\tcase MEDIA_ENT_F_CAM_SENSOR:\n+\tcase MEDIA_ENT_F_PROC_VIDEO_ISP:\n+\t\tbreak;\n+\n+\tdefault:\n \t\tLOG(CameraSensor, Error)\n \t\t\t<< \"Invalid sensor function \"\n \t\t\t<< utils::hex(entity_->function());\n", "prefixes": [ "libcamera-devel", "PATCH/RFC" ] }