Patch Detail
Show a patch.
GET /api/patches/1117/?format=api
{ "id": 1117, "url": "https://patchwork.libcamera.org/api/patches/1117/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1117/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190426160615.22309-1-laurent.pinchart@ideasonboard.com>", "date": "2019-04-26T16:06:15", "name": "[libcamera-devel] libcamera: Remove outdated \\todo comments", "commit_ref": "2ab299a27686776d45699c7cea6ba9ce4af6d514", "pull_url": null, "state": "accepted", "archived": false, "hash": "85827da54894c82c21905abb0a147b915989a94f", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1117/mbox/", "series": [ { "id": 274, "url": "https://patchwork.libcamera.org/api/series/274/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=274", "date": "2019-04-26T16:06:15", "name": "[libcamera-devel] libcamera: Remove outdated \\todo comments", "version": 1, "mbox": "https://patchwork.libcamera.org/series/274/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1117/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1117/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BE2960E9A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Apr 2019 18:06:30 +0200 (CEST)", "from pendragon.station (net-37-182-44-227.cust.vodafonedsl.it\n\t[37.182.44.227])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B459E5F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Apr 2019 18:06:29 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556294789;\n\tbh=sXLTWQ/b0bCSTkxvciLojZGWnB/oIGf01B4o1rPhs2A=;\n\th=From:To:Subject:Date:From;\n\tb=V5KtKTUMgip+VFOEqBe9PGfxwTf8rOu9qmfQJueX2DYNQGITEqY/qwk6P7tps+J2s\n\ttESeTLcymwEfvpr6bio360mbc6nagvfQ6/rkq5D+BEuoh7Ndiw3G+aYp7MsScNz+JA\n\th83BgyEP9i1mRjhcaVkSwEn2VYpx8plRhIHQcK7E=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 26 Apr 2019 19:06:15 +0300", "Message-Id": "<20190426160615.22309-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: Remove outdated \\todo comments", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 26 Apr 2019 16:06:30 -0000" }, "content": "Some \\todo comments are outdated and refer to tasks that have been\ncompleted. Remove them.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/camera_manager.cpp | 3 ---\n src/libcamera/device_enumerator.cpp | 1 -\n src/libcamera/v4l2_device.cpp | 6 ++----\n 3 files changed, 2 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex 58d3b0ddb8bb..40a39bd2a6d9 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -50,9 +50,6 @@ LOG_DEFINE_CATEGORY(Camera)\n * references it held to cameras, the camera manager can be stopped with\n * stop().\n *\n- * \\todo Add ability to add and remove media devices based on hot-(un)plug\n- * events coming from the device enumerator.\n- *\n * \\todo Add interface to register a notification callback to the user to be\n * able to inform it new cameras have been hot-plugged or cameras have been\n * removed due to hot-unplug.\ndiff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\nindex f3f26d98b65e..49467546bab8 100644\n--- a/src/libcamera/device_enumerator.cpp\n+++ b/src/libcamera/device_enumerator.cpp\n@@ -40,7 +40,6 @@\n * expressed in a DeviceMatch object.\n *\n * \\todo Add sysfs based device enumerator.\n- * \\todo Add support for hot-plug and hot-unplug.\n */\n \n namespace libcamera {\ndiff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex cfdce4813da4..a6e9ca247828 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -750,9 +750,6 @@ int V4L2Device::releaseBuffers()\n * processed by the device. Once the device has finished processing the buffer,\n * it will be available for dequeue.\n *\n- * \\todo Support output devices (bytesused, ...)\n- * \\todo Support imported buffers (dmabuf fd)\n- *\n * \\return 0 on success or a negative error code otherwise\n */\n int V4L2Device::queueBuffer(Buffer *buffer)\n@@ -904,7 +901,8 @@ int V4L2Device::streamOn()\n /**\n * \\brief Stop the video stream\n *\n- * \\todo Ensure completion notifications are sent for all queued buffers\n+ * Buffers that are still queued when the video stream is stopped are\n+ * implicitly dequeued, but no bufferReady signal is emitted for them.\n *\n * \\return 0 on success or a negative error code otherwise\n */\n", "prefixes": [ "libcamera-devel" ] }