Patch Detail
Show a patch.
GET /api/patches/11167/?format=api
{ "id": 11167, "url": "https://patchwork.libcamera.org/api/patches/11167/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11167/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210204232613.494121-6-niklas.soderlund@ragnatech.se>", "date": "2021-02-04T23:26:07", "name": "[libcamera-devel,v4,05/11] libcamera: ipu3: cio2: Generate start of frame event", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "33c8e275be0bc72a55880fb6ae09cad86d6c4338", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11167/mbox/", "series": [ { "id": 1656, "url": "https://patchwork.libcamera.org/api/series/1656/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1656", "date": "2021-02-04T23:26:02", "name": "libcamera: ipu3: Attach to an skeleton IPA", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1656/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11167/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11167/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79973BD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 4 Feb 2021 23:27:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 429E8614B2;\n\tFri, 5 Feb 2021 00:27:13 +0100 (CET)", "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CBDF8614A1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 5 Feb 2021 00:27:10 +0100 (CET)", "from bismarck.berto.se (p4fca2458.dip0.t-ipconnect.de\n\t[79.202.36.88])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 808cc5a8-6740-11eb-b73f-0050569116f7;\n\tFri, 05 Feb 2021 00:27:10 +0100 (CET)" ], "X-Halon-ID": "808cc5a8-6740-11eb-b73f-0050569116f7", "Authorized-sender": "niklas.soderlund@fsdn.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 5 Feb 2021 00:26:07 +0100", "Message-Id": "<20210204232613.494121-6-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20210204232613.494121-1-niklas.soderlund@ragnatech.se>", "References": "<20210204232613.494121-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 05/11] libcamera: ipu3: cio2: Generate\n\tstart of frame event", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Propagate the frameStart event whenever the CSI-2 receiver in the CIO2\npipeline generates one.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n* Changes since v1\n- Move blank lines.\n---\n src/libcamera/pipeline/ipu3/cio2.cpp | 18 +++++++++++++++---\n src/libcamera/pipeline/ipu3/cio2.h | 3 ++-\n 2 files changed, 17 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\nindex c7fabb98cd6b3438..0ef3bc04659b4d16 100644\n--- a/src/libcamera/pipeline/ipu3/cio2.cpp\n+++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n@@ -238,15 +238,27 @@ int CIO2Device::start()\n \t\tavailableBuffers_.push(buffer.get());\n \n \tret = output_->streamOn();\n-\tif (ret)\n+\tif (ret) {\n \t\tfreeBuffers();\n+\t\treturn ret;\n+\t}\n \n-\treturn ret;\n+\tret = csi2_->setFrameStartEnabled(true);\n+\tif (ret) {\n+\t\tstop();\n+\t\treturn ret;\n+\t}\n+\n+\treturn 0;\n }\n \n int CIO2Device::stop()\n {\n-\tint ret = output_->streamOff();\n+\tint ret;\n+\n+\tcsi2_->setFrameStartEnabled(false);\n+\n+\tret = output_->streamOff();\n \n \tfreeBuffers();\n \ndiff --git a/src/libcamera/pipeline/ipu3/cio2.h b/src/libcamera/pipeline/ipu3/cio2.h\nindex dca4d40e4c32e8b2..5ecc4f47bb3cdb3f 100644\n--- a/src/libcamera/pipeline/ipu3/cio2.h\n+++ b/src/libcamera/pipeline/ipu3/cio2.h\n@@ -13,6 +13,7 @@\n \n #include <libcamera/signal.h>\n \n+#include \"libcamera/internal/v4l2_subdevice.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\n \n namespace libcamera {\n@@ -24,7 +25,6 @@ class PixelFormat;\n class Request;\n class Size;\n class SizeRange;\n-class V4L2Subdevice;\n struct StreamConfiguration;\n \n class CIO2Device\n@@ -54,6 +54,7 @@ public:\n \tFrameBuffer *queueBuffer(Request *request, FrameBuffer *rawBuffer);\n \tvoid tryReturnBuffer(FrameBuffer *buffer);\n \tSignal<FrameBuffer *> &bufferReady() { return output_->bufferReady; }\n+\tSignal<uint32_t> &frameStart() { return csi2_->frameStart; }\n \n private:\n \tvoid freeBuffers();\n", "prefixes": [ "libcamera-devel", "v4", "05/11" ] }