Patch Detail
Show a patch.
GET /api/patches/1113/?format=api
{ "id": 1113, "url": "https://patchwork.libcamera.org/api/patches/1113/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1113/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190426150155.18652-8-laurent.pinchart@ideasonboard.com>", "date": "2019-04-26T15:01:54", "name": "[libcamera-devel,7/8] cam: options: Don't initialise variable-length arrays", "commit_ref": "5d987629d9df6f9eeb76079a99810d57c820219e", "pull_url": null, "state": "accepted", "archived": false, "hash": "230e913242df74d5e3866495d18b72e0e3e2bc37", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1113/mbox/", "series": [ { "id": 271, "url": "https://patchwork.libcamera.org/api/series/271/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=271", "date": "2019-04-26T15:01:47", "name": "Fix clang compilation warnings and errors", "version": 1, "mbox": "https://patchwork.libcamera.org/series/271/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1113/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1113/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA1A960EA8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Apr 2019 17:02:11 +0200 (CEST)", "from pendragon.station (net-37-182-44-227.cust.vodafonedsl.it\n\t[37.182.44.227])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3C8F25F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Apr 2019 17:02:11 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556290931;\n\tbh=CjVvA36ESYJORGQ4okkGYCMtDeng9tzeJjBZXbO7KH4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=gpt5EeTSvYGaJEclCGn9GWwUPIcqXAeQW8pJOfKDLYzmaZfEYm0z3ZLGTuprDdQDK\n\tZKc23nYPPFndwvFEQg+1jkj9zx3xzvQ5C2ofoy2p8EVtSXPU4vtnqac+0iUXbf+b4s\n\tAOA1+ppXBGjk1w/XQpxb5LnorFxQ0tFX6t1lW5KA=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 26 Apr 2019 18:01:54 +0300", "Message-Id": "<20190426150155.18652-8-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190426150155.18652-1-laurent.pinchart@ideasonboard.com>", "References": "<20190426150155.18652-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 7/8] cam: options: Don't initialise\n\tvariable-length arrays", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 26 Apr 2019 15:02:13 -0000" }, "content": "According to clang, variable-length arrays can't be initialised. Don't\ndo so, and explicitly set the last element to 0 instead.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/options.cpp | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/cam/options.cpp b/src/cam/options.cpp\nindex 172d40f76a05..b80d361eaaf4 100644\n--- a/src/cam/options.cpp\n+++ b/src/cam/options.cpp\n@@ -382,8 +382,8 @@ OptionsParser::Options OptionsParser::parse(int argc, char **argv)\n \t * Allocate short and long options arrays large enough to contain all\n \t * options.\n \t */\n-\tchar shortOptions[options_.size() * 3 + 2] = {};\n-\tstruct option longOptions[options_.size() + 1] = {};\n+\tchar shortOptions[options_.size() * 3 + 2];\n+\tstruct option longOptions[options_.size() + 1];\n \tunsigned int ids = 0;\n \tunsigned int idl = 0;\n \n@@ -419,6 +419,9 @@ OptionsParser::Options OptionsParser::parse(int argc, char **argv)\n \t\t}\n \t}\n \n+\tshortOptions[ids] = '\\0';\n+\tmemset(&longOptions[idl], 0, sizeof(longOptions[idl]));\n+\n \topterr = 0;\n \n \twhile (true) {\n", "prefixes": [ "libcamera-devel", "7/8" ] }