Patch Detail
Show a patch.
GET /api/patches/1112/?format=api
{ "id": 1112, "url": "https://patchwork.libcamera.org/api/patches/1112/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1112/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190426150155.18652-7-laurent.pinchart@ideasonboard.com>", "date": "2019-04-26T15:01:53", "name": "[libcamera-devel,6/8] test: v4l2_subdevice: Remove std::move() that prevents copy elision", "commit_ref": "d98ab6f2ae54ed5c97f64479de506bb7ab2e64a5", "pull_url": null, "state": "accepted", "archived": false, "hash": "f1fff14e87179f5a42aff2bca3f49672cb03d6dc", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1112/mbox/", "series": [ { "id": 271, "url": "https://patchwork.libcamera.org/api/series/271/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=271", "date": "2019-04-26T15:01:47", "name": "Fix clang compilation warnings and errors", "version": 1, "mbox": "https://patchwork.libcamera.org/series/271/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1112/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1112/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4CE8060EA2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Apr 2019 17:02:11 +0200 (CEST)", "from pendragon.station (net-37-182-44-227.cust.vodafonedsl.it\n\t[37.182.44.227])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DF1A6337\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Apr 2019 17:02:10 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556290931;\n\tbh=LP1in9EHTtSqNsyxOHnHOkfMJI7ghY04OLOQ0LsqL0I=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=tRlSdH67W2IHExsfo39p8L794RA44GYxgYjeclvkTzm/Zbz+seJdWb+hkrn97Ydwi\n\twcVLDN4xAzAYgh/xp7MXpr+fCKzCiT1ILo80B1knKE/v6q3Nr3vX4T6v+jiiisvSmG\n\tFfE6c09jxiuIhlTCyhZRCd1OEl6bkpzba0tiYn1U=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 26 Apr 2019 18:01:53 +0300", "Message-Id": "<20190426150155.18652-7-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190426150155.18652-1-laurent.pinchart@ideasonboard.com>", "References": "<20190426150155.18652-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 6/8] test: v4l2_subdevice: Remove\n\tstd::move() that prevents copy elision", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 26 Apr 2019 15:02:13 -0000" }, "content": "Moving a temporary value prevents copy elision. Remove it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/v4l2_subdevice/v4l2_subdevice_test.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/test/v4l2_subdevice/v4l2_subdevice_test.cpp b/test/v4l2_subdevice/v4l2_subdevice_test.cpp\nindex dfcf779af95e..72d5f72543d2 100644\n--- a/test/v4l2_subdevice/v4l2_subdevice_test.cpp\n+++ b/test/v4l2_subdevice/v4l2_subdevice_test.cpp\n@@ -39,7 +39,7 @@ int V4L2SubdeviceTest::init()\n \t}\n \n \tDeviceMatch dm(\"vimc\");\n-\tmedia_ = std::move(enumerator_->search(dm));\n+\tmedia_ = enumerator_->search(dm);\n \tif (!media_) {\n \t\tcerr << \"Unable to find \\'vimc\\' media device node\" << endl;\n \t\treturn TestSkip;\n", "prefixes": [ "libcamera-devel", "6/8" ] }