Patch Detail
Show a patch.
GET /api/patches/11107/?format=api
{ "id": 11107, "url": "https://patchwork.libcamera.org/api/patches/11107/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11107/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210202173405.1688089-1-kieran.bingham@ideasonboard.com>", "date": "2021-02-02T17:34:05", "name": "[libcamera-devel] test: buffer-import: Fix false-positive failure", "commit_ref": "7fa1a82811976681fde68a3336b466bf86389f59", "pull_url": null, "state": "accepted", "archived": false, "hash": "7c65bc13c66b7e90dc35ab0dea601909384443b3", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11107/mbox/", "series": [ { "id": 1640, "url": "https://patchwork.libcamera.org/api/series/1640/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1640", "date": "2021-02-02T17:34:05", "name": "[libcamera-devel] test: buffer-import: Fix false-positive failure", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1640/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11107/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11107/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3F1A7BD161\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 2 Feb 2021 17:34:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C2BC26842C;\n\tTue, 2 Feb 2021 18:34:12 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B447060307\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Feb 2021 18:34:10 +0100 (CET)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 52AF151B;\n\tTue, 2 Feb 2021 18:34:09 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"p2q8FUDH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612287249;\n\tbh=oJBwrMmkIiCytvJB3xqVozqG6ISNDfWQVlv23O1aVn4=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=p2q8FUDH4EGnAmcfvhrRj0J/go0HwoQfWxiJ7OzEd8pHqOmBJjT2eV/w98lE0YF+k\n\thiyBGVXCF2zIG6ZmfTOKfCCKWrxSWhZY4AEuVhXdtYnrNoIRkHG6+r9D/OeKdWwjAg\n\tdgrGlqACh9oWVG/t6SseaIUNJtPgHR9Sl7rCF78U=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 2 Feb 2021 17:34:05 +0000", "Message-Id": "<20210202173405.1688089-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] test: buffer-import: Fix false-positive\n\tfailure", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Running the tests failed with the following error on buffer import:\n \"Failed to capture enough frames (got 8 expected at least 8)\"\n\nThis indicates that the test did in fact capture enough frames as\ndesired by the test. Update the comparison on both buffer-import and\ncapture tests accordingly.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n test/camera/buffer_import.cpp | 2 +-\n test/camera/capture.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\nindex 7ff628269c47..61f4eb92ae95 100644\n--- a/test/camera/buffer_import.cpp\n+++ b/test/camera/buffer_import.cpp\n@@ -138,7 +138,7 @@ protected:\n \t\twhile (timer.isRunning())\n \t\t\tdispatcher->processEvents();\n \n-\t\tif (completeRequestsCount_ <= cfg.bufferCount * 2) {\n+\t\tif (completeRequestsCount_ < cfg.bufferCount * 2) {\n \t\t\tstd::cout << \"Failed to capture enough frames (got \"\n \t\t\t\t << completeRequestsCount_ << \" expected at least \"\n \t\t\t\t << cfg.bufferCount * 2 << \")\" << std::endl;\ndiff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\nindex 6d564fe453ac..c4bc21100777 100644\n--- a/test/camera/capture.cpp\n+++ b/test/camera/capture.cpp\n@@ -142,7 +142,7 @@ protected:\n \n \t\tunsigned int nbuffers = allocator_->buffers(stream).size();\n \n-\t\tif (completeRequestsCount_ <= nbuffers * 2) {\n+\t\tif (completeRequestsCount_ < nbuffers * 2) {\n \t\t\tcout << \"Failed to capture enough frames (got \"\n \t\t\t << completeRequestsCount_ << \" expected at least \"\n \t\t\t << nbuffers * 2 << \")\" << endl;\n", "prefixes": [ "libcamera-devel" ] }