Patch Detail
Show a patch.
GET /api/patches/11102/?format=api
{ "id": 11102, "url": "https://patchwork.libcamera.org/api/patches/11102/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11102/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210201125633.26242-2-naush@raspberrypi.com>", "date": "2021-02-01T12:56:33", "name": "[libcamera-devel,2/2] pipeline: raspberrypi: Always save sensor params on IPA_RESULT_SENSOR_PARAMS", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5eb1a63afd9c6d8f8e4f68f4a7c187b8f1c09b08", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11102/mbox/", "series": [ { "id": 1635, "url": "https://patchwork.libcamera.org/api/series/1635/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1635", "date": "2021-02-01T12:56:32", "name": "[libcamera-devel,1/2] pipeline: ipa: raspberrypi: Rename RPi::ConfigParameters enum values", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1635/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11102/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11102/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB958BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 1 Feb 2021 12:56:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A87C968405;\n\tMon, 1 Feb 2021 13:56:49 +0100 (CET)", "from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E225268403\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 1 Feb 2021 13:56:47 +0100 (CET)", "by mail-wm1-x330.google.com with SMTP id j18so12564686wmi.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 01 Feb 2021 04:56:47 -0800 (PST)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tr17sm12655002wro.46.2021.02.01.04.56.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 01 Feb 2021 04:56:46 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Yb6VQnKv\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=owTe+UnimzoeH5UX2dLevt6U/8gQYnQ59u5O4axdyRA=;\n\tb=Yb6VQnKvnUDMRY6DM0addDK9Zx+VwOBqQUTHQKK6QoYlUyWDDK7kTPY+y8FnsX5Eh7\n\tAW+8qeeQGgEKnnOHpXUmi5wpNHS5uoqgi4BbK7XYJdv5VvI09ttRCyJN0Kiw5q7T5+Ba\n\tt5rnMwbgTM+DH48CL7nxrZ5MvyyZNMGq/xiPrRO84X8sjXMS71Anb6HQitRS05vGyJGw\n\tiztZaNBF0ck1ymBXmqVRBhbfJiDz3LEFCW+0hifpZUCI+fDpqZ9poEfLi/SiscXRUxW+\n\txJ5iBfxrOXDAjz2HIqYv6e6sMIkSFk+sJtbHay8fAeICnbgxArfiSNHcIH5r8VO8VDBe\n\tSl0A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=owTe+UnimzoeH5UX2dLevt6U/8gQYnQ59u5O4axdyRA=;\n\tb=FmC/swbD5omg/Vkh46v6JTcI5F5zRXn9+ehqKS0gAJRmVNk+GLKGzzX0JH8ZGjKzYv\n\tixAPYw9Z1dJhDyTbbcevg2MgWLcm1cX3qZubF84IBF85AAQasws+kgFrj5fhH7H0hNJ9\n\tTy7aknERZQ45OCUKCzLLTUZw7h8xDsZRQqo6vGIGxSDbBle1kF++bHffEnnqM4j/s0E7\n\tSm68WWhDI9rYsO2QGcTGXcHNhK1zMO0na6HhkT/MsY6ctUIvv7BrSwHAz17ACEfVqltR\n\tJd4itaSFpmw4ZwFqmMU50ccvODw9zvI9qWcoBCmYnpkG10x5/u2WqkL9q+43mXfv35O4\n\tAqPQ==", "X-Gm-Message-State": "AOAM530qzhKUjh2UGY001mAGpCyQN8znKp8zhHhAhjhZlVij10hI6R1i\n\trhJufIA7yg/u07/cFGpHEUyJ1fMfSAyVnCj5", "X-Google-Smtp-Source": "ABdhPJxbzigqHdCtiwgQytQQUmWCTSylFJxVZK0ySiggGNytUdhKb0+l93PkqttWl1HzNcy/c0xr8Q==", "X-Received": "by 2002:a1c:65d5:: with SMTP id\n\tz204mr9636127wmb.184.1612184207332; \n\tMon, 01 Feb 2021 04:56:47 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 1 Feb 2021 12:56:33 +0000", "Message-Id": "<20210201125633.26242-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210201125633.26242-1-naush@raspberrypi.com>", "References": "<20210201125633.26242-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/2] pipeline: raspberrypi: Always save\n\tsensor params on IPA_RESULT_SENSOR_PARAMS", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Fixup logic when handling IPA_RESULT_SENSOR_PARAMS where we must always\noverwrite the parameters if provided by IPA. In the current codebase,\nthis only happens once on startup, so there is no effective functional\ndifference. But this change allows the option for the IPA to request new\nsensor parameters per-mode if required.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n .../pipeline/raspberrypi/raspberrypi.cpp | 16 +++++++---------\n 1 file changed, 7 insertions(+), 9 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 48e5943edc1a..63bdbe2b91bd 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1224,17 +1224,15 @@ int RPiCameraData::configureIPA(const CameraConfiguration *config)\n \t\t * Setup our delayed control writer with the sensor default\n \t\t * gain and exposure delays.\n \t\t */\n-\t\tif (!delayedCtrls_) {\n-\t\t\tstd::unordered_map<uint32_t, unsigned int> delays = {\n-\t\t\t\t{ V4L2_CID_ANALOGUE_GAIN, result.data[resultIdx++] },\n-\t\t\t\t{ V4L2_CID_EXPOSURE, result.data[resultIdx++] },\n-\t\t\t\t{ V4L2_CID_VBLANK, result.data[resultIdx++] }\n-\t\t\t};\n+\t\tstd::unordered_map<uint32_t, unsigned int> delays = {\n+\t\t\t{ V4L2_CID_ANALOGUE_GAIN, result.data[resultIdx++] },\n+\t\t\t{ V4L2_CID_EXPOSURE, result.data[resultIdx++] },\n+\t\t\t{ V4L2_CID_VBLANK, result.data[resultIdx++] }\n+\t\t};\n \n-\t\t\tdelayedCtrls_ = std::make_unique<DelayedControls>(unicam_[Unicam::Image].dev(), delays);\n+\t\tdelayedCtrls_ = std::make_unique<DelayedControls>(unicam_[Unicam::Image].dev(), delays);\n \n-\t\t\tsensorMetadata_ = result.data[resultIdx++];\n-\t\t}\n+\t\tsensorMetadata_ = result.data[resultIdx++];\n \t}\n \n \tif (result.operation & RPi::IPA_RESULT_SENSOR_CTRLS) {\n", "prefixes": [ "libcamera-devel", "2/2" ] }