Patch Detail
Show a patch.
GET /api/patches/11100/?format=api
{ "id": 11100, "url": "https://patchwork.libcamera.org/api/patches/11100/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11100/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210201085651.21281-1-paul.elder@ideasonboard.com>", "date": "2021-02-01T08:56:51", "name": "[libcamera-devel] android: camera_device: Set default max frame duration", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "5ba68b386c84119a72589a53e447bcaac58d11cc", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11100/mbox/", "series": [ { "id": 1634, "url": "https://patchwork.libcamera.org/api/series/1634/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1634", "date": "2021-02-01T08:56:51", "name": "[libcamera-devel] android: camera_device: Set default max frame duration", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1634/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11100/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11100/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 38B5AC33BB\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 1 Feb 2021 08:57:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7BDD683F7;\n\tMon, 1 Feb 2021 09:57:03 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 849B960307\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 1 Feb 2021 09:57:02 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DA089443;\n\tMon, 1 Feb 2021 09:57:00 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bX1VJwuw\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612169822;\n\tbh=rZVRaCVNDEAimCFV/5Myf7EEPb+ZhWthG0HdKB86K8E=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=bX1VJwuwU3PwFSeIXEofyMvXjSQ/cUULyojEWdDbq8CO+pDjyY15y2cWY2r1YiRIt\n\tbzR8+q/8VVXBWgO4ybDjOBkfQgucBtLvy3xlNOTmKqAl4LiEb82OlNsfPIF8YrF4RX\n\tlFACP8IQKv29w5OlKNqLSP7yYqqCsG2BvdZfHiCA=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 1 Feb 2021 17:56:51 +0900", "Message-Id": "<20210201085651.21281-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] android: camera_device: Set default max\n\tframe duration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Set the max frame duration in the static metadata to 1 second.\n\nThis allows the following CTS test to pass:\n- android.hardware.camera2.cts.SurfaceViewPreviewTest#testPreviewFpsRange\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/android/camera_device.cpp | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex c1025e81..a71af540 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -705,10 +705,10 @@ std::tuple<uint32_t, uint32_t> CameraDevice::calculateStaticMetadataSize()\n {\n \t/*\n \t * \\todo Keep this in sync with the actual number of entries.\n-\t * Currently: 53 entries, 782 bytes of static metadata\n+\t * Currently: 54 entries, 794 bytes of static metadata\n \t */\n-\tuint32_t numEntries = 53;\n-\tuint32_t byteSize = 810;\n+\tuint32_t numEntries = 54;\n+\tuint32_t byteSize = 822;\n \n \t/*\n \t * Calculate space occupation in bytes for dynamically built metadata\n@@ -932,6 +932,10 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\t\t\t\t &exposureTimeRange, 2);\n \t}\n \n+\tint64_t maxFrameDuration = 1000000000;\n+\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_MAX_FRAME_DURATION,\n+\t\t\t\t &maxFrameDuration, 1);\n+\n \tstaticMetadata_->addEntry(ANDROID_SENSOR_ORIENTATION, &orientation_, 1);\n \n \tstd::vector<int32_t> testPatterModes = {\n@@ -1179,6 +1183,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\tANDROID_SENSOR_INFO_SENSITIVITY_RANGE,\n \t\tANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT,\n \t\tANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE,\n+\t\tANDROID_SENSOR_INFO_MAX_FRAME_DURATION,\n \t\tANDROID_SENSOR_ORIENTATION,\n \t\tANDROID_SENSOR_AVAILABLE_TEST_PATTERN_MODES,\n \t\tANDROID_SENSOR_INFO_PHYSICAL_SIZE,\n", "prefixes": [ "libcamera-devel" ] }