Patch Detail
Show a patch.
GET /api/patches/11006/?format=api
{ "id": 11006, "url": "https://patchwork.libcamera.org/api/patches/11006/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11006/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210126130415.26849-2-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-01-26T13:04:14", "name": "[libcamera-devel,v2,1/2] Revert \"libcamera: span: Provide and use helper variable templates for type traits\"", "commit_ref": "33bfe7b7ef68d6221ad340ad117815e30f8fe6aa", "pull_url": null, "state": "accepted", "archived": false, "hash": "01a033a9e0a0931a8f8164ad87029a2d7a983606", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11006/mbox/", "series": [ { "id": 1609, "url": "https://patchwork.libcamera.org/api/series/1609/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1609", "date": "2021-01-26T13:04:13", "name": "libcamera: revert C++17 specific code for public API", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1609/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11006/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11006/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C7AB2C0F2B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 26 Jan 2021 13:04:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 999BE68300;\n\tTue, 26 Jan 2021 14:04:23 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4AD0682F0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Jan 2021 14:04:21 +0100 (CET)", "from localhost.localdomain (unknown\n\t[IPv6:2a01:e0a:169:7140:510d:40f3:f9f9:5153])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 636082E0;\n\tTue, 26 Jan 2021 14:04:21 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"waHFRPIh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611666261;\n\tbh=w5OwvBYRaQUEAgyHtdkv9HAIs9ErRn8dxB+0biub8nE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=waHFRPIhq5TAkZrJ1aVe500oggKchrpRdCPLMJdxBf3W963QsqXqkUP1i01PGCVgk\n\tFmYLmmhdqucGrFfN1s28TtbP5F0659vU7A2s2nBPKLRcOP0AmDDqy/AlCyDzZ/AUze\n\tpsCQ9UY0ZgKtPm1CmKyqpeiIhbmNPA16UoS3rCQI=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 26 Jan 2021 14:04:14 +0100", "Message-Id": "<20210126130415.26849-2-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210126130415.26849-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210126130415.26849-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 1/2] Revert \"libcamera: span: Provide\n\tand use helper variable templates for type traits\"", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This reverts commit 8e42c2feb7ff7c350ffbbf97dd963dfd54e21faa.\n---\n include/libcamera/controls.h | 12 ++++++------\n include/libcamera/span.h | 22 ++++++++--------------\n 2 files changed, 14 insertions(+), 20 deletions(-)", "diff": "diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 3634dc43..dc549a92 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -96,7 +96,7 @@ public:\n \tControlValue();\n \n #ifndef __DOXYGEN__\n-\ttemplate<typename T, typename std::enable_if_t<!details::is_span_v<T> &&\n+\ttemplate<typename T, typename std::enable_if_t<!details::is_span<T>::value &&\n \t\t\t\t\t\t details::control_type<T>::value &&\n \t\t\t\t\t\t !std::is_same_v<std::string, std::remove_cv_t<T>>,\n \t\t\t\t\t\t std::nullptr_t> = nullptr>\n@@ -107,7 +107,7 @@ public:\n \t\t &value, 1, sizeof(T));\n \t}\n \n-\ttemplate<typename T, typename std::enable_if_t<details::is_span_v<T> ||\n+\ttemplate<typename T, typename std::enable_if_t<details::is_span<T>::value ||\n \t\t\t\t\t\t std::is_same_v<std::string, std::remove_cv_t<T>>,\n \t\t\t\t\t\t std::nullptr_t> = nullptr>\n #else\n@@ -141,7 +141,7 @@ public:\n \t}\n \n #ifndef __DOXYGEN__\n-\ttemplate<typename T, typename std::enable_if_t<!details::is_span_v<T> &&\n+\ttemplate<typename T, typename std::enable_if_t<!details::is_span<T>::value &&\n \t\t\t\t\t\t !std::is_same_v<std::string, std::remove_cv_t<T>>,\n \t\t\t\t\t\t std::nullptr_t> = nullptr>\n \tT get() const\n@@ -152,7 +152,7 @@ public:\n \t\treturn *reinterpret_cast<const T *>(data().data());\n \t}\n \n-\ttemplate<typename T, typename std::enable_if_t<details::is_span_v<T> ||\n+\ttemplate<typename T, typename std::enable_if_t<details::is_span<T>::value ||\n \t\t\t\t\t\t std::is_same_v<std::string, std::remove_cv_t<T>>,\n \t\t\t\t\t\t std::nullptr_t> = nullptr>\n #else\n@@ -169,7 +169,7 @@ public:\n \t}\n \n #ifndef __DOXYGEN__\n-\ttemplate<typename T, typename std::enable_if_t<!details::is_span_v<T> &&\n+\ttemplate<typename T, typename std::enable_if_t<!details::is_span<T>::value &&\n \t\t\t\t\t\t !std::is_same_v<std::string, std::remove_cv_t<T>>,\n \t\t\t\t\t\t std::nullptr_t> = nullptr>\n \tvoid set(const T &value)\n@@ -178,7 +178,7 @@ public:\n \t\t reinterpret_cast<const void *>(&value), 1, sizeof(T));\n \t}\n \n-\ttemplate<typename T, typename std::enable_if_t<details::is_span_v<T> ||\n+\ttemplate<typename T, typename std::enable_if_t<details::is_span<T>::value ||\n \t\t\t\t\t\t std::is_same_v<std::string, std::remove_cv_t<T>>,\n \t\t\t\t\t\t std::nullptr_t> = nullptr>\n #else\ndiff --git a/include/libcamera/span.h b/include/libcamera/span.h\nindex e7ffef12..d720adb8 100644\n--- a/include/libcamera/span.h\n+++ b/include/libcamera/span.h\n@@ -31,9 +31,6 @@ template<typename U, std::size_t N>\n struct is_array<std::array<U, N>> : public std::true_type {\n };\n \n-template<typename T>\n-inline constexpr bool is_array_v = is_array<T>::value;\n-\n template<typename U>\n struct is_span : public std::false_type {\n };\n@@ -42,9 +39,6 @@ template<typename U, std::size_t Extent>\n struct is_span<Span<U, Extent>> : public std::true_type {\n };\n \n-template<typename T>\n-inline constexpr bool is_span_v = is_span<T>::value;\n-\n } /* namespace details */\n \n namespace utils {\n@@ -161,8 +155,8 @@ public:\n \n \ttemplate<class Container>\n \texplicit constexpr Span(Container &cont,\n-\t\t\t\tstd::enable_if_t<!details::is_span_v<Container> &&\n-\t\t\t\t\t\t !details::is_array_v<Container> &&\n+\t\t\t\tstd::enable_if_t<!details::is_span<Container>::value &&\n+\t\t\t\t\t\t !details::is_array<Container>::value &&\n \t\t\t\t\t\t !std::is_array_v<Container> &&\n \t\t\t\t\t\t std::is_convertible_v<std::remove_pointer_t<decltype(utils::data(cont))> (*)[],\n \t\t\t\t\t\t\t\t element_type (*)[]>,\n@@ -173,8 +167,8 @@ public:\n \n \ttemplate<class Container>\n \texplicit constexpr Span(const Container &cont,\n-\t\t\t\tstd::enable_if_t<!details::is_span_v<Container> &&\n-\t\t\t\t\t\t !details::is_array_v<Container> &&\n+\t\t\t\tstd::enable_if_t<!details::is_span<Container>::value &&\n+\t\t\t\t\t\t !details::is_array<Container>::value &&\n \t\t\t\t\t\t !std::is_array_v<Container> &&\n \t\t\t\t\t\t std::is_convertible_v<std::remove_pointer_t<decltype(utils::data(cont))> (*)[],\n \t\t\t\t\t\t\t\t element_type (*)[]>,\n@@ -323,8 +317,8 @@ public:\n \n \ttemplate<class Container>\n \tconstexpr Span(Container &cont,\n-\t\t std::enable_if_t<!details::is_span_v<Container> &&\n-\t\t\t\t\t!details::is_array_v<Container> &&\n+\t\t std::enable_if_t<!details::is_span<Container>::value &&\n+\t\t\t\t\t!details::is_array<Container>::value &&\n \t\t\t\t\t!std::is_array_v<Container> &&\n \t\t\t\t\tstd::is_convertible_v<std::remove_pointer_t<decltype(utils::data(cont))> (*)[],\n \t\t\t\t\t\t\t element_type (*)[]>,\n@@ -335,8 +329,8 @@ public:\n \n \ttemplate<class Container>\n \tconstexpr Span(const Container &cont,\n-\t\t std::enable_if_t<!details::is_span_v<Container> &&\n-\t\t\t\t\t!details::is_array_v<Container> &&\n+\t\t std::enable_if_t<!details::is_span<Container>::value &&\n+\t\t\t\t\t!details::is_array<Container>::value &&\n \t\t\t\t\t!std::is_array_v<Container> &&\n \t\t\t\t\tstd::is_convertible_v<std::remove_pointer_t<decltype(utils::data(cont))> (*)[],\n \t\t\t\t\t\t\t element_type (*)[]>,\n", "prefixes": [ "libcamera-devel", "v2", "1/2" ] }