Patch Detail
Show a patch.
GET /api/patches/10980/?format=api
{ "id": 10980, "url": "https://patchwork.libcamera.org/api/patches/10980/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10980/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210125071444.26252-3-paul.elder@ideasonboard.com>", "date": "2021-01-25T07:14:38", "name": "[libcamera-devel,v4,2/8] android: jpeg: exif: Fix setOrientation EXIF values", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bb3fb3a0058e217e305272f78b57dec2c67fb55b", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10980/mbox/", "series": [ { "id": 1603, "url": "https://patchwork.libcamera.org/api/series/1603/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1603", "date": "2021-01-25T07:14:36", "name": "Fill in android result metadata and EXIF tags", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1603/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10980/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10980/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2B667C0F2B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 25 Jan 2021 07:15:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F2286682B0;\n\tMon, 25 Jan 2021 08:15:00 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 49A67682A0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 25 Jan 2021 08:15:00 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 504114FB;\n\tMon, 25 Jan 2021 08:14:58 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WrdL5E0m\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611558900;\n\tbh=IqNjk7Eq2zng9qAGz+NbI6WM99bZ12sQo3iNJ4VJRxw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WrdL5E0m9+fcFALoRM8HREPa0SAsuCFnPSFPyv8Po2veJ+lbf3NumyitKnOJJUJfn\n\tqmlr9mApfX5hbgAaeCk0KSsiOKtpZ2/I94Gr4jS5Jwx9JyVPmqx5wK1O+zC7d7I+0U\n\tMjo49n3y5ozpsqg7UWUYuVdsg6pe0Y8htDw8giZA=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 25 Jan 2021 16:14:38 +0900", "Message-Id": "<20210125071444.26252-3-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210125071444.26252-1-paul.elder@ideasonboard.com>", "References": "<20210125071444.26252-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 2/8] android: jpeg: exif: Fix\n\tsetOrientation EXIF values", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The input to setOrientation is angle clockwise from the sensor\norientation, while the EXIF output values were swapped for 90\nand 270 degrees.\n\nFrom the EXIF spec:\n\n6 = The 0th row is the visual right-hand side of the image, and the\n 0th column is the visual top.\n8 = The 0th row is the visual left-hand side of the image, and the\n 0th column is the visual bottom.\n\n6 should be 90 degrees clockwise, while 8 should 270 degrees clockwise.\nFix this.\n\nAs Android defines the rotation as the clockwise angle by which the\nimage needs to be rotated to appear in the correct orientation on the\ndevice screen, the previous values would be correct if the input angle\nwas from the camera orientation. Since the correct input should be the\nrequested JPEG orientation, these new values are the correct ones.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nNo change in v3\n\nChanges in v2\n- expand commit message\n---\n src/android/jpeg/exif.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp\nindex 89343323..204a237a 100644\n--- a/src/android/jpeg/exif.cpp\n+++ b/src/android/jpeg/exif.cpp\n@@ -306,13 +306,13 @@ void Exif::setOrientation(int orientation)\n \t\tvalue = 1;\n \t\tbreak;\n \tcase 90:\n-\t\tvalue = 8;\n+\t\tvalue = 6;\n \t\tbreak;\n \tcase 180:\n \t\tvalue = 3;\n \t\tbreak;\n \tcase 270:\n-\t\tvalue = 6;\n+\t\tvalue = 8;\n \t\tbreak;\n \t}\n \n", "prefixes": [ "libcamera-devel", "v4", "2/8" ] }