Patch Detail
Show a patch.
GET /api/patches/10974/?format=api
{ "id": 10974, "url": "https://patchwork.libcamera.org/api/patches/10974/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10974/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210124140506.786503-1-naush@raspberrypi.com>", "date": "2021-01-24T14:05:03", "name": "[libcamera-devel,v2,1/4] raspberrypi: Add the correct integer const postfix for FrameDurations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "be4e47bf358b986cf10408f3a270479bc96b649e", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10974/mbox/", "series": [ { "id": 1602, "url": "https://patchwork.libcamera.org/api/series/1602/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1602", "date": "2021-01-24T14:05:03", "name": "[libcamera-devel,v2,1/4] raspberrypi: Add the correct integer const postfix for FrameDurations", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1602/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10974/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10974/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01154BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 24 Jan 2021 14:05:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 438F56829F;\n\tSun, 24 Jan 2021 15:05:14 +0100 (CET)", "from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 78CDE6823D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 24 Jan 2021 15:05:12 +0100 (CET)", "by mail-wm1-x32f.google.com with SMTP id o10so9104342wmc.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 24 Jan 2021 06:05:12 -0800 (PST)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tu16sm19311053wrn.68.2021.01.24.06.05.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 24 Jan 2021 06:05:10 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"OTNPaGlK\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=n9D4J5SwNdhQcSxAfeArxWLUh8dmYZ/TT2l15nlspHA=;\n\tb=OTNPaGlK+pIpm4EP0UgWDz9O3jS84ojE5JIF65XWmC+945nsF+m6FZWlFktsvD6OWn\n\t7ZyK3+4t2F+IWu64ajaUhtB4bAczbzrgYIiRHVTrntaPHFLOYlQhjYxvazef6nBXdRim\n\teCFmTRHEQbvG0CWyykqkjsJ+v1QJQW23Za50qR3tjgU5JxnhyezeQFsaXzAiM++K2PPl\n\t+aDqrl6jDTbBF6ciW7VlrKL17VzPHVufIP9AbePxvbs/TmBJwsfx7n853zoixsrZAHL/\n\tQ+GMGD4MJnE9eLn3ACf7rt4eOsrUloEnon6ks+3H7wMCuGeIWX+JXBjwTYeASod/hSSA\n\tkOeA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=n9D4J5SwNdhQcSxAfeArxWLUh8dmYZ/TT2l15nlspHA=;\n\tb=VhtWZfqkzVO2KZXyNC/BXig29C806QmURevjW3/pu9DJjvwd8ucXMYimhaGqKUgL0q\n\trDxg4ZEvu9OGz/lyIs9ZrrvMNqBgAM6zOqaNF0orrMtx0vh/n4MGW2v9r+5BDe1AIBXy\n\tVeddGIrgsFtHbfWa4H5P/vIvvOM1zMXLwPcHcxhdwO7JBOFoffwdUnss1YCpY3BS9ydl\n\tEGAHYQnZSS9TxFBr7w5TViPmUT4qlLWiuwiletji0VZiXJHzEpw/ZpyQqF1a34Uerpy8\n\tsZB04+ZkwtGyqxaK6n3Y240C44twJQcUkOIJ9MpWebUdeVUjdOtMOQ76O3RsrylvU8LU\n\tE9EA==", "X-Gm-Message-State": "AOAM530wpV7BYSkb/oF+mc0s7k4zvpRHSC7VGxvU145E41N7RbA3ziak\n\tk1lbCTI/RK1DWXl47zf1J8HUjb/oYGTzqapy", "X-Google-Smtp-Source": "ABdhPJzKIzwahf2sq/uEpxbJ0EFq3qxDVuyOO4n5/uvV57q6xV0DwYBeLNd824bf886bLSGMsNU9Nw==", "X-Received": "by 2002:a1c:4057:: with SMTP id\n\tn84mr11915835wma.141.1611497111625; \n\tSun, 24 Jan 2021 06:05:11 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 24 Jan 2021 14:05:03 +0000", "Message-Id": "<20210124140506.786503-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 1/4] raspberrypi: Add the correct\n\tinteger const postfix for FrameDurations", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Kieran Bingham <kieran.bingham@ideaasonboard.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "At startup, ControlInfoMap::generateIdmap() threw a log message warning\nthat the controls::FrameDurations had a type mismatch based on the\nmin/max values provided in libcamera::RPi::Controls initialiser.\n\nFix this warning by adding and explicit int64_t postfix to the const\nvalues for min and max.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideaasonboard.com>\n---\n include/libcamera/ipa/raspberrypi.h | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\nindex 1de36039cee0..4038428bdba4 100644\n--- a/include/libcamera/ipa/raspberrypi.h\n+++ b/include/libcamera/ipa/raspberrypi.h\n@@ -7,6 +7,8 @@\n #ifndef __LIBCAMERA_IPA_INTERFACE_RASPBERRYPI_H__\n #define __LIBCAMERA_IPA_INTERFACE_RASPBERRYPI_H__\n \n+#include <stdint.h>\n+\n #include <libcamera/control_ids.h>\n #include <libcamera/controls.h>\n \n@@ -65,7 +67,7 @@ static const ControlInfoMap Controls = {\n \t{ &controls::Sharpness, ControlInfo(0.0f, 16.0f, 1.0f) },\n \t{ &controls::ColourCorrectionMatrix, ControlInfo(-16.0f, 16.0f) },\n \t{ &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) },\n-\t{ &controls::FrameDurations, ControlInfo(1000, 1000000000) },\n+\t{ &controls::FrameDurations, ControlInfo(INT64_C(1000), INT64_C(1000000000)) },\n };\n \n } /* namespace RPi */\n", "prefixes": [ "libcamera-devel", "v2", "1/4" ] }