Patch Detail
Show a patch.
GET /api/patches/10960/?format=api
{ "id": 10960, "url": "https://patchwork.libcamera.org/api/patches/10960/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10960/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210122131451.726584-3-naush@raspberrypi.com>", "date": "2021-01-22T13:14:48", "name": "[libcamera-devel,v3,3/6] uapi: raspberrypi: Update the bcm2835-isp header definition", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b4ce3c3aa49bfa21660f80552fef0643510192b9", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10960/mbox/", "series": [ { "id": 1599, "url": "https://patchwork.libcamera.org/api/series/1599/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1599", "date": "2021-01-22T13:14:46", "name": "[libcamera-devel,v3,1/6] pipeline: raspberrypi: Refactor stream configuration routine", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1599/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10960/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10960/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D078BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 22 Jan 2021 13:15:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E64566827A;\n\tFri, 22 Jan 2021 14:14:59 +0100 (CET)", "from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com\n\t[IPv6:2a00:1450:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF2CD6827E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Jan 2021 14:14:57 +0100 (CET)", "by mail-wr1-x42a.google.com with SMTP id 6so5054486wri.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Jan 2021 05:14:57 -0800 (PST)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\ti8sm7228870wry.90.2021.01.22.05.14.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 22 Jan 2021 05:14:56 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"F8YKlKj/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=bjrxqpQgzDBa9WkS2S3Mn4TK2H7Bqit1lomfmatnMZc=;\n\tb=F8YKlKj/u+wU+HmX9udoUG8DQJ1HTe6ukLmaKOVjepc+ZKD+MJcuCIgwiYzj/aAABy\n\tWpi2UXR5FAjmaEMxh/2W34gwD691cbN7qUmSwQ5361JZ0Fg9XmprSzbFi7cJDg6IfJ8z\n\t6YAAK7rRyBhQKWP9PguWqPDVr5a+Ap8R9lYAOQJZB74QFOuOkxNEyaVT5ZJhU4Tq2xlj\n\tKnHpOu9VOv8h+8kcB4FWpErgetBt89/og8YyzzQuZiI7lcOC/uDTVE/7WahRKRYsRmWH\n\tcV4eSw5tl10P32j0zxfgXiI5adizCiRzhGP8nTX+6R7taFvVPmwzKaRcTJUO09Lpc3tU\n\tcQ6A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=bjrxqpQgzDBa9WkS2S3Mn4TK2H7Bqit1lomfmatnMZc=;\n\tb=gvDghyQhhSNlInM1LEaLQoDrcAadoFK2Em7ORZnzG348WXSRje7d7He8ZuHwxooGyx\n\tz2nvqx4ImlG1veqAQj/wyUiLjvOgsBlb30NzJJyKMPx3Dv/vYPLm9Lk+/Q/DGrHaKJ9S\n\tEhlMD1+XyuOKi7cB7YYJ0rj5geEihkrDWzTFT+AgkyB+jcfd6QvsYSgrpyOT0w2+cQqa\n\tJZsx++Qw/iNycJmCFV6sai6xS4/Y+5ZGa+Z8cM/94Mt3OKZKv3pvaqtvn2i1hrNNXkTn\n\tltYbAbjdyBrz8Q32Xet3Q+aiYlfrj7Vrkvtah3k8zEz+5ozrvgjqPm7Lg/l2imkIDWhw\n\t2MWA==", "X-Gm-Message-State": "AOAM532KP4vHpyInm2O+aTypLzBvu0hFELWFn4pZeDowxflGsrIjNytW\n\tI0BtN8mqUJ21POmJOteKK0tRxHJYgDvA3g==", "X-Google-Smtp-Source": "ABdhPJyQPFr3qPbXncCC8KBVSinSlrZ+mMRSn3ggklXjQ2dIwtM3CBqQZ5c34kqGF7AX6fXFOZX80g==", "X-Received": "by 2002:a5d:5549:: with SMTP id g9mr4792020wrw.244.1611321297397;\n\tFri, 22 Jan 2021 05:14:57 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 22 Jan 2021 13:14:48 +0000", "Message-Id": "<20210122131451.726584-3-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210122131451.726584-1-naush@raspberrypi.com>", "References": "<20210122131451.726584-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 3/6] uapi: raspberrypi: Update the\n\tbcm2835-isp header definition", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Update the bcm2835-isp.h file with the latest version available in the\ndownstream Raspberry Pi linux repo.\n\nThis change adds support for colour denoise processing, and the\nfollowing downstream kernel changes must be available:\nhttps://github.com/raspberrypi/linux/pull/4069\nhttps://github.com/raspberrypi/linux/pull/4083\n\nThe Raspberry Pi image must also be running the latest firmware,\nobtained by running rpi-update.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/linux/bcm2835-isp.h | 32 +++++++++++++++++++++++++++++---\n 1 file changed, 29 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/linux/bcm2835-isp.h b/include/linux/bcm2835-isp.h\nindex 45abb681517e..94c3af947883 100644\n--- a/include/linux/bcm2835-isp.h\n+++ b/include/linux/bcm2835-isp.h\n@@ -31,7 +31,8 @@\n \t\t\t\t(V4L2_CID_USER_BCM2835_ISP_BASE + 0x0007)\n #define V4L2_CID_USER_BCM2835_ISP_DPC\t\t\\\n \t\t\t\t(V4L2_CID_USER_BCM2835_ISP_BASE + 0x0008)\n-\n+#define V4L2_CID_USER_BCM2835_ISP_CDN \\\n+\t\t\t\t(V4L2_CID_USER_BCM2835_ISP_BASE + 0x0009)\n /*\n * All structs below are directly mapped onto the equivalent structs in\n * drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h\n@@ -46,7 +47,7 @@\n */\n struct bcm2835_isp_rational {\n \t__s32 num;\n-\t__s32 den;\n+\t__u32 den;\n };\n \n /**\n@@ -140,7 +141,7 @@ struct bcm2835_isp_black_level {\n \t__u16 black_level_r;\n \t__u16 black_level_g;\n \t__u16 black_level_b;\n-\t__u8 pad_[2]; /* Unused */\n+\t__u8 padding[2]; /* Unused */\n };\n \n /**\n@@ -175,6 +176,31 @@ struct bcm2835_isp_gamma {\n \t__u16 y[BCM2835_NUM_GAMMA_PTS];\n };\n \n+/**\n+ * enum bcm2835_isp_cdn_mode - Mode of operation for colour denoise.\n+ *\n+ * @CDN_MODE_FAST:\t\tFast (but lower quality) colour denoise\n+ *\t\t\t\talgorithm, typically used for video recording.\n+ * @CDN_HIGH_QUALITY:\t\tHigh quality (but slower) colour denoise\n+ *\t\t\t\talgorithm, typically used for stills capture.\n+ */\n+enum bcm2835_isp_cdn_mode {\n+\tCDN_MODE_FAST = 0,\n+\tCDN_MODE_HIGH_QUALITY = 1,\n+};\n+\n+/**\n+ * struct bcm2835_isp_cdn - Colour denoise parameters set with the\n+ *\t\t\t V4L2_CID_USER_BCM2835_ISP_CDN ctrl.\n+ *\n+ * @enabled:\tEnable colour denoise.\n+ * @cdn_mode:\tColour denoise operating mode (see enum &bcm2835_isp_cdn_mode)\n+ */\n+struct bcm2835_isp_cdn {\n+\t__u32 enabled;\n+\t__u32 mode;\n+};\n+\n /**\n * struct bcm2835_isp_denoise - Denoise parameters set with the\n *\t\t\t\tV4L2_CID_USER_BCM2835_ISP_DENOISE ctrl.\n", "prefixes": [ "libcamera-devel", "v3", "3/6" ] }