Patch Detail
Show a patch.
GET /api/patches/10923/?format=api
{ "id": 10923, "url": "https://patchwork.libcamera.org/api/patches/10923/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10923/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210121115849.682130-2-naush@raspberrypi.com>", "date": "2021-01-21T11:58:46", "name": "[libcamera-devel,1/4] raspberrypi: Add the correct integer const postfix for FrameDurations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7ef6c86b934779fa9f606a7fa3d79c45e78ac91e", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10923/mbox/", "series": [ { "id": 1591, "url": "https://patchwork.libcamera.org/api/series/1591/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1591", "date": "2021-01-21T11:58:45", "name": "Raspberrypi: FrameDurations control refinements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1591/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10923/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10923/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 710D2C0F2A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 Jan 2021 11:58:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3CFFE681EE;\n\tThu, 21 Jan 2021 12:58:57 +0100 (CET)", "from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n\t[IPv6:2a00:1450:4864:20::32d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 15BFE681C8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Jan 2021 12:58:55 +0100 (CET)", "by mail-wm1-x32d.google.com with SMTP id j18so1213131wmi.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Jan 2021 03:58:55 -0800 (PST)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\th13sm8044930wrm.28.2021.01.21.03.58.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 21 Jan 2021 03:58:53 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"dNRTyvnk\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=RlcCs85RsvREHCFk25gd9h0IFdCVRIaWFJ7wNCTORis=;\n\tb=dNRTyvnkewf0xKlhHFGRWRF5nP24Tj31GLFtltRv4HnYZbUXqbERgC6Xx+G6JiOoQu\n\tNwvk+C+PUx1LdCWcC9dQBq9HoOWlrGxiDcg1pVyugTCC9zpOD4E6NDitVZS7SEsRZxeS\n\tNMhoYYDiwuce0Ap7knedpA9H3EGuN/MlDxbK3MNz1NTGFgDz06rWpqE7rbFNdgOTSesv\n\tJZt90ZVwCEp6nr5BuA2UootFWhLi9rlxNwNovc+ik2ll5WtE8zOq0lfIsptqnjkbhS5i\n\tyD2FzvNSXv5YbliIXNdhdvACfEnrkYMgTDhFIjXHZzc4Tm/yxxhOG4NGg6VUPQG+CSen\n\tsREA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=RlcCs85RsvREHCFk25gd9h0IFdCVRIaWFJ7wNCTORis=;\n\tb=emSLpz/fX+r65O6+xXAjAEAbT/Ro/vONSSO+ndhgHv92carpuzrHDBhYNkKkT2rdok\n\tgrGw4JIDeYPfL4o1+OI0TMUsJDVCX16P8AJQvz/PD8sDiA0FKxmxKfiDd7xeiLEg9kor\n\tNP6YU2x4l/Fr01m+5I1mAku1zo/6tHQkikPivyo5fgt+yXk08IE/u+V9AKe2EEnueyu7\n\tuFrhlUs7pIyPjYq6kgsJec6qj4Shm6IwS74HcnWvLnnk/0DU/tMnpNRSK5cEWtT+t/R2\n\tkl4Cdamk3FIRfKrbFO3cHZfxDUtNcRgZOqQyhAFOgWNE/STpsefaehTjTwEynm1E9QhI\n\tnghw==", "X-Gm-Message-State": "AOAM532JfgIMJ/x32fpJ/6b8Zgl1ImYJdX4569OHdERhM1M+QyO8cxtF\n\tovjcCf6XxNywZ4UdDTTFAzK1vK8+LLWp+g==", "X-Google-Smtp-Source": "ABdhPJxmM6NlXRB8fTThFLyqLrZ/ENLHAQdsvh0qbShrpx2bp+REwMVMiKwpZ4W6G8rCJmR87fl0cw==", "X-Received": "by 2002:a05:600c:2a47:: with SMTP id\n\tx7mr8529219wme.145.1611230334617; \n\tThu, 21 Jan 2021 03:58:54 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 21 Jan 2021 11:58:46 +0000", "Message-Id": "<20210121115849.682130-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210121115849.682130-1-naush@raspberrypi.com>", "References": "<20210121115849.682130-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/4] raspberrypi: Add the correct integer\n\tconst postfix for FrameDurations", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "At startup, ControlInfoMap::generateIdmap() threw a log message warning\nthat the controls::FrameDurations had a type mismatch based on the\nmin/max values provided in libcamera::RPi::Controls initialiser.\n\nFix this warning by adding and explicit int64_t postfix to the const\nvalues for min and max.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n include/libcamera/ipa/raspberrypi.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\nindex 1de36039cee0..8e704d922ce6 100644\n--- a/include/libcamera/ipa/raspberrypi.h\n+++ b/include/libcamera/ipa/raspberrypi.h\n@@ -65,7 +65,7 @@ static const ControlInfoMap Controls = {\n \t{ &controls::Sharpness, ControlInfo(0.0f, 16.0f, 1.0f) },\n \t{ &controls::ColourCorrectionMatrix, ControlInfo(-16.0f, 16.0f) },\n \t{ &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) },\n-\t{ &controls::FrameDurations, ControlInfo(1000, 1000000000) },\n+\t{ &controls::FrameDurations, ControlInfo(INT64_C(1000), INT64_C(1000000000)) },\n };\n \n } /* namespace RPi */\n", "prefixes": [ "libcamera-devel", "1/4" ] }