Patch Detail
Show a patch.
GET /api/patches/10919/?format=api
{ "id": 10919, "url": "https://patchwork.libcamera.org/api/patches/10919/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10919/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210121101549.134574-8-paul.elder@ideasonboard.com>", "date": "2021-01-21T10:15:47", "name": "[libcamera-devel,v2,7/9] android: camera_device: Use CameraMetadata wrapper in processControls", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "11b57454c924370faad636e868d41d0c9d25124c", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10919/mbox/", "series": [ { "id": 1590, "url": "https://patchwork.libcamera.org/api/series/1590/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1590", "date": "2021-01-21T10:15:40", "name": "Fill in android result metadata and EXIF tags", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1590/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10919/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10919/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ABD66C0F2A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 Jan 2021 10:16:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 77AC6681EB;\n\tThu, 21 Jan 2021 11:16:17 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 704A3681C3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Jan 2021 11:16:15 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 01F4A50E;\n\tThu, 21 Jan 2021 11:16:13 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"g5ABu5q/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611224175;\n\tbh=zjFaEcw7z5dM5BSS+bjbQTTQ3ZLxS/0UdvDtOuf2rUo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=g5ABu5q/59wy/N95w88VuT69ZPsIQUptNuhHiclr/NodCKJebG8ot+83lS716BIYP\n\to+auJ+2auK8EhHHPTwN0VrBxO9uqxhVSojf1kPHaJ5QHfdtawGO0gxQ2cI4d/Y6p3i\n\tNfrM0LTrKLWdMNw8Em7TIhOgeQCS7ZXqHnpBOWHU=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 21 Jan 2021 19:15:47 +0900", "Message-Id": "<20210121101549.134574-8-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210121101549.134574-1-paul.elder@ideasonboard.com>", "References": "<20210121101549.134574-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 7/9] android: camera_device: Use\n\tCameraMetadata wrapper in processControls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use the CameraMetadata wrapper to access android request settings\ninstead of accessing camera_metadata_t directly.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nNew in v2\n---\n src/android/camera_device.cpp | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 16d5b472..49af221b 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1639,12 +1639,10 @@ int CameraDevice::processControls(camera3_capture_request_t *camera3Request,\n \t * \\todo As soon as more controls are handled, this part should be\n \t * broke out to a dedicated function.\n \t */\n-\tconst camera_metadata_t *camera3Settings = camera3Request->settings;\n+\tCameraMetadata camera3Settings(camera3Request->settings);\n \tcamera_metadata_ro_entry_t entry;\n-\tint ret = find_camera_metadata_ro_entry(camera3Settings,\n-\t\t\t\t\t\tANDROID_SCALER_CROP_REGION,\n-\t\t\t\t\t\t&entry);\n-\tif (!ret) {\n+\tint ret = camera3Settings.getEntry(ANDROID_SCALER_CROP_REGION, &entry);\n+\tif (ret) {\n \t\tconst int32_t *data = entry.data.i32;\n \t\tRectangle cropRegion = { data[0], data[1],\n \t\t\t\t\t static_cast<unsigned int>(data[2]),\n", "prefixes": [ "libcamera-devel", "v2", "7/9" ] }