Patch Detail
Show a patch.
GET /api/patches/10886/?format=api
{ "id": 10886, "url": "https://patchwork.libcamera.org/api/patches/10886/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10886/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210119123110.2976971-2-niklas.soderlund@ragnatech.se>", "date": "2021-01-19T12:31:09", "name": "[libcamera-devel,1/2] cam: event_loop: Stop queuing calls when the event loop are exiting", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1435c98424e702dade49fb75e33d68ab0bd94ed2", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": { "id": 16, "url": "https://patchwork.libcamera.org/api/users/16/?format=api", "username": "neg", "first_name": "Niklas", "last_name": "Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "mbox": "https://patchwork.libcamera.org/patch/10886/mbox/", "series": [ { "id": 1583, "url": "https://patchwork.libcamera.org/api/series/1583/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1583", "date": "2021-01-19T12:31:08", "name": "cam: Fix races in event loop and long request processing times", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1583/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10886/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10886/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 36ADCC0F1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Jan 2021 12:31:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E075B68148;\n\tTue, 19 Jan 2021 13:31:18 +0100 (CET)", "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E4CC86813F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Jan 2021 13:31:16 +0100 (CET)", "from bismarck.berto.se (p4fca2458.dip0.t-ipconnect.de\n\t[79.202.36.88])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 390fd88b-5a52-11eb-a542-005056917a89;\n\tTue, 19 Jan 2021 13:31:16 +0100 (CET)" ], "X-Halon-ID": "390fd88b-5a52-11eb-a542-005056917a89", "Authorized-sender": "niklas.soderlund@fsdn.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 19 Jan 2021 13:31:09 +0100", "Message-Id": "<20210119123110.2976971-2-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20210119123110.2976971-1-niklas.soderlund@ragnatech.se>", "References": "<20210119123110.2976971-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/2] cam: event_loop: Stop queuing calls\n\twhen the event loop are exiting", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Terminating the event loop with EventLoop::exit() does not grantee that\nit will terminate. If the event loops 'call later' queue can be kept\nnon-empty by continuously queuing new calls using EventLoop::callLater()\neither from a different thread or from callbacks in the loop itself\nEventLoop::dispatchCalls() will never complete and the loop will run\nforever.\n\nSolve this by not accepting new callbacks once the event loop is\nexiting.\n\nReported-by: Sebastian Fricke <sebastian.fricke@posteo.net>\nFixes: f49e93338b6309a6 (\"cam: event_loop: Add deferred calls support\")\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/cam/event_loop.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/cam/event_loop.cpp b/src/cam/event_loop.cpp\nindex 94c5d1d362455f33..34a55da30c537ac7 100644\n--- a/src/cam/event_loop.cpp\n+++ b/src/cam/event_loop.cpp\n@@ -62,7 +62,7 @@ void EventLoop::interrupt()\n \n void EventLoop::callLater(const std::function<void()> &func)\n {\n-\t{\n+\tif (!exit_.load(std::memory_order_acquire)) {\n \t\tstd::unique_lock<std::mutex> locker(lock_);\n \t\tcalls_.push_back(func);\n \t}\n", "prefixes": [ "libcamera-devel", "1/2" ] }