Patch Detail
Show a patch.
GET /api/patches/10871/?format=api
{ "id": 10871, "url": "https://patchwork.libcamera.org/api/patches/10871/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10871/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210115170033.27124-9-jacopo@jmondi.org>", "date": "2021-01-15T17:00:31", "name": "[libcamera-devel,v7,08/10] libcamera: media_object: Add a const version of dev()", "commit_ref": "a1a20998aca365a5835d534c49fc3cd4de7246ec", "pull_url": null, "state": "accepted", "archived": false, "hash": "c494e6f6d278be035b3b241d626cf0c771622607", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10871/mbox/", "series": [ { "id": 1578, "url": "https://patchwork.libcamera.org/api/series/1578/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1578", "date": "2021-01-15T17:00:23", "name": "libcamera: camera_sensor: Make validation more strict", "version": 7, "mbox": "https://patchwork.libcamera.org/series/1578/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10871/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10871/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80AE7C3384\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Jan 2021 17:00:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 764EF6811A;\n\tFri, 15 Jan 2021 18:00:25 +0100 (CET)", "from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF1BE680FD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jan 2021 18:00:20 +0100 (CET)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id BF9F1240015\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jan 2021 17:00:20 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 15 Jan 2021 18:00:31 +0100", "Message-Id": "<20210115170033.27124-9-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20210115170033.27124-1-jacopo@jmondi.org>", "References": "<20210115170033.27124-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v7 08/10] libcamera: media_object: Add a\n\tconst version of dev()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a const version of the MediaObject::dev() method to be able to\nretrieve a pointer to a const MediaDevice from a constant instance of\na MediaObject sub-class.\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/internal/media_object.h | 1 +\n src/libcamera/media_object.cpp | 5 +++++\n 2 files changed, 6 insertions(+)", "diff": "diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h\nindex 43a35bef8f35..2b336961f98d 100644\n--- a/include/libcamera/internal/media_object.h\n+++ b/include/libcamera/internal/media_object.h\n@@ -22,6 +22,7 @@ class MediaObject\n {\n public:\n \tMediaDevice *device() { return dev_; }\n+\tconst MediaDevice *device() const { return dev_; }\n \tunsigned int id() const { return id_; }\n \n protected:\ndiff --git a/src/libcamera/media_object.cpp b/src/libcamera/media_object.cpp\nindex 056036635902..94aeb50402ca 100644\n--- a/src/libcamera/media_object.cpp\n+++ b/src/libcamera/media_object.cpp\n@@ -67,6 +67,11 @@ LOG_DECLARE_CATEGORY(MediaDevice)\n \n /**\n * \\fn MediaObject::device()\n+ * \\copydoc MediaObject::device() const\n+ */\n+\n+/**\n+ * \\fn MediaObject::device() const\n * \\brief Retrieve the media device the media object belongs to\n * \\return The MediaDevice\n */\n", "prefixes": [ "libcamera-devel", "v7", "08/10" ] }