Patch Detail
Show a patch.
GET /api/patches/10869/?format=api
{ "id": 10869, "url": "https://patchwork.libcamera.org/api/patches/10869/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10869/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210115170033.27124-7-jacopo@jmondi.org>", "date": "2021-01-15T17:00:29", "name": "[libcamera-devel,v7,06/10] libcamera: camera_sensor: Do not default 'rotation'", "commit_ref": "c35123e6f91b6269cf6f5ae9216aeccebc545c75", "pull_url": null, "state": "accepted", "archived": false, "hash": "ed5b8abcc62258f24e47152165c94c648377fc0d", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10869/mbox/", "series": [ { "id": 1578, "url": "https://patchwork.libcamera.org/api/series/1578/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1578", "date": "2021-01-15T17:00:23", "name": "libcamera: camera_sensor: Make validation more strict", "version": 7, "mbox": "https://patchwork.libcamera.org/series/1578/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10869/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10869/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D0EDC3383\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Jan 2021 17:00:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F12D368115;\n\tFri, 15 Jan 2021 18:00:24 +0100 (CET)", "from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4888B680F7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jan 2021 18:00:20 +0100 (CET)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 173DE240015\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jan 2021 17:00:19 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 15 Jan 2021 18:00:29 +0100", "Message-Id": "<20210115170033.27124-7-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20210115170033.27124-1-jacopo@jmondi.org>", "References": "<20210115170033.27124-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v7 06/10] libcamera: camera_sensor: Do not\n\tdefault 'rotation'", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The 'rotation' property is not critical. Only register it if the\nsensor driver reports it.\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/camera_sensor.cpp | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 71aa268f3b4f..e9c80c304dd4 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -370,13 +370,11 @@ int CameraSensor::initProperties()\n \t}\n \tproperties_.set(properties::Location, propertyValue);\n \n-\t/* Camera Rotation: default is 0 degrees. */\n \tconst auto &rotationControl = controls.find(V4L2_CID_CAMERA_SENSOR_ROTATION);\n-\tif (rotationControl != controls.end())\n+\tif (rotationControl != controls.end()) {\n \t\tpropertyValue = rotationControl->second.def().get<int32_t>();\n-\telse\n-\t\tpropertyValue = 0;\n-\tproperties_.set(properties::Rotation, propertyValue);\n+\t\tproperties_.set(properties::Rotation, propertyValue);\n+\t}\n \n \tproperties_.set(properties::PixelArraySize, pixelArraySize_);\n \tproperties_.set(properties::PixelArrayActiveAreas, { activeArea_ });\n", "prefixes": [ "libcamera-devel", "v7", "06/10" ] }