Patch Detail
Show a patch.
GET /api/patches/10858/?format=api
{ "id": 10858, "url": "https://patchwork.libcamera.org/api/patches/10858/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10858/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210114104035.302968-3-paul.elder@ideasonboard.com>", "date": "2021-01-14T10:40:31", "name": "[libcamera-devel,2/6] android: CameraMetadata: Add copy constructor and getEntry", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e398da27b3a40dfd471e7a0f4808ca66a707460a", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10858/mbox/", "series": [ { "id": 1577, "url": "https://patchwork.libcamera.org/api/series/1577/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1577", "date": "2021-01-14T10:40:29", "name": "Fill in android result metadata and EXIF tags", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1577/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10858/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10858/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E59B8BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 14 Jan 2021 10:40:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AEAAC680ED;\n\tThu, 14 Jan 2021 11:40:52 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 382A9680DF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 14 Jan 2021 11:40:51 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 94DF08D7;\n\tThu, 14 Jan 2021 11:40:49 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nphq3Txh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1610620850;\n\tbh=O3ZevUqiO+qWSjpkBzvMsXGCq+YhyK2zeRIne6/fq3g=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=nphq3TxhzNqjYE4LHV0qDN8X3w8IDcxSGNnWQCHss/GDKcNSkoQYShsuW1g+RcG+Z\n\tA6boARpfp7DxVfkJEtBnKUGOAB6W99qYhDraYIueK86qNg+8ZiD7FmIitmVp9nb2ZW\n\tVzKwY71iptm3dAPE/cRkHPBMXwqFyvVGxkFEaUao=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 14 Jan 2021 19:40:31 +0900", "Message-Id": "<20210114104035.302968-3-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210114104035.302968-1-paul.elder@ideasonboard.com>", "References": "<20210114104035.302968-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/6] android: CameraMetadata: Add copy\n\tconstructor and getEntry", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a copy constructor to CameraMetadata, as well as a constructor from\ncamera_metadata_t. Also add a function getEntry to allow getting\nmetadata entries from CameraMetadata. This allows us to use\nCameraMetadata for reading form camera_metadata_t.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/android/camera_metadata.cpp | 23 +++++++++++++++++++++++\n src/android/camera_metadata.h | 3 +++\n 2 files changed, 26 insertions(+)", "diff": "diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\nindex edea48fe..57ac6009 100644\n--- a/src/android/camera_metadata.cpp\n+++ b/src/android/camera_metadata.cpp\n@@ -19,12 +19,35 @@ CameraMetadata::CameraMetadata(size_t entryCapacity, size_t dataCapacity)\n \tvalid_ = metadata_ != nullptr;\n }\n \n+CameraMetadata::CameraMetadata(const camera_metadata_t *metadata)\n+{\n+\tmetadata_ = clone_camera_metadata(metadata);\n+\tvalid_ = metadata_ != nullptr;\n+}\n+\n+CameraMetadata::CameraMetadata(const CameraMetadata &other)\n+{\n+\tmetadata_ = clone_camera_metadata(other.get());\n+\tvalid_ = metadata_ != nullptr;\n+}\n+\n CameraMetadata::~CameraMetadata()\n {\n \tif (metadata_)\n \t\tfree_camera_metadata(metadata_);\n }\n \n+int CameraMetadata::getEntry(uint32_t tag, camera_metadata_ro_entry_t *entry) const\n+{\n+\tif (!entry)\n+\t\treturn -EINVAL;\n+\n+\tif (find_camera_metadata_ro_entry(metadata_, tag, entry))\n+\t\treturn -EINVAL;\n+\n+\treturn 0;\n+}\n+\n bool CameraMetadata::addEntry(uint32_t tag, const void *data, size_t count)\n {\n \tif (!valid_)\ndiff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\nindex 9d047b1b..fa1c4983 100644\n--- a/src/android/camera_metadata.h\n+++ b/src/android/camera_metadata.h\n@@ -15,9 +15,12 @@ class CameraMetadata\n {\n public:\n \tCameraMetadata(size_t entryCapacity, size_t dataCapacity);\n+\tCameraMetadata(const camera_metadata_t *metadata);\n+\tCameraMetadata(const CameraMetadata &other);\n \t~CameraMetadata();\n \n \tbool isValid() const { return valid_; }\n+\tint getEntry(uint32_t tag, camera_metadata_ro_entry_t *entry) const;\n \tbool addEntry(uint32_t tag, const void *data, size_t data_count);\n \tbool updateEntry(uint32_t tag, const void *data, size_t data_count);\n \n", "prefixes": [ "libcamera-devel", "2/6" ] }