Patch Detail
Show a patch.
GET /api/patches/10844/?format=api
{ "id": 10844, "url": "https://patchwork.libcamera.org/api/patches/10844/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10844/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210108180113.17039-1-email@uajain.com>", "date": "2021-01-08T18:01:13", "name": "[libcamera-devel] libcamera: pipeline: ipu3: Stop ImgU and CIO2 on IPA error path", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c04ff232eba9fd33bdb2015a320e87cc3d5202cd", "submitter": { "id": 1, "url": "https://patchwork.libcamera.org/api/people/1/?format=api", "name": "Umang Jain", "email": "email@uajain.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10844/mbox/", "series": [ { "id": 1573, "url": "https://patchwork.libcamera.org/api/series/1573/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1573", "date": "2021-01-08T18:01:13", "name": "[libcamera-devel] libcamera: pipeline: ipu3: Stop ImgU and CIO2 on IPA error path", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1573/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10844/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10844/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD56CC3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 8 Jan 2021 18:01:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 533B768062;\n\tFri, 8 Jan 2021 19:01:20 +0100 (CET)", "from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4FEFF68056\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 8 Jan 2021 19:01:19 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"wdk0FvfL\"; dkim-atps=neutral", "From": "Umang Jain <email@uajain.com>", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1610128878; bh=zQOMLf7+S07cr1K+1u105qml4bqM7cz61/F40/jxZ1o=;\n\th=From:To:Cc:Subject;\n\tb=wdk0FvfL4+JqsQcX395fKwHF7NSV2M5ciPkEFbJpeaf3FfaQjCoN/DfcGPjVAq5j4\n\tgp6/VpGh0CewMRoh+uxfHNuT9ZVya1+/zA8NBvAPTwlcDiOMz3OLMkRIkHCwLurcjI\n\t4mGyc68aaYFmzc7e0BqXxTu+EKEQy5c4Z6eyUY9hFVOtJYkagFhehu3zQ55hQNCBEc\n\tUrrwZwWShHnCVLnxyfeJt4VLQV9w2oBMLzaguOb6U61zsDFPc2+JsbauzRz0qEwlNl\n\toHtXPnCK5QibjmuRYSEHnSOwZ+x/Z1bQy339/RuNQX9Jap8SAwM4yulJenlPTJF0UC\n\tSJc5rXLMBgTdQ==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 8 Jan 2021 23:31:13 +0530", "Message-Id": "<20210108180113.17039-1-email@uajain.com>", "Mime-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Stop ImgU and\n\tCIO2 on IPA error path", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Do not let freeBuffers() run before ImgU and CIO2 are stopped on IPA\nconfiguration failure path.\n\nSigned-off-by: Umang Jain <email@uajain.com>\nSuggested-by: Jacopo Mondi <jacopo@jmondi.org>\nChange-Id: Iadf0c950c24dcd3b6788275e36f2c028fbc53d7b\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 6cd1879a..3c7f98a9 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -694,6 +694,8 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] ControlList *con\n \tif ((result.operation != IPU3_IPA_STATUS_CONFIGURATION) ||\n \t (result.data.size() != 1) || (result.data.at(0) != 1)) {\n \t\tLOG(IPU3, Warning) << \"Failed to configure IPA\";\n+\t\timgu->stop();\n+\t\tcio2->stop();\n \t\tret = -EINVAL;\n \t\tgoto error;\n \t}\n", "prefixes": [ "libcamera-devel" ] }