Patch Detail
Show a patch.
GET /api/patches/10815/?format=api
{ "id": 10815, "url": "https://patchwork.libcamera.org/api/patches/10815/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10815/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210105190522.682324-2-jacopo@jmondi.org>", "date": "2021-01-05T19:05:11", "name": "[libcamera-devel,01/12] libcamera: CameraSensor: Mention V4L2 in get/setControls()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4f3e8d7ac753274df76d9f0a1d1ca6d816b0f257", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/10815/mbox/", "series": [ { "id": 1568, "url": "https://patchwork.libcamera.org/api/series/1568/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1568", "date": "2021-01-05T19:05:10", "name": "android: Exposure times + scaler crop + android metadata", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1568/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10815/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10815/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B4A5C0F1A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 5 Jan 2021 19:05:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 47714630BB;\n\tTue, 5 Jan 2021 20:05:16 +0100 (CET)", "from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E47EA6220D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 5 Jan 2021 20:05:13 +0100 (CET)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id A6F54100002\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 5 Jan 2021 19:05:13 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 5 Jan 2021 20:05:11 +0100", "Message-Id": "<20210105190522.682324-2-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20210105190522.682324-1-jacopo@jmondi.org>", "References": "<20210105190522.682324-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 01/12] libcamera: CameraSensor: Mention\n\tV4L2 in get/setControls()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The current CameraSensor interface for reading and writing controls\nis currently based on V4L2 controls.\n\nMention that more clearly in the documentation and, while at it, re-sort\nthe documentation to match the methods declaration order.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/camera_sensor.cpp | 24 +++++++++++++-----------\n 1 file changed, 13 insertions(+), 11 deletions(-)", "diff": "diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 046474c03f4a..05a1d7c22e97 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -593,11 +593,12 @@ const ControlInfoMap &CameraSensor::controls() const\n }\n \n /**\n- * \\brief Read controls from the sensor\n+ * \\brief Read V4L2 controls from the sensor\n * \\param[in] ids The list of controls to read, specified by their ID\n *\n * This method reads the value of all controls contained in \\a ids, and returns\n- * their values as a ControlList.\n+ * their values as a ControlList. The control identifiers are defined by the\n+ * V4L2 specification (V4L2_CID_*).\n *\n * If any control in \\a ids is not supported by the device, is disabled (i.e.\n * has the V4L2_CTRL_FLAG_DISABLED flag set), or if any other error occurs\n@@ -615,18 +616,13 @@ ControlList CameraSensor::getControls(const std::vector<uint32_t> &ids)\n }\n \n /**\n- * \\fn CameraSensor::properties()\n- * \\brief Retrieve the camera sensor properties\n- * \\return The list of camera sensor properties\n- */\n-\n-/**\n- * \\brief Write controls to the sensor\n+ * \\brief Write V4L2 controls to the sensor\n * \\param[in] ctrls The list of controls to write\n *\n * This method writes the value of all controls contained in \\a ctrls, and\n- * stores the values actually applied to the device in the corresponding\n- * \\a ctrls entry.\n+ * stores the values actually applied to the device in the corresponding \\a\n+ * ctrls entry. The control identifiers are defined by the V4L2 specification\n+ * (V4L2_CID_*).\n *\n * If any control in \\a ctrls is not supported by the device, is disabled (i.e.\n * has the V4L2_CTRL_FLAG_DISABLED flag set), is read-only, or if any other\n@@ -649,6 +645,12 @@ int CameraSensor::setControls(ControlList *ctrls)\n \treturn subdev_->setControls(ctrls);\n }\n \n+/**\n+ * \\fn CameraSensor::properties()\n+ * \\brief Retrieve the camera sensor properties\n+ * \\return The list of camera sensor properties\n+ */\n+\n /**\n * \\brief Assemble and return the camera sensor info\n * \\param[out] info The camera sensor info\n", "prefixes": [ "libcamera-devel", "01/12" ] }