Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 10793,
    "url": "https://patchwork.libcamera.org/api/patches/10793/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/10793/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20201231154711.207852-1-jeanmichel.hautbois@ideasonboard.com>",
    "date": "2020-12-31T15:47:10",
    "name": "[libcamera-devel] libcamera: revert C++17 specific code for public API",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": false,
    "hash": "417a5386c375662afd38e75ef880bdaaaddde14a",
    "submitter": {
        "id": 75,
        "url": "https://patchwork.libcamera.org/api/people/75/?format=api",
        "name": "Jean-Michel Hautbois",
        "email": "jeanmichel.hautbois@ideasonboard.com"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/10793/mbox/",
    "series": [
        {
            "id": 1563,
            "url": "https://patchwork.libcamera.org/api/series/1563/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1563",
            "date": "2020-12-31T15:47:10",
            "name": "[libcamera-devel] libcamera: revert C++17 specific code for public API",
            "version": 1,
            "mbox": "https://patchwork.libcamera.org/series/1563/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/10793/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/10793/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>",
        "X-Original-To": "parsemail@patchwork.libcamera.org",
        "Delivered-To": "parsemail@patchwork.libcamera.org",
        "Received": [
            "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BDC03C0F1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 31 Dec 2020 15:47:15 +0000 (UTC)",
            "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E52D615B2;\n\tThu, 31 Dec 2020 16:47:15 +0100 (CET)",
            "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D74796031B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 31 Dec 2020 16:47:13 +0100 (CET)",
            "from localhost.localdomain (unknown\n\t[IPv6:2a01:e0a:169:7140:c855:241b:6286:4626])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 60CCD52F;\n\tThu, 31 Dec 2020 16:47:13 +0100 (CET)"
        ],
        "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"b1oJkEg6\"; dkim-atps=neutral",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1609429633;\n\tbh=Kf2/mOWQCWRgJMYWzkZXM3J2voLeWVZI0lXA4HPw5gQ=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=b1oJkEg6lviVkkhtcqE4Pwj8FmABq2yIZ6fH0dj3fzk8Az6BytrNL0yfmOVdNY+MP\n\to0ixK6T1nbNnj7fN5JFUnnhVH3tr0RkC4+5LNb+q375aABlw8IDNCsilV6j3jr6jeo\n\tdNhQKLUYUMU5R0x1a6Rfdk0SNG+628JPNCruxsp4=",
        "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Date": "Thu, 31 Dec 2020 16:47:10 +0100",
        "Message-Id": "<20201231154711.207852-1-jeanmichel.hautbois@ideasonboard.com>",
        "X-Mailer": "git-send-email 2.27.0",
        "MIME-Version": "1.0",
        "Subject": "[libcamera-devel] [PATCH] libcamera: revert C++17 specific code for\n\tpublic API",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "Content-Type": "text/plain; charset=\"us-ascii\"",
        "Content-Transfer-Encoding": "7bit",
        "Errors-To": "libcamera-devel-bounces@lists.libcamera.org",
        "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"
    },
    "content": "Some applications may not be compliant with C++17 (Chromium, as an\nexample). Keep the C++17 features for libcamera internals, and C++14\ncompliance for public API.\n\nThis reverts commits 8e42c2feb7ff7c350ffbbf97dd963dfd54e21faa and\n6cbdc2859963e17bc897a4022f1d68170477d888.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n include/libcamera/bound_method.h |  2 +-\n include/libcamera/controls.h     | 24 +++++------\n include/libcamera/object.h       |  2 +-\n include/libcamera/signal.h       |  4 +-\n include/libcamera/span.h         | 70 +++++++++++++++-----------------\n 5 files changed, 48 insertions(+), 54 deletions(-)",
    "diff": "diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\nindex feac51da..95a95653 100644\n--- a/include/libcamera/bound_method.h\n+++ b/include/libcamera/bound_method.h\n@@ -63,7 +63,7 @@ public:\n \t}\n \tvirtual ~BoundMethodBase() = default;\n \n-\ttemplate<typename T, typename std::enable_if_t<!std::is_same_v<Object, T>> * = nullptr>\n+\ttemplate<typename T, typename std::enable_if_t<!std::is_same<Object, T>::value> * = nullptr>\n \tbool match(T *obj) { return obj == obj_; }\n \tbool match(Object *object) { return object == object_; }\n \ndiff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 3634dc43..3b7f3347 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -96,9 +96,9 @@ public:\n \tControlValue();\n \n #ifndef __DOXYGEN__\n-\ttemplate<typename T, typename std::enable_if_t<!details::is_span_v<T> &&\n+\ttemplate<typename T, typename std::enable_if_t<!details::is_span<T>::value &&\n \t\t\t\t\t\t       details::control_type<T>::value &&\n-\t\t\t\t\t\t       !std::is_same_v<std::string, std::remove_cv_t<T>>,\n+\t\t\t\t\t\t       !std::is_same<std::string, std::remove_cv_t<T>>::value,\n \t\t\t\t\t\t       std::nullptr_t> = nullptr>\n \tControlValue(const T &value)\n \t\t: type_(ControlTypeNone), numElements_(0)\n@@ -107,8 +107,8 @@ public:\n \t\t    &value, 1, sizeof(T));\n \t}\n \n-\ttemplate<typename T, typename std::enable_if_t<details::is_span_v<T> ||\n-\t\t\t\t\t\t       std::is_same_v<std::string, std::remove_cv_t<T>>,\n+\ttemplate<typename T, typename std::enable_if_t<details::is_span<T>::value ||\n+\t\t\t\t\t\t       std::is_same<std::string, std::remove_cv_t<T>>::value,\n \t\t\t\t\t\t       std::nullptr_t> = nullptr>\n #else\n \ttemplate<typename T>\n@@ -141,8 +141,8 @@ public:\n \t}\n \n #ifndef __DOXYGEN__\n-\ttemplate<typename T, typename std::enable_if_t<!details::is_span_v<T> &&\n-\t\t\t\t\t\t       !std::is_same_v<std::string, std::remove_cv_t<T>>,\n+\ttemplate<typename T, typename std::enable_if_t<!details::is_span<T>::value &&\n+\t\t\t\t\t\t       !std::is_same<std::string, std::remove_cv_t<T>>::value,\n \t\t\t\t\t\t       std::nullptr_t> = nullptr>\n \tT get() const\n \t{\n@@ -152,8 +152,8 @@ public:\n \t\treturn *reinterpret_cast<const T *>(data().data());\n \t}\n \n-\ttemplate<typename T, typename std::enable_if_t<details::is_span_v<T> ||\n-\t\t\t\t\t\t       std::is_same_v<std::string, std::remove_cv_t<T>>,\n+\ttemplate<typename T, typename std::enable_if_t<details::is_span<T>::value ||\n+\t\t\t\t\t\t       std::is_same<std::string, std::remove_cv_t<T>>::value,\n \t\t\t\t\t\t       std::nullptr_t> = nullptr>\n #else\n \ttemplate<typename T>\n@@ -169,8 +169,8 @@ public:\n \t}\n \n #ifndef __DOXYGEN__\n-\ttemplate<typename T, typename std::enable_if_t<!details::is_span_v<T> &&\n-\t\t\t\t\t\t       !std::is_same_v<std::string, std::remove_cv_t<T>>,\n+\ttemplate<typename T, typename std::enable_if_t<!details::is_span<T>::value &&\n+\t\t\t\t\t\t       !std::is_same<std::string, std::remove_cv_t<T>>::value,\n \t\t\t\t\t\t       std::nullptr_t> = nullptr>\n \tvoid set(const T &value)\n \t{\n@@ -178,8 +178,8 @@ public:\n \t\t    reinterpret_cast<const void *>(&value), 1, sizeof(T));\n \t}\n \n-\ttemplate<typename T, typename std::enable_if_t<details::is_span_v<T> ||\n-\t\t\t\t\t\t       std::is_same_v<std::string, std::remove_cv_t<T>>,\n+\ttemplate<typename T, typename std::enable_if_t<details::is_span<T>::value ||\n+\t\t\t\t\t\t       std::is_same<std::string, std::remove_cv_t<T>>::value,\n \t\t\t\t\t\t       std::nullptr_t> = nullptr>\n #else\n \ttemplate<typename T>\ndiff --git a/include/libcamera/object.h b/include/libcamera/object.h\nindex 423208db..a1882f05 100644\n--- a/include/libcamera/object.h\n+++ b/include/libcamera/object.h\n@@ -32,7 +32,7 @@ public:\n \tvoid postMessage(std::unique_ptr<Message> msg);\n \n \ttemplate<typename T, typename R, typename... FuncArgs, typename... Args,\n-\t\t typename std::enable_if_t<std::is_base_of_v<Object, T>> * = nullptr>\n+\t\t typename std::enable_if_t<std::is_base_of<Object, T>::value> * = nullptr>\n \tR invokeMethod(R (T::*func)(FuncArgs...), ConnectionType type,\n \t\t       Args... args)\n \t{\ndiff --git a/include/libcamera/signal.h b/include/libcamera/signal.h\nindex 46d917d5..5bcd7a77 100644\n--- a/include/libcamera/signal.h\n+++ b/include/libcamera/signal.h\n@@ -44,7 +44,7 @@ public:\n \t}\n \n #ifndef __DOXYGEN__\n-\ttemplate<typename T, typename R, typename std::enable_if_t<std::is_base_of_v<Object, T>> * = nullptr>\n+\ttemplate<typename T, typename R, typename std::enable_if_t<std::is_base_of<Object, T>::value> * = nullptr>\n \tvoid connect(T *obj, R (T::*func)(Args...),\n \t\t     ConnectionType type = ConnectionTypeAuto)\n \t{\n@@ -52,7 +52,7 @@ public:\n \t\tSignalBase::connect(new BoundMethodMember<T, void, Args...>(obj, object, func, type));\n \t}\n \n-\ttemplate<typename T, typename R, typename std::enable_if_t<!std::is_base_of_v<Object, T>> * = nullptr>\n+\ttemplate<typename T, typename R, typename std::enable_if_t<!std::is_base_of<Object, T>::value> * = nullptr>\n #else\n \ttemplate<typename T, typename R>\n #endif\ndiff --git a/include/libcamera/span.h b/include/libcamera/span.h\nindex e7ffef12..91e9f974 100644\n--- a/include/libcamera/span.h\n+++ b/include/libcamera/span.h\n@@ -31,9 +31,6 @@ template<typename U, std::size_t N>\n struct is_array<std::array<U, N>> : public std::true_type {\n };\n \n-template<typename T>\n-inline constexpr bool is_array_v = is_array<T>::value;\n-\n template<typename U>\n struct is_span : public std::false_type {\n };\n@@ -42,9 +39,6 @@ template<typename U, std::size_t Extent>\n struct is_span<Span<U, Extent>> : public std::true_type {\n };\n \n-template<typename T>\n-inline constexpr bool is_span_v = is_span<T>::value;\n-\n } /* namespace details */\n \n namespace utils {\n@@ -131,8 +125,8 @@ public:\n \n \ttemplate<std::size_t N>\n \tconstexpr Span(element_type (&arr)[N],\n-\t\t       std::enable_if_t<std::is_convertible_v<std::remove_pointer_t<decltype(utils::data(arr))> (*)[],\n-\t\t\t\t\t\t\t      element_type (*)[]> &&\n+\t\t       std::enable_if_t<std::is_convertible<std::remove_pointer_t<decltype(utils::data(arr))> (*)[],\n+\t\t\t\t\t\t\t    element_type (*)[]>::value &&\n \t\t\t\t\tN == Extent,\n \t\t\t\t\tstd::nullptr_t> = nullptr) noexcept\n \t\t: data_(arr)\n@@ -141,8 +135,8 @@ public:\n \n \ttemplate<std::size_t N>\n \tconstexpr Span(std::array<value_type, N> &arr,\n-\t\t       std::enable_if_t<std::is_convertible_v<std::remove_pointer_t<decltype(utils::data(arr))> (*)[],\n-\t\t\t\t\t\t\t      element_type (*)[]> &&\n+\t\t       std::enable_if_t<std::is_convertible<std::remove_pointer_t<decltype(utils::data(arr))> (*)[],\n+\t\t\t\t\t\t\t    element_type (*)[]>::value &&\n \t\t\t\t\tN == Extent,\n \t\t\t\t\tstd::nullptr_t> = nullptr) noexcept\n \t\t: data_(arr.data())\n@@ -151,8 +145,8 @@ public:\n \n \ttemplate<std::size_t N>\n \tconstexpr Span(const std::array<value_type, N> &arr,\n-\t\t       std::enable_if_t<std::is_convertible_v<std::remove_pointer_t<decltype(utils::data(arr))> (*)[],\n-\t\t\t\t\t\t\t      element_type (*)[]> &&\n+\t\t       std::enable_if_t<std::is_convertible<std::remove_pointer_t<decltype(utils::data(arr))> (*)[],\n+\t\t\t\t\t\t\t    element_type (*)[]>::value &&\n \t\t\t\t\tN == Extent,\n \t\t\t\t\tstd::nullptr_t> = nullptr) noexcept\n \t\t: data_(arr.data())\n@@ -161,11 +155,11 @@ public:\n \n \ttemplate<class Container>\n \texplicit constexpr Span(Container &cont,\n-\t\t\t\tstd::enable_if_t<!details::is_span_v<Container> &&\n-\t\t\t\t\t\t !details::is_array_v<Container> &&\n-\t\t\t\t\t\t !std::is_array_v<Container> &&\n-\t\t\t\t\t\t std::is_convertible_v<std::remove_pointer_t<decltype(utils::data(cont))> (*)[],\n-\t\t\t\t\t\t\t\t       element_type (*)[]>,\n+\t\t\t\tstd::enable_if_t<!details::is_span<Container>::value &&\n+\t\t\t\t\t\t !details::is_array<Container>::value &&\n+\t\t\t\t\t\t !std::is_array<Container>::value &&\n+\t\t\t\t\t\t std::is_convertible<std::remove_pointer_t<decltype(utils::data(cont))> (*)[],\n+\t\t\t\t\t\t\t\t     element_type (*)[]>::value,\n \t\t\t\t\t\t std::nullptr_t> = nullptr)\n \t\t: data_(utils::data(cont))\n \t{\n@@ -173,11 +167,11 @@ public:\n \n \ttemplate<class Container>\n \texplicit constexpr Span(const Container &cont,\n-\t\t\t\tstd::enable_if_t<!details::is_span_v<Container> &&\n-\t\t\t\t\t\t !details::is_array_v<Container> &&\n-\t\t\t\t\t\t !std::is_array_v<Container> &&\n-\t\t\t\t\t\t std::is_convertible_v<std::remove_pointer_t<decltype(utils::data(cont))> (*)[],\n-\t\t\t\t\t\t\t\t       element_type (*)[]>,\n+\t\t\t\tstd::enable_if_t<!details::is_span<Container>::value &&\n+\t\t\t\t\t\t !details::is_array<Container>::value &&\n+\t\t\t\t\t\t !std::is_array<Container>::value &&\n+\t\t\t\t\t\t std::is_convertible<std::remove_pointer_t<decltype(utils::data(cont))> (*)[],\n+\t\t\t\t\t\t\t\t     element_type (*)[]>::value,\n \t\t\t\t\t\t std::nullptr_t> = nullptr)\n \t\t: data_(utils::data(cont))\n \t{\n@@ -186,7 +180,7 @@ public:\n \n \ttemplate<class U, std::size_t N>\n \texplicit constexpr Span(const Span<U, N> &s,\n-\t\t\t\tstd::enable_if_t<std::is_convertible_v<U (*)[], element_type (*)[]> &&\n+\t\t\t\tstd::enable_if_t<std::is_convertible<U (*)[], element_type (*)[]>::value &&\n \t\t\t\t\t\t N == Extent,\n \t\t\t\t\t\t std::nullptr_t> = nullptr) noexcept\n \t\t: data_(s.data())\n@@ -299,8 +293,8 @@ public:\n \n \ttemplate<std::size_t N>\n \tconstexpr Span(element_type (&arr)[N],\n-\t\t       std::enable_if_t<std::is_convertible_v<std::remove_pointer_t<decltype(utils::data(arr))> (*)[],\n-\t\t\t\t\t\t\t      element_type (*)[]>,\n+\t\t       std::enable_if_t<std::is_convertible<std::remove_pointer_t<decltype(utils::data(arr))> (*)[],\n+\t\t\t\t\t\t\t    element_type (*)[]>::value,\n \t\t\t\t\tstd::nullptr_t> = nullptr) noexcept\n \t\t: data_(arr), size_(N)\n \t{\n@@ -308,8 +302,8 @@ public:\n \n \ttemplate<std::size_t N>\n \tconstexpr Span(std::array<value_type, N> &arr,\n-\t\t       std::enable_if_t<std::is_convertible_v<std::remove_pointer_t<decltype(utils::data(arr))> (*)[],\n-\t\t\t\t\t\t\t      element_type (*)[]>,\n+\t\t       std::enable_if_t<std::is_convertible<std::remove_pointer_t<decltype(utils::data(arr))> (*)[],\n+\t\t\t\t\t\t\t    element_type (*)[]>::value,\n \t\t\t\t\tstd::nullptr_t> = nullptr) noexcept\n \t\t: data_(utils::data(arr)), size_(N)\n \t{\n@@ -323,11 +317,11 @@ public:\n \n \ttemplate<class Container>\n \tconstexpr Span(Container &cont,\n-\t\t       std::enable_if_t<!details::is_span_v<Container> &&\n-\t\t\t\t\t!details::is_array_v<Container> &&\n-\t\t\t\t\t!std::is_array_v<Container> &&\n-\t\t\t\t\tstd::is_convertible_v<std::remove_pointer_t<decltype(utils::data(cont))> (*)[],\n-\t\t\t\t\t\t\t      element_type (*)[]>,\n+\t\t       std::enable_if_t<!details::is_span<Container>::value &&\n+\t\t\t\t\t!details::is_array<Container>::value &&\n+\t\t\t\t\t!std::is_array<Container>::value &&\n+\t\t\t\t\tstd::is_convertible<std::remove_pointer_t<decltype(utils::data(cont))> (*)[],\n+\t\t\t\t\t\t\t    element_type (*)[]>::value,\n \t\t\t\t\tstd::nullptr_t> = nullptr)\n \t\t: data_(utils::data(cont)), size_(utils::size(cont))\n \t{\n@@ -335,11 +329,11 @@ public:\n \n \ttemplate<class Container>\n \tconstexpr Span(const Container &cont,\n-\t\t       std::enable_if_t<!details::is_span_v<Container> &&\n-\t\t\t\t\t!details::is_array_v<Container> &&\n-\t\t\t\t\t!std::is_array_v<Container> &&\n-\t\t\t\t\tstd::is_convertible_v<std::remove_pointer_t<decltype(utils::data(cont))> (*)[],\n-\t\t\t\t\t\t\t      element_type (*)[]>,\n+\t\t       std::enable_if_t<!details::is_span<Container>::value &&\n+\t\t\t\t\t!details::is_array<Container>::value &&\n+\t\t\t\t\t!std::is_array<Container>::value &&\n+\t\t\t\t\tstd::is_convertible<std::remove_pointer_t<decltype(utils::data(cont))> (*)[],\n+\t\t\t\t\t\t\t    element_type (*)[]>::value,\n \t\t\t\t\tstd::nullptr_t> = nullptr)\n \t\t: data_(utils::data(cont)), size_(utils::size(cont))\n \t{\n@@ -347,7 +341,7 @@ public:\n \n \ttemplate<class U, std::size_t N>\n \tconstexpr Span(const Span<U, N> &s,\n-\t\t       std::enable_if_t<std::is_convertible_v<U (*)[], element_type (*)[]>,\n+\t\t       std::enable_if_t<std::is_convertible<U (*)[], element_type (*)[]>::value,\n \t\t\t\t\tstd::nullptr_t> = nullptr) noexcept\n \t\t: data_(s.data()), size_(s.size())\n \t{\n",
    "prefixes": [
        "libcamera-devel"
    ]
}