Patch Detail
Show a patch.
GET /api/patches/10768/?format=api
{ "id": 10768, "url": "https://patchwork.libcamera.org/api/patches/10768/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10768/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201229160318.77536-3-niklas.soderlund@ragnatech.se>", "date": "2020-12-29T16:03:09", "name": "[libcamera-devel,v2,02/11] libcamera: ipu3: imgu: Configure the stat video device as part of configure()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c2bbb72c4042e0bf9a98928d57560d177d0b09c6", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": { "id": 16, "url": "https://patchwork.libcamera.org/api/users/16/?format=api", "username": "neg", "first_name": "Niklas", "last_name": "Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "mbox": "https://patchwork.libcamera.org/patch/10768/mbox/", "series": [ { "id": 1559, "url": "https://patchwork.libcamera.org/api/series/1559/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1559", "date": "2020-12-29T16:03:07", "name": "libcamera: ipu3: Attach to an skeleton IPA", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1559/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10768/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10768/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AEC1AC0F1A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 29 Dec 2020 16:04:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7548B61D25;\n\tTue, 29 Dec 2020 17:04:05 +0100 (CET)", "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DD7060320\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 29 Dec 2020 17:04:03 +0100 (CET)", "from bismarck.berto.se (p4fca2458.dip0.t-ipconnect.de\n\t[79.202.36.88])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 7788e077-49ef-11eb-a542-005056917a89;\n\tTue, 29 Dec 2020 17:04:02 +0100 (CET)" ], "X-Halon-ID": "7788e077-49ef-11eb-a542-005056917a89", "Authorized-sender": "niklas.soderlund@fsdn.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 29 Dec 2020 17:03:09 +0100", "Message-Id": "<20201229160318.77536-3-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20201229160318.77536-1-niklas.soderlund@ragnatech.se>", "References": "<20201229160318.77536-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 02/11] libcamera: ipu3: imgu: Configure\n\tthe stat video device as part of configure()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "There is no reason to expose and call a separate configureStat() when\nthe statistics video device can be configured with the exact same\nparameters as part of configure(). Move the configuration internally to\nthe ImgUDevice simplifying the interface, there is no functional change.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/imgu.cpp | 7 +++++++\n src/libcamera/pipeline/ipu3/imgu.h | 7 -------\n src/libcamera/pipeline/ipu3/ipu3.cpp | 11 -----------\n 3 files changed, 7 insertions(+), 18 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\nindex 5b1c0318b42695b7..08f0fce9d740963f 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.cpp\n+++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n@@ -475,6 +475,13 @@ int ImgUDevice::configure(const PipeConfig &pipeConfig, V4L2DeviceFormat *inputF\n \n \tLOG(IPU3, Debug) << \"ImgU GDC format = \" << gdcFormat.toString();\n \n+\tStreamConfiguration statCfg = {};\n+\tstatCfg.size = inputFormat->size;\n+\tV4L2DeviceFormat statFormat;\n+\tret = configureVideoDevice(stat_.get(), PAD_STAT, statCfg, &statFormat);\n+\tif (ret)\n+\t\treturn ret;\n+\n \treturn 0;\n }\n \ndiff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h\nindex c73ac5a5a37cfe0e..37f5ae77c99ff8fe 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.h\n+++ b/src/libcamera/pipeline/ipu3/imgu.h\n@@ -61,13 +61,6 @@ public:\n \t\t\t\t\t outputFormat);\n \t}\n \n-\tint configureStat(const StreamConfiguration &cfg,\n-\t\t\t V4L2DeviceFormat *outputFormat)\n-\t{\n-\t\treturn configureVideoDevice(stat_.get(), PAD_STAT, cfg,\n-\t\t\t\t\t outputFormat);\n-\t}\n-\n \tint allocateBuffers(unsigned int bufferCount);\n \tvoid freeBuffers();\n \ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex f1151733d9fe81ff..3e0e88fa63c4f1fb 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -518,17 +518,6 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \t\t\treturn ret;\n \t}\n \n-\t/*\n-\t * Apply the largest available format to the stat node.\n-\t * \\todo Revise this when we'll actually use the stat node.\n-\t */\n-\tStreamConfiguration statCfg = {};\n-\tstatCfg.size = cio2Format.size;\n-\n-\tret = imgu->configureStat(statCfg, &outputFormat);\n-\tif (ret)\n-\t\treturn ret;\n-\n \t/* Apply the \"pipe_mode\" control to the ImgU subdevice. */\n \tControlList ctrls(imgu->imgu_->controls());\n \tctrls.set(V4L2_CID_IPU3_PIPE_MODE,\n", "prefixes": [ "libcamera-devel", "v2", "02/11" ] }