Patch Detail
Show a patch.
GET /api/patches/1075/?format=api
{ "id": 1075, "url": "https://patchwork.libcamera.org/api/patches/1075/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1075/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190419101839.10337-3-jacopo@jmondi.org>", "date": "2019-04-19T10:18:33", "name": "[libcamera-devel,v7,2/8] libcamera: camera: Reset basefield to decimal", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f83735380a927f899830450c82715527ba7c48b8", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1075/mbox/", "series": [ { "id": 261, "url": "https://patchwork.libcamera.org/api/series/261/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=261", "date": "2019-04-19T10:18:31", "name": "libcamera: ipu3: Multiple streams support", "version": 7, "mbox": "https://patchwork.libcamera.org/series/261/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1075/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1075/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1A9160DBF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Apr 2019 12:17:52 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 62550FF811;\n\tFri, 19 Apr 2019 10:17:52 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 19 Apr 2019 12:18:33 +0200", "Message-Id": "<20190419101839.10337-3-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190419101839.10337-1-jacopo@jmondi.org>", "References": "<20190419101839.10337-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v7 2/8] libcamera: camera: Reset basefield\n\tto decimal", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 19 Apr 2019 10:17:53 -0000" }, "content": "When logging the camera configuration, the same ostringstream instance\nis used to assemble a message describing configuration of all the\nconfigured streams.\n\nAfter the first stream configuration has been assembled, the use of\nstd::hex modifies the ostringstream basefield, causing all successive\nintegers values inserted in the stream to be expressed as hexadecimals.\n\nFix that by resetting the stream's basefield to decimal, before\nassembling a stream configuration description.\n\nBefore this patch:\nINFO Camera camera.cpp:615 (0) 640x480-0x3231564e (1) 140xa0-0x3231564e\nAfter this patch:\nINFO Camera camera.cpp:616 (0) 640x480-0x3231564e (1) 320x160-0x3231564e\n\nFixes: 9c9078133216 (\"libcamera: camera: Log requested configuration in configureStreams()\")\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/camera.cpp | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex bd381fa1cb56..4af3780d305e 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -605,6 +605,7 @@ int Camera::configureStreams(const CameraConfiguration &config)\n \t\t\treturn -EINVAL;\n \n \t\tconst StreamConfiguration &cfg = config[stream];\n+\t\tmsg << std::dec;\n \t\tmsg << \" (\" << index << \") \" << cfg.width << \"x\"\n \t\t << cfg.height << \"-0x\" << std::hex << std::setfill('0')\n \t\t << std::setw(8) << cfg.pixelFormat;\n", "prefixes": [ "libcamera-devel", "v7", "2/8" ] }