Patch Detail
Show a patch.
GET /api/patches/10729/?format=api
{ "id": 10729, "url": "https://patchwork.libcamera.org/api/patches/10729/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10729/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201224081613.41662-8-paul.elder@ideasonboard.com>", "date": "2020-12-24T08:16:09", "name": "[libcamera-devel,v6,07/11] libcamera: PipelineHandler: Remove IPA from base class", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "d1b76f38aaf050851fba598c046625616ae76434", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10729/mbox/", "series": [ { "id": 1547, "url": "https://patchwork.libcamera.org/api/series/1547/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1547", "date": "2020-12-24T08:16:02", "name": "IPA isolation: Part 2: Conversion and plumbing", "version": 6, "mbox": "https://patchwork.libcamera.org/series/1547/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10729/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10729/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2C6DC0F1A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 24 Dec 2020 08:16:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A315D62006;\n\tThu, 24 Dec 2020 09:16:43 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D22E615AF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Dec 2020 09:16:42 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 08230A1D;\n\tThu, 24 Dec 2020 09:16:39 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"A/9yhlXl\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608797802;\n\tbh=y2WksN/nU16mGp3YcTWZfi6yDySaMB9wXhEZjlguY64=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=A/9yhlXlU+0RacOSQ46iBFgTI5aURB2GTAOxUsm+2c+sjwAScN3hMcWspr2Q/sxpv\n\tGU5CEnOOOGdC4/+qdEbTbSAQaTDVibnIAmRbipfxYdx+4ObpClkB3vqKQuAHPjP248\n\tePDeFJUvUHWhV8RHc0kEEI6skpVMJPV1eNn+gt1o=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 24 Dec 2020 17:16:09 +0900", "Message-Id": "<20201224081613.41662-8-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201224081613.41662-1-paul.elder@ideasonboard.com>", "References": "<20201224081613.41662-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v6 07/11] libcamera: PipelineHandler:\n\tRemove IPA from base class", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since pipeline handlers now have their own IPA interface types, it can no\nlonger be defined in the base class, and each pipeline handler\nimplementation must declare it and its type themselves. Remove it from\nthe base class.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nNo change in v6\n\nNo change in v5\n\nNo change in v4\n\nNo change in v3\n\nChanges in v2:\n- remove documentation\n---\n include/libcamera/internal/pipeline_handler.h | 1 -\n src/libcamera/pipeline_handler.cpp | 8 --------\n 2 files changed, 9 deletions(-)", "diff": "diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex bd3c4a81..0e9c6b43 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -47,7 +47,6 @@ public:\n \tstd::list<Request *> queuedRequests_;\n \tControlInfoMap controlInfo_;\n \tControlList properties_;\n-\tstd::unique_ptr<IPAProxy> ipa_;\n \n private:\n \tCameraData(const CameraData &) = delete;\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex c75ebbd5..48e929fa 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -106,14 +106,6 @@ LOG_DEFINE_CATEGORY(Pipeline)\n * when creating the camera, and shall not be modified afterwards.\n */\n \n-/**\n- * \\var CameraData::ipa_\n- * \\brief The IPA module used by the camera\n- *\n- * Reference to the Image Processing Algorithms (IPA) operating on the camera's\n- * stream(s). If no IPA exists for the camera, this field is set to nullptr.\n- */\n-\n /**\n * \\class PipelineHandler\n * \\brief Create and manage cameras based on a set of media devices\n", "prefixes": [ "libcamera-devel", "v6", "07/11" ] }