Patch Detail
Show a patch.
GET /api/patches/10717/?format=api
{ "id": 10717, "url": "https://patchwork.libcamera.org/api/patches/10717/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10717/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201224081534.41601-4-paul.elder@ideasonboard.com>", "date": "2020-12-24T08:15:28", "name": "[libcamera-devel,v6,3/9] utils: ipc: add generator script", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "31ab1a75c42a51e85ccea9e6ba734c1111c253fc", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10717/mbox/", "series": [ { "id": 1546, "url": "https://patchwork.libcamera.org/api/series/1546/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1546", "date": "2020-12-24T08:15:25", "name": "IPA isolation: Part 1: Core components", "version": 6, "mbox": "https://patchwork.libcamera.org/series/1546/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10717/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10717/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 02374C0F1A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 24 Dec 2020 08:15:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C0E07615B0;\n\tThu, 24 Dec 2020 09:15:55 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F2E4160529\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Dec 2020 09:15:53 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AA42BA1D;\n\tThu, 24 Dec 2020 09:15:51 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fCdBU71t\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608797753;\n\tbh=GJCDgoHy0PDVZSU4MlgvnfsrgkPKkrnBfQQn5nGZS1g=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fCdBU71tj6h54kG1vp6KluyY/lTGJyY/oZGfk9Cw9qIlcfKRTSSrn83XcOfPJXACY\n\tAMG+dVoYgiwW9LsRXKHJrbZbTr6M589Z1rBROYSCS4my/YZyJtXaGRRDXs8eB/Greb\n\t7av3si10wAAsbCiVqI5XO5/AT7YxGLz+4df0CZOw=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 24 Dec 2020 17:15:28 +0900", "Message-Id": "<20201224081534.41601-4-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201224081534.41601-1-paul.elder@ideasonboard.com>", "References": "<20201224081534.41601-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v6 3/9] utils: ipc: add generator script", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We want to avoid changing our copy of mojo to make updates easier. Some\nparameters in the mojo generator script needs to be changed though; add\na wrapper script that sets these parameters.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n---\nNo change in v6\n\nNo change in v5\n\nNo change in v4\n\nChanges in v3:\n- add SPDX and copyright and file description block\n- add todo for sys.pycache_prefix for python3.8+\n\nChanges in v2:\n- add descriptions to python setup\n- disable pycache\n---\n utils/ipc/generate.py | 29 +++++++++++++++++++++++++++++\n 1 file changed, 29 insertions(+)\n create mode 100755 utils/ipc/generate.py", "diff": "diff --git a/utils/ipc/generate.py b/utils/ipc/generate.py\nnew file mode 100755\nindex 00000000..8771e0a6\n--- /dev/null\n+++ b/utils/ipc/generate.py\n@@ -0,0 +1,29 @@\n+#!/usr/bin/env python3\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright (C) 2020, Google Inc.\n+#\n+# Author: Paul Elder <paul.elder@ideasonboard.com>\n+#\n+# generate.py - Run mojo code generator for generating libcamera IPC files\n+\n+import os\n+import sys\n+\n+# TODO set sys.pycache_prefix for >= python3.8\n+sys.dont_write_bytecode = True\n+\n+import mojo.public.tools.bindings.mojom_bindings_generator as generator\n+\n+def _GetModulePath(path, output_dir):\n+ return os.path.join(output_dir, path.relative_path())\n+\n+# Override the mojo code generator's generator list to only contain our\n+# libcamera generator\n+generator._BUILTIN_GENERATORS = {'libcamera': 'mojom_libcamera_generator'}\n+\n+# Override the mojo code generator's _GetModulePath method to not add\n+# the '-module' suffix when searching for mojo modules, so that we can\n+# pass the path to the mojom module without having to trim the '-module' suffix\n+generator._GetModulePath = _GetModulePath\n+\n+generator.main()\n", "prefixes": [ "libcamera-devel", "v6", "3/9" ] }