Patch Detail
Show a patch.
GET /api/patches/10707/?format=api
{ "id": 10707, "url": "https://patchwork.libcamera.org/api/patches/10707/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10707/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201223174709.45457-7-jacopo@jmondi.org>", "date": "2020-12-23T17:47:09", "name": "[libcamera-devel,6/6] android: camera_device: Simplify properties.get()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1f13c30ebf3d20e5f822564a1f05faae308e1e5b", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/10707/mbox/", "series": [ { "id": 1544, "url": "https://patchwork.libcamera.org/api/series/1544/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1544", "date": "2020-12-23T17:47:03", "name": "android: support ColorFilterArrangement property", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1544/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10707/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10707/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B6DEC0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 23 Dec 2020 17:47:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F592619AF;\n\tWed, 23 Dec 2020 18:47:09 +0100 (CET)", "from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 57F28615D2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 23 Dec 2020 18:47:05 +0100 (CET)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 1E4B0FF806\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 23 Dec 2020 17:47:04 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 23 Dec 2020 18:47:09 +0100", "Message-Id": "<20201223174709.45457-7-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20201223174709.45457-1-jacopo@jmondi.org>", "References": "<20201223174709.45457-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 6/6] android: camera_device: Simplify\n\tproperties.get()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When accessing the value of a property by reading the properties\nControlList content with ControlList::get<>() it is not necessary to\nspecify the template type as it is already conveyed by the Control\ninstance provided as first argument.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_device.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 920baab254b6..fb4c8be34f95 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -853,7 +853,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t/* Sensor static metadata. */\n \tif (properties.contains(properties::PixelArraySize)) {\n \t\tconst Size &size =\n-\t\t\tproperties.get<Size>(properties::PixelArraySize);\n+\t\t\tproperties.get(properties::PixelArraySize);\n \t\tstd::vector<int32_t> data{\n \t\t\tstatic_cast<int32_t>(size.width),\n \t\t\tstatic_cast<int32_t>(size.height),\n@@ -872,7 +872,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \n \tif (properties.contains(properties::PixelArrayActiveAreas)) {\n \t\tconst Span<const Rectangle> &rects =\n-\t\t\tproperties.get<Span<const Rectangle>>(properties::PixelArrayActiveAreas);\n+\t\t\tproperties.get(properties::PixelArrayActiveAreas);\n \t\tstd::vector<int32_t> data{\n \t\t\tstatic_cast<int32_t>(rects[0].x),\n \t\t\tstatic_cast<int32_t>(rects[0].y),\n", "prefixes": [ "libcamera-devel", "6/6" ] }