Patch Detail
Show a patch.
GET /api/patches/10655/?format=api
{ "id": 10655, "url": "https://patchwork.libcamera.org/api/patches/10655/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10655/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201212034211.25174-1-laurent.pinchart@ideasonboard.com>", "date": "2020-12-12T03:42:11", "name": "[libcamera-devel] android: camera_device: Replace auto with explicit type", "commit_ref": "bd4894d2596168b3435fb93b9e53dad84b2dcc7e", "pull_url": null, "state": "accepted", "archived": false, "hash": "be852fdda0bb78b3767e2fc45cc20f05e2e04ba6", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10655/mbox/", "series": [ { "id": 1530, "url": "https://patchwork.libcamera.org/api/series/1530/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1530", "date": "2020-12-12T03:42:11", "name": "[libcamera-devel] android: camera_device: Replace auto with explicit type", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1530/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10655/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10655/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B0D47BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 12 Dec 2020 03:42:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 05F626033B;\n\tSat, 12 Dec 2020 04:42:23 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E39660327\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 12 Dec 2020 04:42:20 +0100 (CET)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CD33596;\n\tSat, 12 Dec 2020 04:42:19 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"B0YXVrNG\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1607744540;\n\tbh=Sw/ugCP2FFeCf2UInTqCU+vqqATyevR9oPGR/8McEQY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=B0YXVrNGi6ZEXZVLw9tSdwg0qSTeWruBF2+nhaiW84yjjQuW+pzjISqiNc2Jbyvt0\n\teqikPbWe8XXRsZTfSehgCiN/PSW+mEbD10fUji3UZFA8yyjsFmSze4uj3auectAeoj\n\tM2vIolOPpFgDNxjJJgBDMnwJBi5sX/ydQiTI8Gts=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 12 Dec 2020 05:42:11 +0200", "Message-Id": "<20201212034211.25174-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] android: camera_device: Replace auto with\n\texplicit type", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The auto keyword facilitates writing code. It avoids typing out very\nlong types, which can make the code more readable, but it can also have\na negative impact on readability as it requires the reader (including\nreviewers) to look up the type of the variable.\n\nReplace one occurrence of auto with the explicit type where doing so\ndoesn't require a long type name.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/android/camera_device.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 38689bdc40b1..79fd02eccdcd 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -199,7 +199,7 @@ void sortCamera3StreamConfigs(std::vector<Camera3StreamConfig> &unsortedConfigs,\n \tconst auto nv12It = formatToConfigs.find(formats::NV12);\n \tif (nv12It != formatToConfigs.end()) {\n \t\tauto &nv12Configs = nv12It->second;\n-\t\tconst auto &nv12Largest = nv12Configs.back();\n+\t\tconst Camera3StreamConfig *nv12Largest = nv12Configs.back();\n \n \t\t/*\n \t\t * If JPEG will be created from NV12 and the size is larger than\n", "prefixes": [ "libcamera-devel" ] }