Patch Detail
Show a patch.
GET /api/patches/10635/?format=api
{ "id": 10635, "url": "https://patchwork.libcamera.org/api/patches/10635/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10635/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201210163337.212857-1-naush@raspberrypi.com>", "date": "2020-12-10T16:33:35", "name": "[libcamera-devel,v6,1/3] libcamera: controls: Add frame duration control", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4055d8725f632b30542e80051ddb9d9b374e7b04", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10635/mbox/", "series": [ { "id": 1522, "url": "https://patchwork.libcamera.org/api/series/1522/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1522", "date": "2020-12-10T16:33:35", "name": "[libcamera-devel,v6,1/3] libcamera: controls: Add frame duration control", "version": 6, "mbox": "https://patchwork.libcamera.org/series/1522/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10635/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10635/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ED324BD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 10 Dec 2020 16:33:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7272567F75;\n\tThu, 10 Dec 2020 17:33:42 +0100 (CET)", "from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B6D367F6E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 10 Dec 2020 17:33:41 +0100 (CET)", "by mail-wm1-x334.google.com with SMTP id g185so5959090wmf.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 10 Dec 2020 08:33:41 -0800 (PST)", "from naushir-VirtualBox.pitowers.org\n\t([2a00:1098:3142:14:a00:27ff:fe4d:f6a2])\n\tby smtp.gmail.com with ESMTPSA id\n\tv7sm9589433wma.26.2020.12.10.08.33.39\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 10 Dec 2020 08:33:39 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"sINuxwAN\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=eIR3MVGby/dymFl1XAhYVzklHGNpDFvUa4zqKMvXn+k=;\n\tb=sINuxwANNjeRgMIxKVQMwwDHZAvAEtRhR7cGvItcrwtNgap41fVzN3sbyBSWvvyUxo\n\toefcEMr2yxX50CGm9zAGDC4L9dMedXLEit1J8GI6UUtYRc1lehhqKEMBGXEZDTGOgLbs\n\t1D5WOGVAharmC86+6mclKyQLmZvLuiL+kDXFTeS/Q63vo9WKNMwkjv/prFwTQ6mNBZq1\n\tD3zxO+DPLCxNC7apphVy5GjSye34nXKMRmRPpFY29uLogaqlgU00JJgDlAibIdLk7gCU\n\tF0rLRvrD+lvSbsC5jMfBwQUdkYd5iKFVVsUsbt1Y4vIYToixLkoBm+OSGU5rGmBdITtD\n\t1E5g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=eIR3MVGby/dymFl1XAhYVzklHGNpDFvUa4zqKMvXn+k=;\n\tb=Sn00cwyOeBbyCikaZKOAM/w8p/G+LIpa0J1D2XiHLGARsDgK3w6xcFmJrRI9e4Ix9o\n\tm6enH80e/udVe+gojRe3KfjyqMW2hFDK+v0qm5ZhS7izDa3ZuU7br0MfRis2f7Ey/yyY\n\t+XR9TGzM9wJhlQDkgxnWOX2uq8+7XOLk7Ri6s2hCnSd/FmYTjjfuHzWTf/YjS9/W+YUc\n\tiob/+5nVeOhpGw9WaJEwmzd34vcZ8GV3JDOOg/0zf9aREff2+45n5T/iOPr5qu2njyTR\n\tML7d2VddCkO8PyWb4oxb23bQ8g6PRfm5MR0/bjdDhXDZELksT5n0X88lsojMVps0nIyy\n\tispA==", "X-Gm-Message-State": "AOAM532o34jJaNWX9VknsSqnHbX3GMhSvDX7w69h8HpwvHsfIxjHU9v/\n\tOy2BLeUty9BdrTm3+vCENJ3FNRrtwRF1iQ==", "X-Google-Smtp-Source": "ABdhPJwvKq1wgY+DavL4nOi9E5wSd4M0EWyP7vbeSGoCul6OyzmOrkRYEw7QS7cNBQc1dXpW/eLJyw==", "X-Received": "by 2002:a1c:98c7:: with SMTP id\n\ta190mr9100581wme.184.1607618020610; \n\tThu, 10 Dec 2020 08:33:40 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 10 Dec 2020 16:33:35 +0000", "Message-Id": "<20201210163337.212857-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v6 1/3] libcamera: controls: Add frame\n\tduration control", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a float array control (controls::FrameDurations) to specify the\nminimum and maximum (in that order) frame duration to be used by the\ncamera sensor.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nTested-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/control_ids.yaml | 40 ++++++++++++++++++++++++++++++++++\n 1 file changed, 40 insertions(+)", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 6d6f0fee..5ee31865 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -306,6 +306,46 @@ controls:\n maximum valid value is given by the properties::ScalerCropMaximum\n property, and the two can be used to implement digital zoom.\n \n+ - FrameDurations:\n+ type: int64_t\n+ description: |\n+ The minimum and maximum (in that order) frame duration,\n+ expressed in micro-seconds.\n+\n+ When provided by applications, the control specifies the sensor frame\n+ duration interval the pipeline has to use. This could also limit the\n+ largest exposure times the sensor can use. For example, if a maximum\n+ frame duration of 33ms is requested (corresponding to 30 frames per\n+ second), the sensor will not be able to raise the exposure time above\n+ 33ms. A fixed frame duration is achieved by setting the minimum and\n+ maximum values to be the same. Setting both values to 0 resets the\n+ frame duration to the IPA defaults.\n+\n+ The maximum frame duration provides the absolute limit to the shutter\n+ speed available to the AE algorithm. This limit also overrides any\n+ limits set by the exposure mode (AeExposureMode). Similarly, a manual\n+ ExposureTime value provided by the application may also be clipped by\n+ this limit.\n+\n+ \\sa AeExposureMode\n+ \\sa ExposureTime\n+\n+ \\todo Refer to the frame duration limits property to describe how\n+ application-provided values gets clipped.\n+\n+ When reported by pipelines, the control expresses the duration of the\n+ sensor frame used to produce streams part of the completed Request.\n+ The minimum and maximum values shall then be the same, as the sensor\n+ frame duration is a fixed parameter. The sensor frame duration is one\n+ of the parameter that defines the capture frame rate but it does not\n+ alone provide enough information to fully calculate it as it does not\n+ account for pipeline processing delays.\n+\n+ \\todo Define how to calculate the capture frame rate by\n+ defining controls to report additional delays introduced by\n+ the capture pipeline or post-processing stages (ie JPEG\n+ conversion, frame scaling).\n+\n # ----------------------------------------------------------------------------\n # Draft controls section\n \n", "prefixes": [ "libcamera-devel", "v6", "1/3" ] }