Patch Detail
Show a patch.
GET /api/patches/10629/?format=api
{ "id": 10629, "url": "https://patchwork.libcamera.org/api/patches/10629/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10629/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201209173520.284266-2-jacopo@jmondi.org>", "date": "2020-12-09T17:35:17", "name": "[libcamera-devel,1/3] libcamera: request: Mark metadata() and controls() as const", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "20ab72ed97498f69907f9ed129f1546ef88fd3af", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/10629/mbox/", "series": [ { "id": 1520, "url": "https://patchwork.libcamera.org/api/series/1520/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1520", "date": "2020-12-09T17:35:16", "name": "android: Add more metadata", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1520/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10629/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10629/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7ACD5BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 9 Dec 2020 17:35:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0FD4767F0B;\n\tWed, 9 Dec 2020 18:35:20 +0100 (CET)", "from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2DC946036E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 9 Dec 2020 18:35:17 +0100 (CET)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id C9C9D240005\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 9 Dec 2020 17:35:16 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 9 Dec 2020 18:35:17 +0100", "Message-Id": "<20201209173520.284266-2-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.29.1", "In-Reply-To": "<20201209173520.284266-1-jacopo@jmondi.org>", "References": "<20201209173520.284266-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/3] libcamera: request: Mark metadata()\n\tand controls() as const", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Mark the metadata() and controls() operations as const function to make\nit possible to retrieve them from const Request instances.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/request.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex 655b1324bae8..1a89622ab989 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -45,8 +45,8 @@ public:\n \n \tvoid reuse(ReuseFlag flags = Default);\n \n-\tControlList &controls() { return *controls_; }\n-\tControlList &metadata() { return *metadata_; }\n+\tControlList &controls() const { return *controls_; }\n+\tControlList &metadata() const { return *metadata_; }\n \tconst BufferMap &buffers() const { return bufferMap_; }\n \tint addBuffer(const Stream *stream, FrameBuffer *buffer);\n \tFrameBuffer *findBuffer(const Stream *stream) const;\n", "prefixes": [ "libcamera-devel", "1/3" ] }