Patch Detail
Show a patch.
GET /api/patches/10519/?format=api
{ "id": 10519, "url": "https://patchwork.libcamera.org/api/patches/10519/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10519/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201127140403.1104761-1-naush@raspberrypi.com>", "date": "2020-11-27T14:04:03", "name": "[libcamera-devel] cam: Update command line description for stream role option", "commit_ref": "743329b642d17b314421a8119a17300db3d796b2", "pull_url": null, "state": "accepted", "archived": false, "hash": "190c1d45a0c3579ba0df81a39acad08991dddf38", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10519/mbox/", "series": [ { "id": 1488, "url": "https://patchwork.libcamera.org/api/series/1488/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1488", "date": "2020-11-27T14:04:03", "name": "[libcamera-devel] cam: Update command line description for stream role option", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1488/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10519/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10519/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF7DEBE08A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 Nov 2020 14:04:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 65B766346F;\n\tFri, 27 Nov 2020 15:04:09 +0100 (CET)", "from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com\n\t[IPv6:2a00:1450:4864:20::42f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E4FB632EE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Nov 2020 15:04:08 +0100 (CET)", "by mail-wr1-x42f.google.com with SMTP id 23so5697384wrc.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Nov 2020 06:04:08 -0800 (PST)", "from naushir-VirtualBox.pitowers.org\n\t([2a00:1098:3142:14:a00:27ff:fe4d:f6a2])\n\tby smtp.gmail.com with ESMTPSA id\n\tz188sm8139960wmg.36.2020.11.27.06.04.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 27 Nov 2020 06:04:06 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"l0I5AcxH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=LqS9Ld+Eb7TcdYMvdWexD4yw69Enr/G6+EqloPGmxEQ=;\n\tb=l0I5AcxHR4KcB+m6mkow7W0uoqqu/A6hmiqovfEQk0N4dA7n2al+TqmCXIRu40D3sC\n\tjSd7nu7dzrJ1NeNsCpSAl3mVaz2i60e+Vsl0RYW6hzNMLSjtX6dyvvtjfQdk6pyuitWS\n\tu7gyW3VXWgEM/3oxT9PCMxb5d05vDdZMl7s83LpZs43CGROPjM/3LqImwIMx2PCCosJG\n\twpgAMqHd/l6UMasij23AvBW/Iw3cDj6VyegTTPoTYEmFXhDan7vM5EbUwsC4bDpZoAPd\n\tGmq9pjnozmBnZhO6k/gXt5d0KxCPGozU5RqnDK3DfJGUAtjYlx1SZ9LQrXSH1hN0iFwu\n\tZxiQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=LqS9Ld+Eb7TcdYMvdWexD4yw69Enr/G6+EqloPGmxEQ=;\n\tb=prUIE6wdd4q04f5qN1euMlru46tDg+3i2kB+lSiMXA3/RV4KjmKzCADYdnVsI4X6PR\n\teSNdEgoUM6loIFye/n22fD36tyqYa4Lj3egOtzCbgZgkxF9NKmG5edHKcyIlQx5p6Nhh\n\tLBLAB2GzSnJ9x/IKf17fwWCehpvuCXoTogmPpGd/m98l2eVD5BKYQAtKBRXxolZfxslb\n\tN27NCDwNwXBW0n1zoPiZ7nEaityFC/LhAgP+Vb4F04ALf30T2df2NwgxPRgNWcxpJPIu\n\tFE3BcZ6/EeePkiZ6hAMxLtmz0qPG4qc30boF4QCHlcU4LM3MSR4li0oi1xP6DisSX6M5\n\ty+Mw==", "X-Gm-Message-State": "AOAM532OzweQaR7bpcRVK9BHyFcRzHBSVAHPL+InHAylMTgffZYjYDn/\n\t4vciI5HOrOuTvIhZbxG79gZ60UxmRwD2Lg==", "X-Google-Smtp-Source": "ABdhPJxKGAS5DKLCPzby1FF9NZeDnL6ff88gwz2xW3sYyJlWdksCXA8LZy8Fi7qug2h9XGCq+DPvmw==", "X-Received": "by 2002:a5d:4d88:: with SMTP id b8mr5180286wru.134.1606485847465;\n\tFri, 27 Nov 2020 06:04:07 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 27 Nov 2020 14:04:03 +0000", "Message-Id": "<20201127140403.1104761-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] cam: Update command line description for\n\tstream role option", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The description text lists \"stillraw\" as a stream role option. This is\nincorrect, it should be listed as \"raw\" instead.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/cam/stream_options.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/cam/stream_options.cpp b/src/cam/stream_options.cpp\nindex 27cc3912..c58272c2 100644\n--- a/src/cam/stream_options.cpp\n+++ b/src/cam/stream_options.cpp\n@@ -13,7 +13,7 @@ using namespace libcamera;\n StreamKeyValueParser::StreamKeyValueParser()\n {\n \taddOption(\"role\", OptionString,\n-\t\t \"Role for the stream (viewfinder, video, still, stillraw)\",\n+\t\t \"Role for the stream (viewfinder, video, still, raw)\",\n \t\t ArgumentRequired);\n \taddOption(\"width\", OptionInteger, \"Width in pixels\",\n \t\t ArgumentRequired);\n", "prefixes": [ "libcamera-devel" ] }