Patch Detail
Show a patch.
GET /api/patches/10516/?format=api
{ "id": 10516, "url": "https://patchwork.libcamera.org/api/patches/10516/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10516/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201127133738.880859-2-tomi.valkeinen@iki.fi>", "date": "2020-11-27T13:37:35", "name": "[libcamera-devel,RFC,v2,1/4] hack: Camera public destructor", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "c7d632bcc0b80106ec9b2cd7157ed693a90bc4ff", "submitter": { "id": 70, "url": "https://patchwork.libcamera.org/api/people/70/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@iki.fi" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10516/mbox/", "series": [ { "id": 1487, "url": "https://patchwork.libcamera.org/api/series/1487/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1487", "date": "2020-11-27T13:37:34", "name": "prototype python bindings", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1487/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10516/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10516/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 89BE1BE176\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 Nov 2020 13:38:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 403966346C;\n\tFri, 27 Nov 2020 14:38:00 +0100 (CET)", "from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com\n\t[IPv6:2a00:1450:4864:20::22c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 76044633EF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Nov 2020 14:37:58 +0100 (CET)", "by mail-lj1-x22c.google.com with SMTP id y16so5986827ljk.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Nov 2020 05:37:58 -0800 (PST)", "from deskari.ti.com (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\tz199sm690892lfc.42.2020.11.27.05.37.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 27 Nov 2020 05:37:57 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"rdNUUAVJ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=IB2Br+8XqmcZu6tyYo+33NXr4FGzN3PCDjbwUoRN5lY=;\n\tb=rdNUUAVJx5z2TDeX9ZzY6Q4i8Pp7MbWL1pUMUd37tuo1exuNwbtjqkHMPNDPfTuifW\n\tSyflAML+QMtqD10ii4sHmAyds1Iyk2YCkgx2+IPMIEcY/jpbUM9vijXgssJX7Xi0cMSW\n\t1eBUrSxmK0Svqls/uEbpIpNMdksjvAJkSaMJ49dMudEhtFtZKiJ6yO7kYQaBmXKWPPdI\n\tdbYKVj+M/7VIldnm/DBE/czI5o9bSOrqpEJ4Vpcsq1Ang45A0/FKCfWqCh+CCjiBrkrE\n\tHcsoy/2QOC9/HP1PbNfKyTDqIiDfWGPyWoUk098dpsc4xQBb6sQikR8kzQ0eTU+LPX0Z\n\tvBRQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=IB2Br+8XqmcZu6tyYo+33NXr4FGzN3PCDjbwUoRN5lY=;\n\tb=QY/d/QpgxOYCb73oz+yKODYV36LlXLbbJIPzJlgaScyz5jL/IBFAb4Sn4VgyjZbN6/\n\tsCR9sxiMa4e85EpU5Ap9LuzKg1osIy9vLNgmpBbpYG263wYKKZG/vTxGe+S/EQuhflOj\n\tHHilDBJTkCwde8M5k/sy5S3+GBBnNWfT2+uDvO2reDZix4iy8d/sl3H5aVPzaObWp/2W\n\toSH51oVhRPQTHn3R7+AbxSfCDt0P4HBOiPdQ6+Fpejd8h0MGKwh8nYCrfKUzhgUkB8TD\n\tufCMZVA/DChcDJNMJPNrOdPGv2hnkl7YpaUc//1U7KSLgHz+6AAgFL3WLpiP0PrNV9ie\n\tsD6A==", "X-Gm-Message-State": "AOAM530UrxbSHEKmz5Vm8zf4Be/PbMaQNk/4c/bB3Ny+fNizDggEApLe\n\tqhVbilZ8HVTJkfiaHL5OanwetKsoH+I=", "X-Google-Smtp-Source": "ABdhPJwE+vJFVd4AXpMTkuPSCbHZrYukPptQgXoAoZQJxYKcyXEQEltOpOFAsfoEOBRtI+ItFAOltw==", "X-Received": "by 2002:a2e:99d7:: with SMTP id\n\tl23mr3465397ljj.303.1606484277739; \n\tFri, 27 Nov 2020 05:37:57 -0800 (PST)", "From": "Tomi Valkeinen <tomi.valkeinen@iki.fi>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 27 Nov 2020 15:37:35 +0200", "Message-Id": "<20201127133738.880859-2-tomi.valkeinen@iki.fi>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201127133738.880859-1-tomi.valkeinen@iki.fi>", "References": "<20201127133738.880859-1-tomi.valkeinen@iki.fi>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [RFC v2 1/4] hack: Camera public destructor", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Tomi Valkeinen <tomi.valkeinen@iki.fi>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Not clear why we need this with pybind11...\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@iki.fi>\n---\n include/libcamera/camera.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex 5c5f1a05..d8e0bdbc 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -106,10 +106,10 @@ public:\n \tint start();\n \tint stop();\n \n+\t~Camera();\n private:\n \tCamera(PipelineHandler *pipe, const std::string &id,\n \t const std::set<Stream *> &streams);\n-\t~Camera();\n \n \tfriend class PipelineHandler;\n \tvoid disconnect();\n", "prefixes": [ "libcamera-devel", "RFC", "v2", "1/4" ] }