Patch Detail
Show a patch.
GET /api/patches/10496/?format=api
{ "id": 10496, "url": "https://patchwork.libcamera.org/api/patches/10496/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10496/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201125113640.20246-4-david.plowman@raspberrypi.com>", "date": "2020-11-25T11:36:40", "name": "[libcamera-devel,3/3] src: ipa: raspberrypi: Fix initial AGC oscillation for imx219 sensor", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "94ad3560d8abf3c20c8a2be5b9dc3e2829a59a53", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10496/mbox/", "series": [ { "id": 1481, "url": "https://patchwork.libcamera.org/api/series/1481/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1481", "date": "2020-11-25T11:36:37", "name": "Raspberry Pi AGC improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1481/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10496/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10496/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A2402BE08A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 25 Nov 2020 11:36:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 71AA463411;\n\tWed, 25 Nov 2020 12:36:48 +0100 (CET)", "from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com\n\t[IPv6:2a00:1450:4864:20::42f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8ACDF6340A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 Nov 2020 12:36:46 +0100 (CET)", "by mail-wr1-x42f.google.com with SMTP id g14so1555333wrm.13\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 Nov 2020 03:36:46 -0800 (PST)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tb14sm4232371wrq.47.2020.11.25.03.36.45\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 25 Nov 2020 03:36:45 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"pZDBDZMO\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=CE6uEHlIE9O8XYmvvI4ab7mE8mycSjsTt8W0hUgGoYk=;\n\tb=pZDBDZMOy3g8HM0Xy4I8mFRiNHhvwkW4TkLTVKXmLANKvvXL/nwk3j52SHAc2CW3mz\n\tVT0M28r+cGm/ZAFrkeF7mWIHljaNuNwHZFKXIkS1Ew+3G7LcytfJWkNa8lzAQWKpU6qv\n\t+eOBSGeJR7RinridiwjUNzvhwNHA5KhRvcSVixIvw7iv4QjpPMkOLfws2A7qTVnb132J\n\t6OdhwQ3GFYZWHt0RxVqlMwf8PYAtTFowIoXkh3C+FP6cR4HtGRZmcmh1AFid0y6QxQHU\n\t7LHJ/fUA+nbPWUkM1iSXM+Z0RJ0VIqvEIqiybQGFNFQ89d+iYz7qoA6wxhop4KMssPUL\n\t3tTA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=CE6uEHlIE9O8XYmvvI4ab7mE8mycSjsTt8W0hUgGoYk=;\n\tb=KK65O21R9ormomJq6Ja+GJvBZ+/EKx8PZqrAJH6sTSF+a51m2CVVDKBMw77NIOKy0Q\n\tSLyr4cirEJCSpGF4TXocpAzLlZvuD+AHKJiDiWfmcpwMxuHgSBbyaxVhz6p6VpV9ASiy\n\t+jwGsu0YJqY0ac1lSjNhm0xiHK4S/a2ktQNCCwJ18qb+JZzpDWQ4TTjb9LylYjY0mkhB\n\tPIAQ0iUiSQkd0cIYOKKeFEGymJqpdUSV6t4nkEzP5WLqrVXJ+x58xUDCHCYHDyitr7Yi\n\tF74mfUk6XAdTkiwi6kHgADr4mPKDE1RTqhjwKmOqTyIxp+fuZhVeqPCPUtxcgkq5izPO\n\tnkAA==", "X-Gm-Message-State": "AOAM530FkFaQglXh/7T15tOIPajQWSNn9wcVBY+zlf45A2ZcXxV2006p\n\tTFoFEC90JW0OCYNXZSi9dJfMKBkfGhhVxdIW", "X-Google-Smtp-Source": "ABdhPJyzpwId8Om6RMRyva/4Z8sRQXxY/rehZmKDkhpDeAILC6XLUkQ+p0pZYfDqXUTccgFGcQDh+Q==", "X-Received": "by 2002:adf:f98a:: with SMTP id\n\tf10mr3663644wrr.154.1606304205971; \n\tWed, 25 Nov 2020 03:36:45 -0800 (PST)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 25 Nov 2020 11:36:40 +0000", "Message-Id": "<20201125113640.20246-4-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20201125113640.20246-1-david.plowman@raspberrypi.com>", "References": "<20201125113640.20246-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 3/3] src: ipa: raspberrypi: Fix initial\n\tAGC oscillation for imx219 sensor", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The exposure times in the exposure modes were causing AGC oscillations\nbecause the algorithm was demanding long unachievable exposure times\nbut, without working sensor metadata, thought it was getting them when\nactually it was not. We fix it by making the exposure profile request\nonly achievable exposure times, as we do for the ov5647 tuning.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/data/imx219.json | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json\nindex b03a7beb..212f8b9a 100644\n--- a/src/ipa/raspberrypi/data/imx219.json\n+++ b/src/ipa/raspberrypi/data/imx219.json\n@@ -133,7 +133,7 @@\n {\n \"shutter\":\n [\n- 100, 10000, 30000, 60000, 120000\n+ 100, 10000, 30000, 30000, 30000\n ],\n \"gain\":\n [\n@@ -144,7 +144,7 @@\n {\n \"shutter\":\n [\n- 100, 5000, 10000, 20000, 120000\n+ 100, 5000, 10000, 20000, 30000\n ],\n \"gain\":\n [\n", "prefixes": [ "libcamera-devel", "3/3" ] }