Patch Detail
Show a patch.
GET /api/patches/10457/?format=api
{ "id": 10457, "url": "https://patchwork.libcamera.org/api/patches/10457/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10457/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201120150021.81865-1-kieran.bingham@ideasonboard.com>", "date": "2020-11-20T15:00:21", "name": "[libcamera-devel] libcamera: controls: Improve Control documentation grammar", "commit_ref": "a97ba61b2d2048cdbebc0f71aae1ea5fdd64c5ac", "pull_url": null, "state": "accepted", "archived": false, "hash": "f1b1608e911381857ee1798c1f1a69ebf5646e1c", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10457/mbox/", "series": [ { "id": 1473, "url": "https://patchwork.libcamera.org/api/series/1473/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1473", "date": "2020-11-20T15:00:21", "name": "[libcamera-devel] libcamera: controls: Improve Control documentation grammar", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1473/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10457/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10457/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 17093BE176\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 20 Nov 2020 15:00:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 94A57628A5;\n\tFri, 20 Nov 2020 16:00:26 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A260B6220D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 20 Nov 2020 16:00:25 +0100 (CET)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 320A32A3;\n\tFri, 20 Nov 2020 16:00:25 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vIJqfi9e\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1605884425;\n\tbh=Giaax5zJR+5BlK85eAW6v3WGp/tH19KfH4okeTYdE18=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=vIJqfi9eQMrzES+pyQagM3uND2R1bzN0YTJGsRsWVVQUzGloAMk4b/fvtWUZJL2nU\n\thbgOHLgKWOfdF/58UcuDgBb54Hjx3d9YYi+Di5vBJyeePYxFuur20WrEkecoj7mUAL\n\tJwTRuDy+BCuye9zOToWgyYqk3wZLOTR8V6tMuLak=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Fri, 20 Nov 2020 15:00:21 +0000", "Message-Id": "<20201120150021.81865-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: controls: Improve Control\n\tdocumentation grammar", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "A few grammatical errors remain in the Control class documentation.\nFix them.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/controls.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex aad461121651..c58ed3946f3b 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -437,8 +437,8 @@ void ControlValue::reserve(ControlType type, bool isArray, std::size_t numElemen\n * the control value. See for instance how the ControlList::get() method\n * returns a value corresponding to the type of the requested control.\n *\n- * While this class is the main mean to refer to a control, the control\n- * identifying information are stored in the non-template base ControlId class.\n+ * While this class is the main means to refer to a control, the control\n+ * identifying information is stored in the non-template base ControlId class.\n * This allows code that operates on a set of controls of different types to\n * reference those controls through a ControlId instead of a Control. For\n * instance, the list of controls supported by a camera is exposed as ControlId\n", "prefixes": [ "libcamera-devel" ] }