Patch Detail
Show a patch.
GET /api/patches/10454/?format=api
{ "id": 10454, "url": "https://patchwork.libcamera.org/api/patches/10454/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10454/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201120111618.15449-3-david.plowman@raspberrypi.com>", "date": "2020-11-20T11:16:18", "name": "[libcamera-devel,v2,2/2] src: ipa: raspberrypi: Change 'sport' exposure mode name to 'short'", "commit_ref": "666905182511153f86d041dcc501f6fc37ba793b", "pull_url": null, "state": "accepted", "archived": false, "hash": "de6d7e227e69dbeeb98b65f25aba85b6565b2f99", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10454/mbox/", "series": [ { "id": 1471, "url": "https://patchwork.libcamera.org/api/series/1471/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1471", "date": "2020-11-20T11:16:16", "name": "Raspberry Pi control fixes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1471/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10454/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10454/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7994BE176\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 20 Nov 2020 11:16:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78AAC615BA;\n\tFri, 20 Nov 2020 12:16:27 +0100 (CET)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF1D661564\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 20 Nov 2020 12:16:24 +0100 (CET)", "by mail-wm1-x335.google.com with SMTP id s13so9461917wmh.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 20 Nov 2020 03:16:24 -0800 (PST)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tj127sm4249805wma.31.2020.11.20.03.16.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 20 Nov 2020 03:16:23 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"DuTDrFN8\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=ScTxAk2XTU9v/GfpkgrLqLe0zx+rvFymh1hyQh3pJuc=;\n\tb=DuTDrFN8txuDM7TWphNJKJLdIKR7MCm4kRWrLqqCU7Ey1kyqdea70xyrV90N6h+eHs\n\thU86ENEQoK4e1OKdhZw77+4+gVHFaQVQy5sUvNKz+AIcefVlu9kfH8XvsXEP8s/ikOVM\n\t0oEATlJsIopDKvROqre28n1HVlbIpdodyQHGA5KM/qekNsGxlDud2e131bAuyCi7nymZ\n\thHGoE8oxfyEapYjY1ESnfF/IfJxbV8Dsc/Ax9Eb/Plb6bA+uqUbMbE+waan9Fs9klD8F\n\ty9p4HoQBn/LyXTHkJTgico4gx1gySx5AdIgSzzMOPNZ/b6HGg9N+bfDPtnf8f82jmR/v\n\t4urA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=ScTxAk2XTU9v/GfpkgrLqLe0zx+rvFymh1hyQh3pJuc=;\n\tb=ZNsnk3pa/lzcyTvSolhWHK6m8VFGHrH4vitvyarmbTkzFV4EWK3V1DM18cY7+KTRwV\n\tMEeJ1Klt5i5MW/6HZ1rbIUjqfcjOp9cYTlEavVH6GnF6kcBgH/CzBFMXEWwxEQYdV4uS\n\tKz8KYugh1Ny6vU+55v7rUpll3WkfescH4z8/Fm3JTmTuyGh2SZzKoeald/3FN2cKSmxb\n\tcvD4PwwJcC0D2MrCYij5xTmzGqDQdRNeNRSKRI7zACkJPBgysv4xTbCtq1oH+MxC3RkF\n\tGIJgshgzljMqbQnOFKC4QwRgCN1H+65IKDbiIyUWOd+8MI/kF0b8fAj0v9h/da0NQaeY\n\tWocQ==", "X-Gm-Message-State": "AOAM531TbNt977bHSStCUBzHuOyq9hysaqsAg0ALNtrw5dOIl7w+ylsj\n\tKJoGkgktZ0r7Zyz10S58WvE1abC0CKQVEQ==", "X-Google-Smtp-Source": "ABdhPJyQ0byQK3vaARwkP7W2Fjpa6leZbbqRMZDNDvq/Vc3NXSjqpNQEe0qbVyWu4xiqtGbeJoJmPw==", "X-Received": "by 2002:a1c:e206:: with SMTP id z6mr1791162wmg.49.1605870984317; \n\tFri, 20 Nov 2020 03:16:24 -0800 (PST)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 20 Nov 2020 11:16:18 +0000", "Message-Id": "<20201120111618.15449-3-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20201120111618.15449-1-david.plowman@raspberrypi.com>", "References": "<20201120111618.15449-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 2/2] src: ipa: raspberrypi: Change\n\t'sport' exposure mode name to 'short'", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The names have to match for the setting to work. Use the libcamera\nterminology for consistency (even though it touches more files).\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/raspberrypi/data/imx219.json | 2 +-\n src/ipa/raspberrypi/data/imx477.json | 2 +-\n src/ipa/raspberrypi/data/ov5647.json | 2 +-\n utils/raspberrypi/ctt/ctt.py | 2 +-\n 4 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json\nindex ce7ff36f..b03a7beb 100644\n--- a/src/ipa/raspberrypi/data/imx219.json\n+++ b/src/ipa/raspberrypi/data/imx219.json\n@@ -140,7 +140,7 @@\n 1.0, 2.0, 4.0, 6.0, 6.0\n ]\n },\n- \"sport\":\n+ \"short\":\n {\n \"shutter\":\n [\ndiff --git a/src/ipa/raspberrypi/data/imx477.json b/src/ipa/raspberrypi/data/imx477.json\nindex 73ad1ae9..12fe2f41 100644\n--- a/src/ipa/raspberrypi/data/imx477.json\n+++ b/src/ipa/raspberrypi/data/imx477.json\n@@ -140,7 +140,7 @@\n 1.0, 2.0, 4.0, 6.0, 6.0\n ]\n },\n- \"sport\":\n+ \"short\":\n {\n \"shutter\":\n [\ndiff --git a/src/ipa/raspberrypi/data/ov5647.json b/src/ipa/raspberrypi/data/ov5647.json\nindex a2469059..3d8a7c8f 100644\n--- a/src/ipa/raspberrypi/data/ov5647.json\n+++ b/src/ipa/raspberrypi/data/ov5647.json\n@@ -140,7 +140,7 @@\n 1.0, 2.0, 4.0, 6.0, 6.0\n ]\n },\n- \"sport\":\n+ \"short\":\n {\n \"shutter\":\n [\ndiff --git a/utils/raspberrypi/ctt/ctt.py b/utils/raspberrypi/ctt/ctt.py\nindex 30d35ae4..15064634 100755\n--- a/utils/raspberrypi/ctt/ctt.py\n+++ b/utils/raspberrypi/ctt/ctt.py\n@@ -130,7 +130,7 @@ class Camera:\n \"shutter\": [100, 10000, 30000, 60000, 120000],\n \"gain\": [1.0, 2.0, 4.0, 6.0, 6.0]\n },\n- \"sport\": {\n+ \"short\": {\n \"shutter\": [100, 5000, 10000, 20000, 120000],\n \"gain\": [1.0, 2.0, 4.0, 6.0, 6.0]\n }\n", "prefixes": [ "libcamera-devel", "v2", "2/2" ] }