Patch Detail
Show a patch.
GET /api/patches/10420/?format=api
{ "id": 10420, "url": "https://patchwork.libcamera.org/api/patches/10420/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10420/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201113063815.10288-6-laurent.pinchart@ideasonboard.com>", "date": "2020-11-13T06:38:15", "name": "[libcamera-devel,v1,5/5] cam: Move request processing to main thread", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1a313753bde7dbe198d3284972f9d61b9bae97cd", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10420/mbox/", "series": [ { "id": 1458, "url": "https://patchwork.libcamera.org/api/series/1458/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1458", "date": "2020-11-13T06:38:10", "name": "cam: Move request processing to main thread", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1458/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10420/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10420/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0DB70BE087\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 13 Nov 2020 06:38:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CEDA1631BB;\n\tFri, 13 Nov 2020 07:38:28 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BBDD0631AF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Nov 2020 07:38:25 +0100 (CET)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 564E931A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Nov 2020 07:38:25 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bZOpT2nl\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1605249505;\n\tbh=OT5kCj+F5K1amOrwit6pzf8qkWfAK4e28PKcTJzGQlg=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=bZOpT2nlhrbtvTppjqR4dRp0BUcVurBxnmHRIIdpsK8N0PfGPXqAH2wpT20p+0PxG\n\tV5zksVfAqd16/pelzWsROaeAkyQbm96HeU+LfwLcaRvCCLRp2h7SOruDpa9/9/1BTm\n\txYOycrbBN1dad73Pxdnc9m9+whhkD/bcvhZtFipM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 13 Nov 2020 08:38:15 +0200", "Message-Id": "<20201113063815.10288-6-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201113063815.10288-1-laurent.pinchart@ideasonboard.com>", "References": "<20201113063815.10288-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v1 5/5] cam: Move request processing to\n\tmain thread", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The request completion handler is invoked in the camera manager thread,\nwhich shouldn't be blocked for large amounts of time. As writing the\nframes to disk can be a time-consuming process, move request processing\nto the main thread by queueing an event to the event loop.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/capture.cpp | 9 +++++++++\n src/cam/capture.h | 1 +\n 2 files changed, 10 insertions(+)", "diff": "diff --git a/src/cam/capture.cpp b/src/cam/capture.cpp\nindex 7580f798288c..43b109d099f6 100644\n--- a/src/cam/capture.cpp\n+++ b/src/cam/capture.cpp\n@@ -157,6 +157,15 @@ void Capture::requestComplete(Request *request)\n \tif (request->status() == Request::RequestCancelled)\n \t\treturn;\n \n+\t/*\n+\t * Defer processing of the completed request to the event loop, to avoid\n+\t * blocking the camera manager thread.\n+\t */\n+\tloop_->callLater(std::bind(&Capture::processRequest, this, request));\n+}\n+\n+void Capture::processRequest(Request *request)\n+{\n \tconst Request::BufferMap &buffers = request->buffers();\n \n \t/*\ndiff --git a/src/cam/capture.h b/src/cam/capture.h\nindex 45e5e8a9ba27..d21c95a26ce7 100644\n--- a/src/cam/capture.h\n+++ b/src/cam/capture.h\n@@ -33,6 +33,7 @@ private:\n \tint capture(libcamera::FrameBufferAllocator *allocator);\n \n \tvoid requestComplete(libcamera::Request *request);\n+\tvoid processRequest(libcamera::Request *request);\n \n \tstd::shared_ptr<libcamera::Camera> camera_;\n \tlibcamera::CameraConfiguration *config_;\n", "prefixes": [ "libcamera-devel", "v1", "5/5" ] }