Patch Detail
Show a patch.
GET /api/patches/10369/?format=api
{ "id": 10369, "url": "https://patchwork.libcamera.org/api/patches/10369/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10369/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201106103707.49660-22-paul.elder@ideasonboard.com>", "date": "2020-11-06T10:36:51", "name": "[libcamera-devel,v4,21/37] libcamera: IPAManager: Fetch IPAProxy corresponding to pipeline", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1fd9b3792b7a4a298c413075a32da0bd34e4f93e", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10369/mbox/", "series": [ { "id": 1448, "url": "https://patchwork.libcamera.org/api/series/1448/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1448", "date": "2020-11-06T10:36:30", "name": "IPA isolation implementation", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1448/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10369/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10369/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5C6AFBDB89\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 6 Nov 2020 10:38:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 27F2B62D25;\n\tFri, 6 Nov 2020 11:38:08 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C98C862D3B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Nov 2020 11:38:06 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 574B9A19;\n\tFri, 6 Nov 2020 11:38:05 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"adUk3fei\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604659086;\n\tbh=Cgrsu1xsWB6ie9/UIzoIZla/MBADo116dykXSXPaabs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=adUk3feiFXEHxSlW2hrgaj1fnoSR13Xhzawy/wIYSdCHIyGWW7tY4zMY5flH/Q5v9\n\tev7xeX9nQ913mF3+j6n4gD3uBypWNKNquOH9YWNtUQ+Po76XctNjxvF+0flenFVH5G\n\tj89GwWRtqyst/TMjhRa/EZGK2weoKsRdODgc6ovU=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 6 Nov 2020 19:36:51 +0900", "Message-Id": "<20201106103707.49660-22-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201106103707.49660-1-paul.elder@ideasonboard.com>", "References": "<20201106103707.49660-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 21/37] libcamera: IPAManager: Fetch\n\tIPAProxy corresponding to pipeline", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that each pipeline handler has its own IPAProxy implementation, make\nthe IPAManager fetch the IPAProxy based on the pipeline handler name.\nAlso, since the IPAProxy is used regardless of isolation or no\nisolation, remove the isolation check from the proxy selection.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nNo change in v4\n\nNo change in v3\n\nNo change in v2\n---\n src/libcamera/ipa_manager.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\nindex ad05b9c9..12cf3b0d 100644\n--- a/src/libcamera/ipa_manager.cpp\n+++ b/src/libcamera/ipa_manager.cpp\n@@ -275,8 +275,8 @@ std::unique_ptr<IPAProxy> IPAManager::createIPA(PipelineHandler *pipe,\n \t *\n \t * \\todo Implement a better proxy selection\n \t */\n-\tconst char *proxyName = self_->isSignatureValid(m)\n-\t\t\t ? \"IPAProxyThread\" : \"IPAProxyLinux\";\n+\tstd::string pipeName(pipe->name());\n+\tconst char *proxyName = pipeName.replace(0, 15, \"IPAProxy\").c_str();\n \tIPAProxyFactory *pf = nullptr;\n \n \tfor (IPAProxyFactory *factory : IPAProxyFactory::factories()) {\n", "prefixes": [ "libcamera-devel", "v4", "21/37" ] }