Patch Detail
Show a patch.
GET /api/patches/10319/?format=api
{ "id": 10319, "url": "https://patchwork.libcamera.org/api/patches/10319/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10319/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201103133042.30341-1-laurent.pinchart@ideasonboard.com>", "date": "2020-11-03T13:30:41", "name": "[libcamera-devel,1/2] libcamera: pipeline: vivid: Set camera properties", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cb1f6850c5649dfe82e3184d676e1eb0657fa439", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": { "id": 14, "url": "https://patchwork.libcamera.org/api/users/14/?format=api", "username": "pinchartl", "first_name": "Laurent", "last_name": "Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10319/mbox/", "series": [ { "id": 1440, "url": "https://patchwork.libcamera.org/api/series/1440/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1440", "date": "2020-11-03T13:30:41", "name": "[libcamera-devel,1/2] libcamera: pipeline: vivid: Set camera properties", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1440/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10319/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10319/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93CBDBDB89\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 3 Nov 2020 13:31:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0806A62BDA;\n\tTue, 3 Nov 2020 14:31:36 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EBC0062B7E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 3 Nov 2020 14:31:34 +0100 (CET)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 71BC6563\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 3 Nov 2020 14:31:34 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QHKZnQxy\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604410294;\n\tbh=0dp6JcYWqTNo3WQWcZpGjZRSd32st+iATc/ULIj1rUk=;\n\th=From:To:Subject:Date:From;\n\tb=QHKZnQxybafOv+Mdoeto3O0ieiHNo4/e31TuUGcM8T8jdS9J8GnQKLTPCK8UsQonZ\n\t7GmdYG3ugBGP9HC0iY9+ad4aciKGHI9Lqbj3Elt2yAxD2ZbpLVQyCddYz4fHxL68Re\n\ty0pfALs5QD/LLS5k8g4WC8h8frLABhtoji6ErFGA=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 3 Nov 2020 15:30:41 +0200", "Message-Id": "<20201103133042.30341-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/2] libcamera: pipeline: vivid: Set\n\tcamera properties", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Initialize the CameraData properties with Location and Model.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/vivid/vivid.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/vivid/vivid.cpp b/src/libcamera/pipeline/vivid/vivid.cpp\nindex 67b0d85b6629..bf8f82af981f 100644\n--- a/src/libcamera/pipeline/vivid/vivid.cpp\n+++ b/src/libcamera/pipeline/vivid/vivid.cpp\n@@ -11,6 +11,7 @@\n #include <libcamera/control_ids.h>\n #include <libcamera/controls.h>\n #include <libcamera/formats.h>\n+#include <libcamera/property_ids.h>\n \n #include \"libcamera/internal/device_enumerator.h\"\n #include \"libcamera/internal/log.h\"\n@@ -336,7 +337,7 @@ int VividCameraData::init()\n \n \tvideo_->bufferReady.connect(this, &VividCameraData::bufferReady);\n \n-\t/* Initialise the supported controls. */\n+\t/* Initialise the supported controls and properties. */\n \tconst ControlInfoMap &controls = video_->controls();\n \tControlInfoMap::Map ctrls;\n \n@@ -366,6 +367,9 @@ int VividCameraData::init()\n \n \tcontrolInfo_ = std::move(ctrls);\n \n+\tproperties_.set(properties::Location, properties::CameraLocationExternal);\n+\tproperties_.set(properties::Model, \"Virtual Video Device\");\n+\n \treturn 0;\n }\n \n", "prefixes": [ "libcamera-devel", "1/2" ] }