Patch Detail
Show a patch.
GET /api/patches/10303/?format=api
{ "id": 10303, "url": "https://patchwork.libcamera.org/api/patches/10303/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10303/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201030013735.15603-1-laurent.pinchart@ideasonboard.com>", "date": "2020-10-30T01:37:35", "name": "[libcamera-devel] utils: hooks: pre-push: Reject commits with a Change-Id", "commit_ref": "4757ff4ab7b4dac560cad26db12e28ef741c96ff", "pull_url": null, "state": "accepted", "archived": false, "hash": "2f69e98ad7a09ba5a2e8066232a84823111cf75a", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10303/mbox/", "series": [ { "id": 1433, "url": "https://patchwork.libcamera.org/api/series/1433/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1433", "date": "2020-10-30T01:37:35", "name": "[libcamera-devel] utils: hooks: pre-push: Reject commits with a Change-Id", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1433/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10303/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10303/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B1B0FBDB1E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 30 Oct 2020 01:38:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 44E0E628A5;\n\tFri, 30 Oct 2020 02:38:33 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A1F160353\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Oct 2020 02:38:32 +0100 (CET)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 90C939B7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Oct 2020 02:38:31 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KwriusK6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604021911;\n\tbh=5Y6ejcLZt+YEHXjFc1QadM8uDXtql5wH6379Md3oVWE=;\n\th=From:To:Subject:Date:From;\n\tb=KwriusK6Nqbk4jcWiArCnz4n4P4mw0xouuCZe56elKpK/9C23pPafhgGTlt+FsWFL\n\tUhDBC0Ez9ZuaqmbK+yg1k6kV6b9B1dRPLTnLXBVSfS7f75XW+dT4s7GgiPRE4urRqX\n\tqvddWJPddRQ9+vUQXXR7ADRGI6vfpamjts9XNY6U=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 30 Oct 2020 03:37:35 +0200", "Message-Id": "<20201030013735.15603-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] utils: hooks: pre-push: Reject commits\n\twith a Change-Id", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We're not using gerrit, so let's prevent Change-Id tags creeping in\nunadvertently.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n utils/hooks/pre-push | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/utils/hooks/pre-push b/utils/hooks/pre-push\nindex 2417d379db4c..d13e2c3b506c 100755\n--- a/utils/hooks/pre-push\n+++ b/utils/hooks/pre-push\n@@ -63,6 +63,13 @@ do\n \t\t\techo >&2 \"No Reviewed-by or Acked-by in commit $commit\"\n \t\t\terrors=$((errors+1))\n \t\tfi\n+\n+\t\t# 4. The commit message shall not contain a Change-Id.\n+\t\tif echo \"$msg\" | grep -q '^Change-Id:'\n+\t\tthen\n+\t\t\techo >&2 \"Found Change-Id in commit $commit\"\n+\t\t\terrors=$((errors+1))\n+\t\tfi\n \tdone\n \n \tif [ $errors != 0 ]\n", "prefixes": [ "libcamera-devel" ] }